Breaking changes to experiment build process. #13
+26,015
−174,961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wref: https://handlebarsjs.com/guide/expressions.html#html-escaping Fixes HTML not rendering inside answer #19 : #19
Render html in options too
* Add versioning support to quiz * 2.0 * Add support for explanation * Correct answers based on filter * TODO: Add filter * Fix few bugs * Fixed: Did not render first question of old format * Fixed: Console log spam if explanation is not provided * Create dynamically populated filter * Add functionality to filter * Fix answers not working after filtering * Link exp.js * As both have same contents, let's just link them * Update json requirement * Schema to be created * Generalise difficulty levels * Also add support for difficulty levels containing space * Use set range of difficulty levels * Beginner, Intermediate and Advanced * Add accordion * Switch to cheeckboxes * Don't use trim * As we have fixed difficulty levels * Check if user has answered before considering showing examples * Slightly revamp question iteraions * Consider question which don't have difficulty level mentioned too * Make explanations look better * "Explanation: " in the beginning looks weird * Condition or correct variable * version2 script was being used for oldones too * Continuation to explanation aestathics * We have them at two places * Don't scroll up on clicking explanation * Remove unused css * Suggested code formatting * Use Strict * Fix undeclared vars * Remove no longer used handlebar helper Signed-off-by: vjspranav <pranavasri@live.in> * Use camel ase throughout * use const where possible * CamelCase: continuation to previous commit * Refactor code * Use forEach where applicable * Make variables const where possible * Use bootstrap styling for checkboxes * [FIXUP] Add eventlistener only to avaialble difficulty levels * Color only the wrong answer red * Render html in options too * https://handlebarsjs.com/guide/expressions.html#html-escaping * Classify questions as beginner by default * Questions with no difficulty (or wrong difficulty) will be classified as beginner * Remove additional logging info * Remove commented old implememtation of checkbox * Use proper json variable * jsonVersion -> isJsonVersion2 * Follow camlCase naming convention` * Add a small comment referencing the version in script
…ork (#23) * Also correct a code breaking typo
* Quiz enchancement (#16) * Add versioning support to quiz * 2.0 * Add support for explanation * Correct answers based on filter * TODO: Add filter * Fix few bugs * Fixed: Did not render first question of old format * Fixed: Console log spam if explanation is not provided * Create dynamically populated filter * Add functionality to filter * Fix answers not working after filtering * Link exp.js * As both have same contents, let's just link them * Update json requirement * Schema to be created * Generalise difficulty levels * Also add support for difficulty levels containing space * Use set range of difficulty levels * Beginner, Intermediate and Advanced * Add accordion * Switch to cheeckboxes * Don't use trim * As we have fixed difficulty levels * Check if user has answered before considering showing examples * Slightly revamp question iteraions * Consider question which don't have difficulty level mentioned too * Make explanations look better * "Explanation: " in the beginning looks weird * Condition or correct variable * version2 script was being used for oldones too * Continuation to explanation aestathics * We have them at two places * Don't scroll up on clicking explanation * Remove unused css * Suggested code formatting * Use Strict * Fix undeclared vars * Remove no longer used handlebar helper Signed-off-by: vjspranav <pranavasri@live.in> * Use camel ase throughout * use const where possible * CamelCase: continuation to previous commit * Refactor code * Use forEach where applicable * Make variables const where possible * Use bootstrap styling for checkboxes * [FIXUP] Add eventlistener only to avaialble difficulty levels * Color only the wrong answer red * Render html in options too * https://handlebarsjs.com/guide/expressions.html#html-escaping * Classify questions as beginner by default * Questions with no difficulty (or wrong difficulty) will be classified as beginner * Remove additional logging info * Remove commented old implememtation of checkbox * Use proper json variable * jsonVersion -> isJsonVersion2 * Follow camlCase naming convention` * Add a small comment referencing the version in script * Fix an issue where if same difficulty level is mentioned it doesn't work (#23) * Also correct a code breaking typo
* Fix padding issue * Tweaks in padding * Fix navbar for mobile * Fix footer, made navbar responsive * fix spacing in title and sidebar * Modify toggle sidebar and frame resize, tweak css * Fix orientation of expanded submenu in navbar
* Added metadata in page template for all experiment pages. * Code review fixes.
#36) * Added dummy arguments required for testing env * Added support for repos starting with tmp * Revert "Added support for repos starting with tmp" This reverts commit 0861c9d. * fixed reference error * fixed errors * fixed errors * fixed more errors * fixed more errors * fixed more errors * fixed more errors * Added alternate way to get Experiment name * Added code to convert html encoded experiment name to text * Disabled conversion of text to uppercase * Converted college name to uppercase
* Fix padding issue * Tweaks in padding * Fix navbar for mobile * Fix footer, made navbar responsive * fix spacing in title and sidebar * Modify toggle sidebar and frame resize, tweak css * Fix orientation of expanded submenu in navbar * Revamped navbar menu, made simulation container fullscreen * Refactor nav-menu items, change var to const
* fixes questions not appearing in bold ref: #39
Add missing class to questions in quiz v1
* Also add a line underneath wref: #4
Improve appearance of Difficulty filter.
* Make Options appear in separate rows in mobile view.;
* Fix filter on ipad view
* Initial changes for building blugins * Initial support for plugin with rendering in js * Interim commit for preBuildPlugins * Refactor code to move plugin related functionality in a separate class * Added code for Experiment level processing * removed unnecessary imports * Plugin logic. * Bug fix. * Debugging. * Bug fix. * Bug fix. * Debugging. * Bug fix. * Bug fix. * Debugging. * Debugging. * Debugging. * Debugging. * Bug fix. * Bug fix. * Bug fix for logo. * Bug fix in links to exp pages. * Tools breadcrumbs added. * Code review fixes. * Code review fixes. * Code review fixes. * Fixed readme title. * Bug fix. * Plugins imported as non-repos by removing .git dirs from repos. * Change to modular approach. * Removed commented code. * Code review fixes. Co-authored-by: vjspranav <pranavasri@live.in> Co-authored-by: r <raj@vlabs.ac.in>
* Quiz enchancement (#16) * Add versioning support to quiz * 2.0 * Add support for explanation * Correct answers based on filter * TODO: Add filter * Fix few bugs * Fixed: Did not render first question of old format * Fixed: Console log spam if explanation is not provided * Create dynamically populated filter * Add functionality to filter * Fix answers not working after filtering * Link exp.js * As both have same contents, let's just link them * Update json requirement * Schema to be created * Generalise difficulty levels * Also add support for difficulty levels containing space * Use set range of difficulty levels * Beginner, Intermediate and Advanced * Add accordion * Switch to cheeckboxes * Don't use trim * As we have fixed difficulty levels * Check if user has answered before considering showing examples * Slightly revamp question iteraions * Consider question which don't have difficulty level mentioned too * Make explanations look better * "Explanation: " in the beginning looks weird * Condition or correct variable * version2 script was being used for oldones too * Continuation to explanation aestathics * We have them at two places * Don't scroll up on clicking explanation * Remove unused css * Suggested code formatting * Use Strict * Fix undeclared vars * Remove no longer used handlebar helper Signed-off-by: vjspranav <pranavasri@live.in> * Use camel ase throughout * use const where possible * CamelCase: continuation to previous commit * Refactor code * Use forEach where applicable * Make variables const where possible * Use bootstrap styling for checkboxes * [FIXUP] Add eventlistener only to avaialble difficulty levels * Color only the wrong answer red * Render html in options too * https://handlebarsjs.com/guide/expressions.html#html-escaping * Classify questions as beginner by default * Questions with no difficulty (or wrong difficulty) will be classified as beginner * Remove additional logging info * Remove commented old implememtation of checkbox * Use proper json variable * jsonVersion -> isJsonVersion2 * Follow camlCase naming convention` * Add a small comment referencing the version in script * Fix an issue where if same difficulty level is mentioned it doesn't work (#23) * Also correct a code breaking typo * Fix responsiveness and spacing issues (#28) * Fix padding issue * Tweaks in padding * Fix navbar for mobile * Fix footer, made navbar responsive * fix spacing in title and sidebar * Modify toggle sidebar and frame resize, tweak css * Fix orientation of expanded submenu in navbar * Added metadata in page template for all experiment pages. (#33) * Added metadata in page template for all experiment pages. * Code review fixes. * Added analytics and data configuration required for the testing branch (#36) * Added dummy arguments required for testing env * Added support for repos starting with tmp * Revert "Added support for repos starting with tmp" This reverts commit 0861c9d. * fixed reference error * fixed errors * fixed errors * fixed more errors * fixed more errors * fixed more errors * fixed more errors * Added alternate way to get Experiment name * Added code to convert html encoded experiment name to text * Disabled conversion of text to uppercase * Converted college name to uppercase * Revamped navbar menu, made simulation container fullscreen (#35) * Fix padding issue * Tweaks in padding * Fix navbar for mobile * Fix footer, made navbar responsive * fix spacing in title and sidebar * Modify toggle sidebar and frame resize, tweak css * Fix orientation of expanded submenu in navbar * Revamped navbar menu, made simulation container fullscreen * Refactor nav-menu items, change var to const * Plugin processing (#38) * Initial changes for building blugins * Initial support for plugin with rendering in js * Interim commit for preBuildPlugins * Refactor code to move plugin related functionality in a separate class * Added code for Experiment level processing * removed unnecessary imports * Plugin logic. * Bug fix. * Debugging. * Bug fix. * Bug fix. * Debugging. * Bug fix. * Bug fix. * Debugging. * Debugging. * Debugging. * Debugging. * Bug fix. * Bug fix. * Bug fix for logo. * Bug fix in links to exp pages. * Tools breadcrumbs added. * Code review fixes. * Code review fixes. * Code review fixes. * Fixed readme title. * Bug fix. * Plugins imported as non-repos by removing .git dirs from repos. * Change to modular approach. * Removed commented code. * Code review fixes. Co-authored-by: vjspranav <pranavasri@live.in> Co-authored-by: r <raj@vlabs.ac.in> Co-authored-by: Vjs Pranavasri <pranavasri@live.in> Co-authored-by: Shaurya Dewan <56212873+SRDewan@users.noreply.github.com> Co-authored-by: raj-vlabs <58244900+raj-vlabs@users.noreply.github.com> Co-authored-by: r <raj@vlabs.ac.in>
* Add nav to simulation page, tweak lab landing page * Move http to https * Move title to center * Rename class, fix url
* Create common-styles-responsive.css * Follow uniform style * Add comments describing the symbol
fix: adding license.org and build/ to lab repo.
Changing the font awesome link from "fonts/css/font-awesome.min.css" to "css/fontawesome.min.css" will fix the issue of social media icons not appearing on lab pages.
social icon re-fixes
Updated node version to 22
This reverts commit 44094ff.
For the issue - #499
For fixing issues : virtual-labs/svc-bug-report#12 #506
This fix is with reference to the issue : Form submission and Include screenshot - functionality needs fixing #13 (link - virtual-labs/svc-bug-report#13)
fix for Rating of a lab is not shown at all. (#522)
Removed the global initialization of dataLayer and added conditional checks for dataLayer. Ref - #506
color coding for answers
deleting the file from the code
The previous version quiz is fixed as per current display logic
For the issue - #506
error message handled well: 1. Logged the technical detailed error 2. Removed unnecessary exposure of the error to the user.
Error toast will be shown while bug reporting
Separate file explaining the question answer json formatting in detail is added.
Adding a new doc file for explaining json structures for pretest and posttest pages
Correcting the syntax for explanations.
1. Converted content suitable for md file 2. Fixed links
…he testing deployment of Dayalbagh experiments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pipeline.
The experiments using this branch will no longer build after this merge.