-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Build failed with errors" message instead of webpack cause #1155
Comments
On what kind of errors does this happen? I tried:
Please provide more information. |
|
Sorry, I forgot one important thing ! The error is caused by ts-loader (i'm running typescript). |
Not an unimportant detail ^^ |
Please provide a repository with a reproduction, I won't build one myself. |
https://github.com/pragmasphere/vue-tree It's fixed in this repository, but you revert those lines |
Thanks. Seems ts-loader is a weird beast. In webpack 1, it even made webpack exit with code 0 on a compile error (TypeStrong/ts-loader#108), so getting errors out of ts-loader seems to not be that easy :-P So I played around a little and found that removing The thing is that this alone makes the output quite verbose on a successful build. and since this template is not laid out for typescript yet, I would hesitate to make the output verbose for everyone just to accomodate those who implement typescript into that template on their own. So my suggetion would be the following:
Does that sound sensible to you? |
I think the comment would be ok for now. In fact I realised later the problem was maybe related to ts-loader, so let's close this one, no problem. thanks :) |
* develop: correct wording for #1155 bump version to 1.2.7 remove eventsource-polyfill (#1169) Remove useless code when lint is not chosen (#1165) Set spawn opt shell as true to avoid ENOENT (#1170) restore gitignore [WIP] Accurate CompleteMsg when not using autoInstall (fix #1157) (#1158) close #1155
* develop: correct wording for vuejs-templates#1155 bump version to 1.2.7 remove eventsource-polyfill (vuejs-templates#1169) Remove useless code when lint is not chosen (vuejs-templates#1165) Set spawn opt shell as true to avoid ENOENT (vuejs-templates#1170) restore gitignore [WIP] Accurate CompleteMsg when not using autoInstall (fix vuejs-templates#1157) (vuejs-templates#1158) close vuejs-templates#1155
When webpack build fails (npm build), it displays "Build failed with errors" without any other explanation.
Problem is that this piece of code hide actual errors.
webpack/template/build/build.js
Lines 22 to 28 in ecd68c4
If is set this to
toString({color: true})
, errors are displayed with other informations.The text was updated successfully, but these errors were encountered: