Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing npm install tips in "To get started" message #1157

Closed
Toilal opened this issue Dec 12, 2017 · 4 comments
Closed

Missing npm install tips in "To get started" message #1157

Toilal opened this issue Dec 12, 2017 · 4 comments
Assignees
@LinusBorg
Labels
bug

Comments

@Toilal
Copy link
Contributor

Toilal commented Dec 12, 2017

When choosing to run npm commands manually, the message doesn't tell user to run npm install

# Project initialization finished!
# ========================

To get started:

  cd vue-test
  npm run lint -- --fix
  npm run dev

npm install is missing in the get started steps.

BTW, last commits are great 👍
@LinusBorg
Copy link
Contributor

Oh, thought I had tested that thoroughly enough. Will take a look, thanks.

BTW, last commits are great

Thanks :)

@LinusBorg LinusBorg added the bug label Dec 12, 2017
@LinusBorg LinusBorg self-assigned this Dec 12, 2017
LinusBorg added a commit that referenced this issue Dec 12, 2017
@LinusBorg
try and fix #1157
51283ca
@LinusBorg
Copy link
Contributor

@Toilal Try this branch:

vue init webpack#fix_complete_msg_1157

@Toilal
Copy link
Contributor Author

Toilal commented Dec 12, 2017

It's OK. for yarn, you can omit run keyword. (yarn lint --fix)

@LinusBorg
Copy link
Contributor

Will change that.

LinusBorg added a commit that referenced this issue Dec 14, 2017
@LinusBorg
Merge branch 'develop'
f93e45b 
* develop:
  correct wording for #1155
  bump version to 1.2.7
  remove eventsource-polyfill (#1169)
  Remove useless code when lint is not chosen (#1165)
  Set spawn opt shell as true to avoid ENOENT (#1170)
  restore gitignore
  [WIP] Accurate CompleteMsg when not using autoInstall (fix #1157) (#1158)
  close #1155
shenron pushed a commit to shenron/webpack that referenced this issue Mar 20, 2018
@LinusBorg
[WIP] Accurate CompleteMsg when not using autoInstall (fix vuejs-temp…
d069cd6 
…lates#1157) (vuejs-templates#1158)

* try and fix vuejs-templates#1157
shenron pushed a commit to shenron/webpack that referenced this issue Mar 20, 2018
@LinusBorg
Merge branch 'develop'
1da1444 
* develop:
  correct wording for vuejs-templates#1155
  bump version to 1.2.7
  remove eventsource-polyfill (vuejs-templates#1169)
  Remove useless code when lint is not chosen (vuejs-templates#1165)
  Set spawn opt shell as true to avoid ENOENT (vuejs-templates#1170)
  restore gitignore
  [WIP] Accurate CompleteMsg when not using autoInstall (fix vuejs-templates#1157) (vuejs-templates#1158)
  close vuejs-templates#1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LinusBorg LinusBorg

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Toilal @LinusBorg