-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useless code when lint is not chosen #1165
Conversation
2c39018
to
b9582e9
Compare
@@ -8,7 +8,7 @@ function resolve (dir) { | |||
return path.join(__dirname, '..', dir) | |||
} | |||
|
|||
const createLintingRule = () => ({ | |||
{{#lint}}const createLintingRule = () => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a call to that function further below in the rules section, that should be wrapped in the same handlebars check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already wrapped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, my mistake. Thanks.
* develop: correct wording for #1155 bump version to 1.2.7 remove eventsource-polyfill (#1169) Remove useless code when lint is not chosen (#1165) Set spawn opt shell as true to avoid ENOENT (#1170) restore gitignore [WIP] Accurate CompleteMsg when not using autoInstall (fix #1157) (#1158) close #1155
* develop: correct wording for vuejs-templates#1155 bump version to 1.2.7 remove eventsource-polyfill (vuejs-templates#1169) Remove useless code when lint is not chosen (vuejs-templates#1165) Set spawn opt shell as true to avoid ENOENT (vuejs-templates#1170) restore gitignore [WIP] Accurate CompleteMsg when not using autoInstall (fix vuejs-templates#1157) (vuejs-templates#1158) close vuejs-templates#1155
No description provided.