Remove useless code when lint is not chosen #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toilal
force-pushed
the
eslint-disabled
branch
from
2c39018
to
b9582e9
Compare
LinusBorg
suggested changes
Dec 14, 2017
| @@ -8,7 +8,7 @@ function resolve (dir) { | |||
| return path.join(__dirname, '..', dir) | |||
| } | |||
|
|
|||
| const createLintingRule = () => ({ | |||
| {{#lint}}const createLintingRule = () => ({ | |||
There was a problem hiding this comment.
There's a call to that function further below in the rules section, that should be wrapped in the same handlebars check.
There was a problem hiding this comment.
It's already wrapped
There was a problem hiding this comment.
Right, my mistake. Thanks.
LinusBorg
approved these changes
Dec 14, 2017
LinusBorg
added a commit
that referenced
this pull request
Dec 14, 2017
* develop: correct wording for #1155 bump version to 1.2.7 remove eventsource-polyfill (#1169) Remove useless code when lint is not chosen (#1165) Set spawn opt shell as true to avoid ENOENT (#1170) restore gitignore [WIP] Accurate CompleteMsg when not using autoInstall (fix #1157) (#1158) close #1155
shenron
pushed a commit
to shenron/webpack
that referenced
this pull request
Mar 20, 2018
shenron
pushed a commit
to shenron/webpack
that referenced
this pull request
Mar 20, 2018
* develop: correct wording for vuejs-templates#1155 bump version to 1.2.7 remove eventsource-polyfill (vuejs-templates#1169) Remove useless code when lint is not chosen (vuejs-templates#1165) Set spawn opt shell as true to avoid ENOENT (vuejs-templates#1170) restore gitignore [WIP] Accurate CompleteMsg when not using autoInstall (fix vuejs-templates#1157) (vuejs-templates#1158) close vuejs-templates#1155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.