-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/* webpackChunkName: "name" */ is working without the exact name. #996
Comments
Hm, that generally happens when comments are stripped, usually but babel. We had a But I removed this from the template back on June 22nd (8563cdb), so that should work, assuming you created your project after this date. Could you verify that your Edit: Oh, I see you submitted a PR that changes something else. Nice, will check it out! |
The |
Thanks for the PR, will merge it as soon as I found time to take it for a quick spin. |
…server. (#1072) * replace `id` with `name` in chunk files, Fix #996 * fix typo * remove env in `.babelrc` when not using unit or e2e * remove `webpack.test.conf.js` when not using unit or e2e * remove extra space in `.babelrc` * enable `compress` in devServer by default * remove `webpack.test.conf.js` when not using unit(karma) or e2e
Hi, I don't see this as a bug. In production this shouldn't matter because the chunk is named properly as you can see in the Chunk names column. Only the file is named numeric. Please also note that using name instead of id generates bigger manifest since the mapping for name to id has to be stored somewhere. See here
In this case I'd like to undo this change. edit: add quote |
I see, it does have some side effects with I think it's better to undo this change. @LinusBorg |
* develop: bump v1.2.4 revert #996 chunk names to minify prodution JS (#1086) fix missing comma Batman! add missing cacheBusting option make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern Improved Jest config (#1074) Fix # 1070 When index.html has a positional variable, the error can be printed correctly (#1071) [enhancement]Remove useless files and performance enhancement in dev server. (#1072)
* vuejs-templates/master: bump v1.2.4 Simplify elementCount custom assertions (vuejs-templates#898) revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086) fix missing comma Batman! add missing cacheBusting option make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern Improved Jest config (vuejs-templates#1074) Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071) [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
…server. (vuejs-templates#1072) * replace `id` with `name` in chunk files, Fix vuejs-templates#996 * fix typo * remove env in `.babelrc` when not using unit or e2e * remove `webpack.test.conf.js` when not using unit or e2e * remove extra space in `.babelrc` * enable `compress` in devServer by default * remove `webpack.test.conf.js` when not using unit(karma) or e2e
…server. (vuejs-templates#1072) * replace `id` with `name` in chunk files, Fix vuejs-templates#996 * fix typo * remove env in `.babelrc` when not using unit or e2e * remove `webpack.test.conf.js` when not using unit or e2e * remove extra space in `.babelrc` * enable `compress` in devServer by default * remove `webpack.test.conf.js` when not using unit(karma) or e2e
* develop: bump v1.2.4 revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086) fix missing comma Batman! add missing cacheBusting option make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern Improved Jest config (vuejs-templates#1074) Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071) [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
My async route:
After I run build:
The bundle name is
0
rather thangroup-foo
.The text was updated successfully, but these errors were encountered: