Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix # 1070 When index.html has a positional variable, the error can b… #1071

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

wolfstark
Copy link
Contributor

@wolfstark wolfstark commented Nov 16, 2017

Now the error can be printed correctly.
image

Fixes this: #1070

@@ -87,7 +87,7 @@ exports.createNotifierCallback = function () {
}
const error = errors[0]

const filename = error.file.split('!').pop()
const filename = error.file && error.file.split('!').pop()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@LinusBorg LinusBorg merged commit 096fe18 into vuejs-templates:develop Nov 16, 2017
LinusBorg added a commit that referenced this pull request Nov 21, 2017
* develop:
  bump v1.2.4
  revert #996 chunk names to minify prodution JS (#1086)
  fix missing comma
  Batman!
  add missing cacheBusting option
  make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern
  Improved Jest config (#1074)
  Fix # 1070 When index.html has a positional variable, the error can be printed correctly (#1071)
  [enhancement]Remove useless files and performance enhancement in dev server. (#1072)
c0defre4k pushed a commit to neonblack-at/webpack that referenced this pull request Nov 30, 2017
* vuejs-templates/master:
  bump v1.2.4
  Simplify elementCount custom assertions (vuejs-templates#898)
  revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086)
  fix missing comma
  Batman!
  add missing cacheBusting option
  make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern
  Improved Jest config (vuejs-templates#1074)
  Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071)
  [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this pull request Dec 25, 2017
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
* develop:
  bump v1.2.4
  revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086)
  fix missing comma
  Batman!
  add missing cacheBusting option
  make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern
  Improved Jest config (vuejs-templates#1074)
  Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071)
  [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants