Fix # 1070 When index.html has a positional variable, the error can b… #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e printed correctly
LinusBorg
approved these changes
Nov 16, 2017
| @@ -87,7 +87,7 @@ exports.createNotifierCallback = function () { | |||
| } | |||
| const error = errors[0] | |||
|
|
|||
| const filename = error.file.split('!').pop() | |||
| const filename = error.file && error.file.split('!').pop() | |||
LinusBorg
added a commit
that referenced
this pull request
Nov 21, 2017
* develop: bump v1.2.4 revert #996 chunk names to minify prodution JS (#1086) fix missing comma Batman! add missing cacheBusting option make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern Improved Jest config (#1074) Fix # 1070 When index.html has a positional variable, the error can be printed correctly (#1071) [enhancement]Remove useless files and performance enhancement in dev server. (#1072)
c0defre4k
pushed a commit
to neonblack-at/webpack
that referenced
this pull request
Nov 30, 2017
* vuejs-templates/master: bump v1.2.4 Simplify elementCount custom assertions (vuejs-templates#898) revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086) fix missing comma Batman! add missing cacheBusting option make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern Improved Jest config (vuejs-templates#1074) Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071) [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
frandiox
pushed a commit
to OnsenUI/vue-cordova-webpack
that referenced
this pull request
Dec 25, 2017
…e printed correctly (vuejs-templates#1071)
shenron
pushed a commit
to shenron/webpack
that referenced
this pull request
Mar 20, 2018
…e printed correctly (vuejs-templates#1071)
shenron
pushed a commit
to shenron/webpack
that referenced
this pull request
Mar 20, 2018
* develop: bump v1.2.4 revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086) fix missing comma Batman! add missing cacheBusting option make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern Improved Jest config (vuejs-templates#1074) Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071) [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the error can be printed correctly.
Fixes this: #1070