Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement]Remove useless files and performance enhancement in dev server. #1072

Merged
merged 8 commits into from
Nov 16, 2017
Merged

[enhancement]Remove useless files and performance enhancement in dev server. #1072

merged 8 commits into from
Nov 16, 2017

Conversation

SidKwok
Copy link
Contributor

@SidKwok SidKwok commented Nov 16, 2017

  1. Fix comments in config/index.js
    // can be overwritten by process.env.HOST -> // can be overwritten by process.env.PORT

  2. remove env in .babelrc when not using unit or e2e

  3. remove webpack.test.conf.js when not using unit or e2e

  4. remove extra space in .babelrc
    before:

"env": {
    "test": {
      "presets": ["env", "stage-2"]    }
  }

after:

"env": {
    "test": {
      "presets": ["env", "stage-2"]
    }
  }
  1. enable compress in devServer by default, it will be useful when you try to access your website in a remote server.

before:
3aa68ba82a2e113d693131789665ab7c

after:
211c9ce5d45785991a023ce010f96a47

LinusBorg
LinusBorg suggested changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

I will aprove this PR once the condition in meta.js is fixed.

meta.js Outdated
@@ -105,6 +105,7 @@ module.exports = {
".eslintrc.js": "lint",
".eslintignore": "lint",
"config/test.env.js": "unit || e2e",
"build/webpack.test.conf.js": "unit || e2e",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that config is only required if e2e || (unit && runner === 'karma') - jest doesn't use webpack.

@SidKwok
Copy link
Contributor Author

SidKwok commented Nov 16, 2017

Done. @LinusBorg

@LinusBorg
Copy link
Contributor

Thanks. I will test this locally tonight and then approve & merge.

@LinusBorg LinusBorg self-assigned this Nov 16, 2017
@LinusBorg LinusBorg merged commit 472c561 into vuejs-templates:develop Nov 16, 2017
LinusBorg added a commit that referenced this pull request Nov 21, 2017
@LinusBorg
Merge branch 'develop'
3c15450 
* develop:
  bump v1.2.4
  revert #996 chunk names to minify prodution JS (#1086)
  fix missing comma
  Batman!
  add missing cacheBusting option
  make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern
  Improved Jest config (#1074)
  Fix # 1070 When index.html has a positional variable, the error can be printed correctly (#1071)
  [enhancement]Remove useless files and performance enhancement in dev server. (#1072)
c0defre4k pushed a commit to neonblack-at/webpack that referenced this pull request Nov 30, 2017
Merge remote-tracking branch 'vuejs-templates/master'
00df15a 
* vuejs-templates/master:
  bump v1.2.4
  Simplify elementCount custom assertions (vuejs-templates#898)
  revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086)
  fix missing comma
  Batman!
  add missing cacheBusting option
  make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern
  Improved Jest config (vuejs-templates#1074)
  Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071)
  [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this pull request Dec 25, 2017
@SidKwok @frandiox
[enhancement]Remove useless files and performance enhancement in dev …
bf68f28 
…server. (vuejs-templates#1072)

* replace `id` with `name` in chunk files, Fix vuejs-templates#996

* fix typo

* remove env in `.babelrc` when not using unit or e2e

* remove `webpack.test.conf.js` when not using unit or e2e

* remove extra space in `.babelrc`

* enable `compress` in devServer by default

* remove `webpack.test.conf.js` when not using unit(karma) or e2e
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
@SidKwok @LinusBorg
[enhancement]Remove useless files and performance enhancement in dev …
9aeb427 
…server. (vuejs-templates#1072)

* replace `id` with `name` in chunk files, Fix vuejs-templates#996

* fix typo

* remove env in `.babelrc` when not using unit or e2e

* remove `webpack.test.conf.js` when not using unit or e2e

* remove extra space in `.babelrc`

* enable `compress` in devServer by default

* remove `webpack.test.conf.js` when not using unit(karma) or e2e
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
@LinusBorg
Merge branch 'develop'
9d1fde6 
* develop:
  bump v1.2.4
  revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086)
  fix missing comma
  Batman!
  add missing cacheBusting option
  make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern
  Improved Jest config (vuejs-templates#1074)
  Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071)
  [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees

@LinusBorg LinusBorg

Labels
PR:Review required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SidKwok @LinusBorg