fix: use new button classes and improve conditions #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaRybkina
force-pushed
the
test-one-more-refactoring-for-buttons
branch
from
cd4e3bb to
50901cd
Compare
AnnaRybkina
commented
Aug 25, 2023
AnnaRybkina
commented
Aug 25, 2023
AnnaRybkina
force-pushed
the
test-one-more-refactoring-for-buttons
branch
from
5d39ade to
cee964f
Compare
AnnaRybkina
force-pushed
the
test-one-more-refactoring-for-buttons
branch
from
90c818e to
1c0cfb6
Compare
AnnaRybkina
changed the title
AnnaRybkina
force-pushed
the
test-one-more-refactoring-for-buttons
branch
from
7f42a87 to
9b4ecc1
Compare
magnuh
reviewed
Aug 30, 2023
magnuh
reviewed
Aug 30, 2023
AnnaRybkina
force-pushed
the
test-one-more-refactoring-for-buttons
branch
3 times, most recently
from
bb209fc to
7c42865
Compare
AnnaRybkina
force-pushed
the
test-one-more-refactoring-for-buttons
branch
from
7c42865 to
5b5cbf2
Compare
|
I'm not a huge fan of the fact that we are adding a lot more code to handle this, but I agree that it's nice to avoid to use important to override "same" classes! But the buttons looks good, and I agree that it will be easier to find issues 💪 |
BalbinaK
reviewed
Aug 31, 2023
AnnaRybkina
force-pushed
the
test-one-more-refactoring-for-buttons
branch
from
50ab671 to
521203d
Compare
BalbinaK
approved these changes
Aug 31, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
## [1.0.1-next.1](v1.0.0...v1.0.1-next.1) (2023-08-31) ### Bug Fixes * use new button classes and improve conditions ([#67](#67)) ([09c8245](09c8245))
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
## [1.0.1](v1.0.0...v1.0.1) (2023-09-25) ### Bug Fixes * add aria-current propp to the anchor element for e.g. pagination component ([#81](#81)) ([5b532b6](5b532b6)) * add check for children in tabs ([#83](#83)) ([b6f4ccd](b6f4ccd)) * Add fullWidth button prop ([#89](#89)) ([4cdbe5d](4cdbe5d)) * **button:** set secondary variant styles by default ([#86](#86)) ([cb0c60f](cb0c60f)) * pass onClick to anchor in button component ([#87](#87)) ([24a4247](24a4247)) * use new button classes and improve conditions ([#67](#67)) ([09c8245](09c8245))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more try for button refactoring
In this case we add classes specifically for a button with all variants and such.
The code grew a lot. But I hope it is easier to follow and will improve our work when we will debug problems with buttons.
TODO:
- [ ] Shortcuts (what it is in comments) will be fixed in the css repoPR for the classes and shortcuts: warp-ds/css#44
First attempt here but it was too unsafe but it is for sure less code but what is more important here 🤷