Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass onClick to anchor in button component #87

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

AnnaRybkina
Copy link
Contributor

Background: https://nmp-jira.atlassian.net/browse/WARP-281

Can be tested by clicking on the following 👇
image

Copy link
Contributor

@Skadefryd Skadefryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :) Thank you.

@AnnaRybkina AnnaRybkina merged commit 24a4247 into next Sep 19, 2023
@AnnaRybkina AnnaRybkina deleted the onclick-for-anchor branch September 19, 2023 07:55
github-actions bot pushed a commit that referenced this pull request Sep 19, 2023
## [1.0.1-next.5](v1.0.1-next.4...v1.0.1-next.5) (2023-09-19)

### Bug Fixes

* pass onClick to anchor in button component ([#87](#87)) ([24a4247](24a4247))
github-actions bot pushed a commit that referenced this pull request Sep 25, 2023
## [1.0.1](v1.0.0...v1.0.1) (2023-09-25)

### Bug Fixes

* add aria-current propp to the anchor element for e.g. pagination component ([#81](#81)) ([5b532b6](5b532b6))
* add check for children in tabs ([#83](#83)) ([b6f4ccd](b6f4ccd))
* Add fullWidth button prop ([#89](#89)) ([4cdbe5d](4cdbe5d))
* **button:** set secondary variant styles by default ([#86](#86)) ([cb0c60f](cb0c60f))
* pass onClick to anchor in button component ([#87](#87)) ([24a4247](24a4247))
* use new button classes and improve conditions ([#67](#67)) ([09c8245](09c8245))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants