fix(button): set secondary variant styles by default #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
AnnaRybkina
approved these changes
Sep 18, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
## [1.0.1-next.4](v1.0.1-next.3...v1.0.1-next.4) (2023-09-18) ### Bug Fixes * **button:** set secondary variant styles by default ([#86](#86)) ([cb0c60f](cb0c60f))
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
## [1.0.1](v1.0.0...v1.0.1) (2023-09-25) ### Bug Fixes * add aria-current propp to the anchor element for e.g. pagination component ([#81](#81)) ([5b532b6](5b532b6)) * add check for children in tabs ([#83](#83)) ([b6f4ccd](b6f4ccd)) * Add fullWidth button prop ([#89](#89)) ([4cdbe5d](4cdbe5d)) * **button:** set secondary variant styles by default ([#86](#86)) ([cb0c60f](cb0c60f)) * pass onClick to anchor in button component ([#87](#87)) ([24a4247](24a4247)) * use new button classes and improve conditions ([#67](#67)) ([09c8245](09c8245))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues where buttons receiving only modifier props like
small,loading,quiet(without any variant prop) weren't applying any classes. The default button variant in such case should be "secondary".Also renamed
buttonTypestobuttonVariantsto align with Warp Elements API and to avoid confusion with another prop that is calledtype.Before:
After:
