html, xhr: Add tests for 'formdata' event #14637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
caitp,
domenic,
foolip,
ibelem,
jdm,
jgraham,
jungkees,
lukebjerring,
Manishearth,
mathiasbynens,
wisniewskit,
zcorpan and
zqzhang
This was referenced Dec 21, 2018
|
Taskcluster failures don't look related to this PR. |
annevk
reviewed
Jan 4, 2019
| const waitForLoad = new Promise(resolve => { addEventListener('load', resolve); }) | ||
|
|
||
| idl_test( | ||
| ['html'], | ||
| ['SVG', 'cssom', 'touch-events', 'uievents', 'dom'], | ||
| ['SVG', 'cssom', 'touch-events', 'uievents', 'dom', 'xhr'], |
There was a problem hiding this comment.
Isn't the interface added to HTML?
There was a problem hiding this comment.
Yes. However 'xhr' is necessary for FormData interface dependency.
|
(I suspect you might be able to address the Taskcluster failure by rebasing on master. Apparently something changed over the holidays. Happy new year btw!) |
annevk
approved these changes
Jan 7, 2019
annevk
force-pushed
the
tkent-formdataevent
branch
from
ea3a519
to
08450ab
Compare
|
I ran to see if I can get Taskcluster to pass. |
|
Taskcluster failures are for known flaky tests. |
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Jan 8, 2019
- Add formdata event and FormDataEvent interface - Fire it in "constructing the entry list" algorithm - Introduce "constructing entry list" flag of a form element to avoid recursive submission. Tests: web-platform-tests/wpt#14637. Change to XMLHttpRequest: whatwg/xhr#231. This fixes a part of WICG/webcomponents#187.
annevk
pushed a commit
to whatwg/xhr
that referenced
this pull request
Jan 8, 2019
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 15, 2019
The test was upstreamed to WPT by web-platform-tests/wpt#14637 Bug: 825684 Change-Id: I66ef778831adebfccf67fc9e68f94e81206f9380 Reviewed-on: https://chromium-review.googlesource.com/c/1405165 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#622789}
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
- Add formdata event and FormDataEvent interface - Fire it in "constructing the entry list" algorithm - Introduce "constructing entry list" flag of a form element to avoid recursive submission. Tests: web-platform-tests/wpt#14637. Change to XMLHttpRequest: whatwg/xhr#231. This fixes a part of WICG/webcomponents#187.
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
- Add formdata event and FormDataEvent interface - Fire it in "constructing the entry list" algorithm - Introduce "constructing entry list" flag of a form element to avoid recursive submission. Tests: web-platform-tests/wpt#14637. Change to XMLHttpRequest: whatwg/xhr#231. This fixes a part of WICG/webcomponents#187.
| didCallHandler = true; | ||
| }); | ||
| new FormData(form); | ||
| assert_true(didCallHandler); |
There was a problem hiding this comment.
Same as above, I guess... I'm reading this section:
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set:formdataevent
And the event fires as normal, and bubbles = false per the EventInit dict.
tkent-google
added a commit
to tkent-google/html
that referenced
this pull request
Mar 8, 2019
This is a follow-up of whatwg#4239, and fixes an issue pointed out in web-platform-tests/wpt#14637
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Mar 8, 2019
This is a follow-up of #4239, and fixes an issue pointed out in web-platform-tests/wpt#14637.
Bishwarupjee
pushed a commit
to Bishwarupjee/xhr
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a part of WICG/webcomponents#187
HTML specification PR: whatwg/html#4239
XHR specification PR: whatwg/xhr#231