Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html, xhr: Add tests for 'formdata' event #14637

Merged
merged 3 commits into from
Jan 8, 2019
Merged

Conversation

tkent-google
Copy link
Contributor

This fixes a part of WICG/webcomponents#187

HTML specification PR: whatwg/html#4239
XHR specification PR: whatwg/xhr#231

@tkent-google
Copy link
Contributor Author

Taskcluster failures don't look related to this PR.

Copy link
Contributor

@lukebjerring lukebjerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idlharness test changes LGTM

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but per the HTML review we'll need to test the event constructor as well.

const waitForLoad = new Promise(resolve => { addEventListener('load', resolve); })

idl_test(
['html'],
['SVG', 'cssom', 'touch-events', 'uievents', 'dom'],
['SVG', 'cssom', 'touch-events', 'uievents', 'dom', 'xhr'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the interface added to HTML?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. However 'xhr' is necessary for FormData interface dependency.

@annevk
Copy link
Member

annevk commented Jan 4, 2019

(I suspect you might be able to address the Taskcluster failure by rebasing on master. Apparently something changed over the holidays. Happy new year btw!)

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll land this when the specification PR is ready.

@annevk
Copy link
Member

annevk commented Jan 8, 2019

I ran

git rebase master
git force --push

to see if I can get Taskcluster to pass.

@jgraham
Copy link
Contributor

jgraham commented Jan 8, 2019

Taskcluster failures are for known flaky tests.

@jgraham jgraham merged commit c547389 into master Jan 8, 2019
@annevk annevk deleted the tkent-formdataevent branch January 8, 2019 11:08
annevk pushed a commit to whatwg/html that referenced this pull request Jan 8, 2019
- Add formdata event and FormDataEvent interface
- Fire it in "constructing the entry list" algorithm
- Introduce "constructing entry list" flag of a form element to avoid recursive submission.

Tests: web-platform-tests/wpt#14637.

Change to XMLHttpRequest: whatwg/xhr#231.

This fixes a part of WICG/webcomponents#187.
annevk pushed a commit to whatwg/xhr that referenced this pull request Jan 8, 2019
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 15, 2019
The test was upstreamed to WPT by web-platform-tests/wpt#14637

Bug: 825684
Change-Id: I66ef778831adebfccf67fc9e68f94e81206f9380
Reviewed-on: https://chromium-review.googlesource.com/c/1405165
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622789}
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
- Add formdata event and FormDataEvent interface
- Fire it in "constructing the entry list" algorithm
- Introduce "constructing entry list" flag of a form element to avoid recursive submission.

Tests: web-platform-tests/wpt#14637.

Change to XMLHttpRequest: whatwg/xhr#231.

This fixes a part of WICG/webcomponents#187.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
- Add formdata event and FormDataEvent interface
- Fire it in "constructing the entry list" algorithm
- Introduce "constructing entry list" flag of a form element to avoid recursive submission.

Tests: web-platform-tests/wpt#14637.

Change to XMLHttpRequest: whatwg/xhr#231.

This fixes a part of WICG/webcomponents#187.
didCallHandler = true;
});
new FormData(form);
assert_true(didCallHandler);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, I guess... I'm reading this section:
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set:formdataevent

And the event fires as normal, and bubbles = false per the EventInit dict.

tkent-google added a commit to tkent-google/html that referenced this pull request Mar 8, 2019
This is a follow-up of whatwg#4239, and
fixes an issue pointed out in web-platform-tests/wpt#14637
domenic pushed a commit to whatwg/html that referenced this pull request Mar 8, 2019
This is a follow-up of #4239, and
fixes an issue pointed out in web-platform-tests/wpt#14637.
Bishwarupjee pushed a commit to Bishwarupjee/xhr that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants