Event-based form participation #4239

tkent-google · 2018-12-14T07:51:32Z

Add formdata event and FormDataEvent interface
Fire it in "constructing the entry list" algorithm
Introduce "constructing entry list" flag of a form element to avoid
recursive submission.

This fixes a part of WICG/webcomponents#187

XHR specification PR: whatwg/xhr#231
Test: web-platform-tests/wpt#14637

/form-control-infrastructure.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/webappapis.html ( diff )

- Add formdata event and FormDataEvent interface - Fire it in "constructing the entry list" algorithm - Introduce "constructing entry list" flag of a form element to avoid recursive submission. This fixes a part of WICG/webcomponents#187

…ated by "new FormData(form)" Specification: whatwg/html#4239 Bug: 825684 Bug: WICG/webcomponents#187 Change-Id: I4213d9a1b3b8081f421ab89529421d28cfc322f0 Reviewed-on: https://chromium-review.googlesource.com/c/1379599 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#617067}

domenic

This looks great! It's nice that the spec ended up being so simple.

I had some review nits, but since it took me 6 days to review anyway, I just pushed them as a separate commit, instead of doing a round trip.

I think you have some web platform tests for this ready to upstream, right? Can you link to them?

From what I recall everyone was excited about this at the web components F2F. Do folks want to give it a look to ensure the final spec meets their needs? @rniwa / @hober; @travisleithead; @annevk / @smaug---- ?

Specification PR: whatwg/html#4239

tkent-google · 2018-12-21T09:45:50Z

Here is the test PR: web-platform-tests/wpt#14637

annevk

Thanks for writing this up, looks solid overall, but we do need to add an event constructor here I think.

source

tkent-google · 2019-01-07T09:11:10Z

Will update the WPT PR for FormDataEvent constructor.

source

Specification PR: whatwg/html#4239

annevk

Great, thanks! @domenic want to look again? I'd prefer waiting with landing this until we can land wpt. I pinged the wpt IRC channel to see if anyone has insights into the failure.

As per https://github.com/whatwg/meta/blob/master/MAINTAINERS.md#handling-pull-requests we'll also need implementation bugs for this to ensure everyone knows this is going on.

Specification PR: whatwg/html#4239

annevk · 2019-01-08T11:09:23Z

This and whatwg/xhr#231 can be landed modulo implementation bugs. wpt is sorted.

tkent-google · 2019-01-08T11:26:59Z

WebKit: https://bugs.webkit.org/show_bug.cgi?id=193231
Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1518442
Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=825684

Tests: web-platform-tests/wpt#14637. Change to HTML: whatwg/html#4239.

annevk · 2019-01-10T16:25:21Z

I now wonder if we should have done something here like make a copy of the data or some such, to make it clear at which point mutations to FormData no longer matter. I think that's what implementations do, so we probably need to add that?

tkent-google · 2019-01-11T02:18:18Z

I now wonder if we should have done something here like make a copy of the data or some such, to make it clear at which point mutations to FormData no longer matter. I think that's what implementations do, so we probably need to add that?

Yeah, with the current specification, a formData attribute of a FormDataEvent and the resultant instance of new FormData(form) look to share a single entry list. We should copy the list after the event. I'll make a PR for it.

…t, a=testonly Automatic update from web-platform-tests html, xhr: Add tests for 'formdata' event (#14637) Specification PR: whatwg/html#4239 -- wpt-commits: c547389199647f1736be244a7ca5a874da692430 wpt-pr: 14637

This is a follow-up of whatwg#4239, and fixes an issue pointed out in web-platform-tests/wpt#14637

This is a follow-up of #4239, and fixes an issue pointed out in web-platform-tests/wpt#14637.

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 --HG-- extra : moz-landing-system : lando

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 --HG-- extra : moz-landing-system : lando

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 --HG-- extra : moz-landing-system : lando

…t, a=testonly Automatic update from web-platform-tests html, xhr: Add tests for 'formdata' event (#14637) Specification PR: whatwg/html#4239 -- wpt-commits: c547389199647f1736be244a7ca5a874da692430 wpt-pr: 14637 UltraBlame original commit: c71f7d3fa10b69185c90a1537bb49989a0fd4604

…t, a=testonly Automatic update from web-platform-tests html, xhr: Add tests for 'formdata' event (#14637) Specification PR: whatwg/html#4239 -- wpt-commits: c547389199647f1736be244a7ca5a874da692430 wpt-pr: 14637 UltraBlame original commit: c0fe813241a5041aec5fd25054a003016720745c

…t, a=testonly Automatic update from web-platform-tests html, xhr: Add tests for 'formdata' event (#14637) Specification PR: whatwg/html#4239 -- wpt-commits: c547389199647f1736be244a7ca5a874da692430 wpt-pr: 14637 UltraBlame original commit: c71f7d3fa10b69185c90a1537bb49989a0fd4604

…t, a=testonly Automatic update from web-platform-tests html, xhr: Add tests for 'formdata' event (#14637) Specification PR: whatwg/html#4239 -- wpt-commits: c547389199647f1736be244a7ca5a874da692430 wpt-pr: 14637 UltraBlame original commit: c0fe813241a5041aec5fd25054a003016720745c

…t, a=testonly Automatic update from web-platform-tests html, xhr: Add tests for 'formdata' event (#14637) Specification PR: whatwg/html#4239 -- wpt-commits: c547389199647f1736be244a7ca5a874da692430 wpt-pr: 14637 UltraBlame original commit: c71f7d3fa10b69185c90a1537bb49989a0fd4604

…t, a=testonly Automatic update from web-platform-tests html, xhr: Add tests for 'formdata' event (#14637) Specification PR: whatwg/html#4239 -- wpt-commits: c547389199647f1736be244a7ca5a874da692430 wpt-pr: 14637 UltraBlame original commit: c0fe813241a5041aec5fd25054a003016720745c

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 UltraBlame original commit: c8fbe42eba386afe9d98da72ebfbcb15b0995ed1

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 UltraBlame original commit: 1ac7b20bb1d8c5528211fdba0246f7659bff3a7c

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 UltraBlame original commit: 220138300dd887fb4d05e55a45b9bf9ac78e3584

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 UltraBlame original commit: c8fbe42eba386afe9d98da72ebfbcb15b0995ed1

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 UltraBlame original commit: 1ac7b20bb1d8c5528211fdba0246f7659bff3a7c

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 UltraBlame original commit: 220138300dd887fb4d05e55a45b9bf9ac78e3584

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 UltraBlame original commit: c8fbe42eba386afe9d98da72ebfbcb15b0995ed1

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 UltraBlame original commit: 1ac7b20bb1d8c5528211fdba0246f7659bff3a7c

…ug,edgar For Event-based form participation specification PR: whatwg/html#4239 Differential Revision: https://phabricator.services.mozilla.com/D43986 UltraBlame original commit: 220138300dd887fb4d05e55a45b9bf9ac78e3584

Tests: web-platform-tests/wpt#14637. Change to HTML: whatwg/html#4239.

Event-based form participation

9586123

- Add formdata event and FormDataEvent interface - Fire it in "constructing the entry list" algorithm - Introduce "constructing entry list" flag of a form element to avoid recursive submission. This fixes a part of WICG/webcomponents#187

Copyediting (all editorial)

8536a4e

domenic approved these changes Dec 19, 2018

View reviewed changes

domenic added addition/proposal New features or enhancements topic: forms needs tests Moving the issue forward requires someone to write tests labels Dec 19, 2018

tkent-google added a commit to web-platform-tests/wpt that referenced this pull request Dec 21, 2018

html, xhr: Add tests for 'formdata' event

e8aba3a

Specification PR: whatwg/html#4239

This was referenced Dec 21, 2018

FormData constructor should throw if "constructing the entry list" re… whatwg/xhr#231

Merged

html, xhr: Add tests for 'formdata' event web-platform-tests/wpt#14637

Merged

annevk reviewed Jan 4, 2019

View reviewed changes

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

Add FormDataEvent constructor, etc.

0cd36b6

annevk reviewed Jan 7, 2019

View reviewed changes

source Show resolved Hide resolved

var -> span, optional FormDataEventInit

ee10279

annevk pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 8, 2019

html, xhr: Add tests for 'formdata' event

5938dd6

Specification PR: whatwg/html#4239

annevk approved these changes Jan 8, 2019

View reviewed changes

jgraham pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 8, 2019

html, xhr: Add tests for 'formdata' event (#14637)

c547389

Specification PR: whatwg/html#4239

annevk merged commit 1375c0c into whatwg:master Jan 8, 2019

annevk pushed a commit to whatwg/xhr that referenced this pull request Jan 8, 2019

Throw for new FormData() when "constructing the entry list" returns null

43d3ba6

Tests: web-platform-tests/wpt#14637. Change to HTML: whatwg/html#4239.

jdm mentioned this pull request Jan 8, 2019

Implement formdata event servo/servo#22654

Closed

tkent-google mentioned this pull request Feb 7, 2019

Form Participation API w3ctag/design-reviews#305

Closed

5 tasks

tkent-google mentioned this pull request Feb 26, 2019

Need callback for form submit data WICG/webcomponents#187

Closed

tkent-google added a commit to tkent-google/html that referenced this pull request Mar 8, 2019

'formdata' event should bubble.

55f3da1

This is a follow-up of whatwg#4239, and fixes an issue pointed out in web-platform-tests/wpt#14637

tkent-google mentioned this pull request Mar 8, 2019

'formdata' event should bubble. #4422

Merged

domenic pushed a commit that referenced this pull request Mar 8, 2019

Make the formdata event bubble

e8e2d90

This is a follow-up of #4239, and fixes an issue pointed out in web-platform-tests/wpt#14637.

muan mentioned this pull request Apr 26, 2019

[Experiment] Use FormDataEvent in place of input value syncing github/image-crop-element#13

Closed

TimvdLippe mentioned this pull request Nov 9, 2019

Make eventInitDict argument of FormDataEvent constructor required #5073

Merged

1 task

Bishwarupjee pushed a commit to Bishwarupjee/xhr that referenced this pull request Jan 31, 2024

Throw for new FormData() when "constructing the entry list" returns null

7f602dc

Tests: web-platform-tests/wpt#14637. Change to HTML: whatwg/html#4239.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Event-based form participation #4239

Event-based form participation #4239

tkent-google commented Dec 14, 2018 •

edited by pr-preview bot

Loading

domenic left a comment

tkent-google commented Dec 21, 2018

annevk left a comment

tkent-google commented Jan 7, 2019

annevk left a comment

annevk commented Jan 8, 2019

tkent-google commented Jan 8, 2019

annevk commented Jan 10, 2019

tkent-google commented Jan 11, 2019

Event-based form participation #4239

Event-based form participation #4239

Conversation

tkent-google commented Dec 14, 2018 • edited by pr-preview bot Loading

domenic left a comment

Choose a reason for hiding this comment

tkent-google commented Dec 21, 2018

annevk left a comment

Choose a reason for hiding this comment

tkent-google commented Jan 7, 2019

annevk left a comment

Choose a reason for hiding this comment

annevk commented Jan 8, 2019

tkent-google commented Jan 8, 2019

annevk commented Jan 10, 2019

tkent-google commented Jan 11, 2019

tkent-google commented Dec 14, 2018 •

edited by pr-preview bot

Loading