Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormData constructor should throw if "constructing the entry list" re… #231

Merged
merged 3 commits into from
Jan 8, 2019
Merged

FormData constructor should throw if "constructing the entry list" re… #231

merged 3 commits into from
Jan 8, 2019

Conversation

tkent-google
Copy link
Contributor

@tkent-google tkent-google commented Dec 21, 2018

…turns null.

This fixes a part of WICG/webcomponents#187

HTML specification PR: whatwg/html#4239
Test: web-platform-tests/wpt#14637


Preview | Diff

@annevk
Copy link
Member

annevk commented Jan 2, 2019

This needs some minor formatting changes, but I'm willing to make those before landing. We had sufficient implementation interest for this as well, right?

cc @smaug----

annevk pushed a commit to whatwg/html that referenced this pull request Jan 8, 2019
- Add formdata event and FormDataEvent interface
- Fire it in "constructing the entry list" algorithm
- Introduce "constructing entry list" flag of a form element to avoid recursive submission.

Tests: web-platform-tests/wpt#14637.

Change to XMLHttpRequest: whatwg/xhr#231.

This fixes a part of WICG/webcomponents#187.
@annevk annevk merged commit 43d3ba6 into whatwg:master Jan 8, 2019
@smaug----
Copy link

@bakulf has dealt with FormData.

@bakulf
Copy link

bakulf commented Jan 11, 2019

Yes, I filed bug 1519329.

mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
- Add formdata event and FormDataEvent interface
- Fire it in "constructing the entry list" algorithm
- Introduce "constructing entry list" flag of a form element to avoid recursive submission.

Tests: web-platform-tests/wpt#14637.

Change to XMLHttpRequest: whatwg/xhr#231.

This fixes a part of WICG/webcomponents#187.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
- Add formdata event and FormDataEvent interface
- Fire it in "constructing the entry list" algorithm
- Introduce "constructing entry list" flag of a form element to avoid recursive submission.

Tests: web-platform-tests/wpt#14637.

Change to XMLHttpRequest: whatwg/xhr#231.

This fixes a part of WICG/webcomponents#187.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants