-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When non-English IME is active, keyboard shortcuts are also interpreted by IME #615
Comments
Another related issue found: Alt key as modifier does not work with |
Function keys (F1, F2, ..., F12) do not work when When
|
Some of what you've described sounds similar to #1409 for which I pushed a fix just now, so hopefully things are now slightly better. There are still a number of things to work out with the IME on macOS; it's slow going because the IME APIs aren't really intended to be used outside of standard macOS text input, and that is at-odds with the text input functionality that terminal users desire! |
Certain keys are "handled" by the IME through it generating a "noop" command. That's not super useful for us, so this commit detects the noop case and then treats it as though the IME didn't handle the input event. While implementing the above fix, I realized that the same technique could be used more generally to return processing to our main input handling for the various selectors that we do recognize: we were essentially inferring the original key combinations based on the selector which is not scalable and potentially lossy. We can't capture CTRL-ESC this same way, as that key combination is magical and is routed to the callback without generating any key events. refs: #615 refs: #975 refs: #1410
I commented out temporary workaround configs, and now the nightly version works as expected, including on-the-spot text composition and functions keys without modifiers! (with just |
I'm very interested to hear your opinion on whether we can set |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Describe the bug
Regardless of
use_ime
configuration, when the system IME switches to a non-English keyboard layout (e.g., Korean Sebeolsik), all keyboard shortcuts becomes unusable because IME intercepts them.Maybe related with #318, though IME is highly platform-specific one.
Environment (please complete the following information):
To Reproduce
Switch the system IME to a non-English layout and try to use keyboard shortcuts that have different key mappings in that layout.
For example, Cmd+1 to switch to the first tab should work regardless of the IME state, but in the Korean Sebulsik (3-beolsik) layout, "1" becomes "ᇂ" and the shortcut does not work.
Configuration
Expected behavior
Normally, keyboard shortcuts should bypass the IME and interpreted as-is.
The text was updated successfully, but these errors were encountered: