fix use_ime=true swallows keys with LEADER modifier in macOS #1410

tizee · 2021-12-17T09:26:59Z

When the IME is enabled, pressing `CTRL-A P` would generate `Composed("P")` for the second key press, which we couldn't then match in the keymapping layer. This commit checks for that and normalizes it to `Char('P')` instead. refs: #1409 refs: #1410

wez

Thanks for diving in and submitting this PR!
I ended up fixing this in a slightly different place: e3afdd7

I don't think this PR is needed any more, except that there is another hunk that looks like it is tackling a different problem: I'd love to understand more about that!

wez · 2021-12-31T04:40:05Z

window/src/os/macos/window.rs

@@ -1791,7 +1791,8 @@ impl WindowView {
                "\x08"
            } else if virtual_key == super::keycodes::kVK_Tab {
                "\t"
-            } else if !use_ime && virtual_key == super::keycodes::kVK_Delete {
+            } else if virtual_key == super::keycodes::kVK_Delete {
+                // When using IME in macOS, delete applied in candidate window.


This appears to be a different issue from the main thing you mentioned in #1409; could you give some more details on how to reproduce the issue that you're fixing with this?

ah, I see now; I'll fix this in a commit I have in progress!

Certain keys are "handled" by the IME through it generating a "noop" command. That's not super useful for us, so this commit detects the noop case and then treats it as though the IME didn't handle the input event. While implementing the above fix, I realized that the same technique could be used more generally to return processing to our main input handling for the various selectors that we do recognize: we were essentially inferring the original key combinations based on the selector which is not scalable and potentially lossy. We can't capture CTRL-ESC this same way, as that key combination is magical and is routed to the callback without generating any key events. refs: #615 refs: #975 refs: #1410

fix use_ime=true swallows keys with leader modifier

fe4098c

wez reviewed Dec 31, 2021

View reviewed changes

wez closed this Dec 31, 2021

tizee deleted the fix/macos_ime branch December 31, 2021 06:13

tizee restored the fix/macos_ime branch December 31, 2021 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix use_ime=true swallows keys with LEADER modifier in macOS #1410

fix use_ime=true swallows keys with LEADER modifier in macOS #1410

tizee commented Dec 17, 2021

wez left a comment

wez Dec 31, 2021

wez Dec 31, 2021

fix use_ime=true swallows keys with LEADER modifier in macOS #1410

fix use_ime=true swallows keys with LEADER modifier in macOS #1410

Conversation

tizee commented Dec 17, 2021

wez left a comment

Choose a reason for hiding this comment

wez Dec 31, 2021

Choose a reason for hiding this comment

wez Dec 31, 2021

Choose a reason for hiding this comment