Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on macos, when use_ime = true, press keys F8 or F9 doesn't work #975

Closed
Aaron-Vungle opened this issue Jul 24, 2021 · 2 comments
Closed
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. macOS Issue applies to Apple macOS

Comments

@Aaron-Vungle
Copy link

Describe the bug

On macOS

with version

/Applications/WezTerm.app/Contents/MacOS/wezterm -V
wezterm 20210502-154244-3f7122cb

with config

use_ime = true,

then press keys F8, F9 has no effects


in my $HOME/.tmux.conf, I have set F8 as the prefix key

set -g prefix F8

but that F8 stops working on wezterm when use_ime = true,. I had to turn use_ime off.

@Aaron-Vungle Aaron-Vungle added the bug Something isn't working label Jul 24, 2021
@wez wez added the macOS Issue applies to Apple macOS label Sep 3, 2021
wez added a commit that referenced this issue Dec 31, 2021
Certain keys are "handled" by the IME through it generating a "noop"
command.

That's not super useful for us, so this commit detects the noop case
and then treats it as though the IME didn't handle the input event.

While implementing the above fix, I realized that the same technique
could be used more generally to return processing to our main input
handling for the various selectors that we do recognize: we were
essentially inferring the original key combinations based on the
selector which is not scalable and potentially lossy.

We can't capture CTRL-ESC this same way, as that key combination
is magical and is routed to the callback without generating any
key events.

refs: #615
refs: #975
refs: #1410
@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Jan 1, 2022
@wez wez closed this as completed Jan 2, 2022
@Aaron-Vungle
Copy link
Author

awesome, thanks 👍

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. macOS Issue applies to Apple macOS
Projects
None yet
Development

No branches or pull requests

2 participants