Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.0 - Release #20

Merged
merged 26 commits into from
Jan 17, 2023
Merged

0.2.0 - Release #20

merged 26 commits into from
Jan 17, 2023

Conversation

aaroncox
Copy link
Member

No description provided.

Resolves #13.

After discussions with other developers, it became clear that the `afterSign` and `beforeBroadcast` hooks currently serve the same function. To simplify the approach developers can take for plugin development, the `beforeBroadcast` hook was removed, and if required, can be added back at a later date.
Resolves #15.

This gives developers a default set of options when creating ESR requests.
Motivation was that I imagine we'll want the `.account` getter to return an Account Kit instance.
Cannot use the at method in older nodejs versions
@aaroncox aaroncox changed the title 0.2.0 0.2.0 - Release Jan 17, 2023
This is to preserve all data and override the zlib/abiProvider values.
Resolves #18.

This new update method ensures the metadata from the original request will persist through modification by a `beforeSign` plugin.

The original metadata will take precedent over metadata from the new request, ensuring no plugin upstream can overwrite it. A warning will be displayed when this happens to let the developer know.
@aaroncox aaroncox merged commit 26f4dea into dev Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant