This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Set inherit setting to true when is inserted in the archive product template
#8251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +18 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
albarin
changed the title
inherit setting to true when is inserted in the archive product template
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
!
nielslange
added a commit
that referenced
this pull request
Feb 1, 2023
* Empty commit for release pull request * Update readme.txt * Bump “minimum_supported_wp_version” in phpcs.xml * Add testing notes * Update 950.md * Update 950.md * Update 950.md * Update 950.md * Update 950.md * Update 950.md * Update #8202 testing instructions. * Revert "Set inherit default to true only when is inserted in the archive product template (#8251)" (#8352) This reverts commit 39b0f91. * Update release ZIP file * Bumping version strings to new version. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Niels Lange <info@nielslange.de> Co-authored-by: Daniel Dudzic <daniel.dudzic@automattic.com> Co-authored-by: Alba Rincón <albarin@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to enable the
Inherit query from templatesetting by default when adding theProductsblock to thearchive-producttemplate.Fixes #8216
Testing
Automated Tests
User Facing Testing
Product Catalogtemplate on theSite Editor(wp-admin/site-editor.php?postType=wp_template&postId=woocommerce%2Fwoocommerce%2F%2Farchive-product).Products (Beta)block.Inherit query from templateis enabled by default.WooCommerce Visibility
Changelog
Enhancement: Enable the
Inherit query from templatesetting by default for the Products block in thearchive-producttemplate.