likhith/refactor:removed cognitive complexity #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng' into likhith/fix-congnitive-complexity
likhith-deriv
changed the title
yauheni-deriv
merged commit 2bef361
into
yauheni-deriv:coj/evgeniy/webrel-1619/verification_statuses_refactoring
1 check failed
likhith-deriv
pushed a commit
that referenced
this pull request
Dec 26, 2023
* Akmal / content updates for EU clients (#38) * feat: convert vanilla options component * Revert "Akmal / content updates for EU clients (#38)" * fix: import from shared * likhith / feat: ✨ incorporate vanilla financials * fix: content changes for EU * feat: add unit tests for vanilla options * fix: reuse types * fix: add empty line * fix: remove commented line * chore: refactor test cases * chore: fix datatypes according to latest changes * fix: datatypes warnings * chore: fix formatting * fix: return missing props * feat: update infobox longcode description * feat: remove all payout formatting for vanillas * fix: circle ci warning * fix: execute sell even if bid price is zero * fix: show appropriate error message when trade falls on weekend * chore: make use of useTraderStore hook * feat: trigger vercel * feat: trigger vercel * chore: remove unused logic * feat: content updates for vanilla financial markets * fix: type * fix: circle ci errors after merge * fix: other circle ci issues * feat: improve solution * feat: refactor test cases * feat: small improvements * feat: trigger circle ci * feat: trigger circle ci * fix: code formatting * fix: code formatting * fix: merge conflict * fix: review comments * fix: mobile bug * chore: format code * chore: code suggestions * chore: code suggestions * fix: remove unused variable * fix: data type * fix: resolve issues after merge * fix: circle ci issue * feat: trigger circle ci * feat: modify test cases * chore: remove unused function * feat: refactor vanilla fx logic for contract glossary and description * fix: apply circle ci suggestions * fix: add a key * fix: remove unused variables * feat: add a type * fix: apply review suggestions * fix: new label for trade categories * fix: typescript types * fix: issues after resolving conflicts * fix: test case * feat: refractor the code * fix: circle ci warning * feat: add observer * fix: issues after merge * chore: fix import * fix: refactor logic after conflicts * chore: resolve conflicts
likhith-deriv
pushed a commit
that referenced
this pull request
Dec 26, 2023
* feat: add key files from prev tech tebt branch * feat: add digits file from prev branch * feat: add contract types file from prev branch * feat: add trade params mobile from prev branch * fix: remove duplicates * Maryia/dtra-401/TS migration: multiplier components (#34) * chore: migrate cancel-deal to ts * chore: migrate expiration & expiration modal * chore: migrated multiplier * chore: migrate stop-loss * chore: migrate take-profit * chore: migrate widgets * build: trigger build with empty commit * Kate / DTRA-398 / TS migration: Widget components in Trader package (#33) * refactor: ts of contract replay widget * refactor: ts of mobile widgets * refactor: ts of chart widgets * refactor: ts of top widgets * refactor: ts of top widgets * refactor: types for widgets * refactor: apply suggestions * refactor: add position prop * fix: extention of the imported file * chore: replace some localizes (#36) * Kate / DTRA-400 / [Refactoring]: delete duplicated unused files from Markers folder in Trader package and migrate to TS marker.jsx (#37) * refactor: marker folder * fix: change file extension in test * Kate / DTRA-404 / [Refactoring]: Divide trade-categories.tsx file and cover changes with tests (#35) * refactor: add rise fall description * refactor: separate stay end high contract description * refactor: separate description of digits contracts * refactor: separate asian reset runhighlow touch contracts * refactor: separate callputspread lb tickhighlow and vanilla contracts * refactor: separate multipliers contract * refactor: add unit tests for contract descriptions * refactor: add more tests * refactor: add tests for touch ans vanilla contracts * refactor: tests for trade categories * refactor: contract description structure * refactor: apply suggestions * refactor: add missing test case * Maryia/DTRA-403/feat: migrate Routes files in Trader package to TS (#38) * feat: migrate routes files to ts * fix: routes extension * refactor: for consistency * refactor: import order * refactor: renamed prop types * refactor: type for consistency * refactor: remove index as key * fix: ts migrate settingsmodal and remove unused file (#39) * fix: ts migrate settingsmodal and remove unused file * fix: failing tests * Kate/ fix: code smells (#40) * fix: code smells * chore: empty commit * fix: function arguments * refactor: tests * fix: codesmells * refactor: code smells * chore: change optional chaining * refactor: tests * refactor: tests for widgets component * fix: tests * fix: conflicts * fix: more conflicts * fix: tests * refactor: add more test cases * fix: types in tests * fix: test extention * fix: return turbos back to types * fix: revert unplanned files * fix: code smells (#42) * fix: test extention * fix: bug with inserting objecting into the backticks * fix: file extention after ts migration * chore: sort imports * chore: revert file * chore: revert wallet changes * chore: remove extra file * chore: apply nit * fix: language switching issue with the chart --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Reduce cognitive complexity in
packages/account/src/Sections/Verification/ProofOfIdentity/proof-of-identity-configs.tsx