forked from binary-com/deriv-app
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evgeniy likhith/wall 400/incorporate idv failure message #35
Closed
likhith-deriv
wants to merge
83
commits into
evgeniy-wall-376/likhith-wall-379/verification_ux_improvement_with_example
from
evgeniy-likhith/wall-400/incorporate-IDV-failure-message
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vement_with_example' into kyc_fe_improve_failure_messages_for_idv_wall-400
* chore: fix render glitch in mt5 form * fix: dispose onfido_ref if any error occurs during onfido token fetching or sdk initialization * fix: add a check to display info message upon onfido initialization
… 'evgeniy-wall-376/likhith-wall-379/verification_ux_improvement_with_example' of github.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' of github.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' of github.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' of github.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' of github.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' into kyc_fe_improve_failure_messages_for_idv_wall-400
* fix: 🎨 resolved TS migration issues * feat: ✅ added testcaes * refactor: idv forms to useFormikContext to reduce prop drilling (#26) * refactor: idv forms to useFormikContext to reduce prop drilling * refactor: removed unused props from personal-details * feat: resolved the issues with idv testcases * feat: 🎨 incorporated image change based on status --------- Co-authored-by: Shahzaib <shahzaib@deriv.com>
…thub.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' of github.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' of github.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' of github.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' of github.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' of github.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
…vement_with_example' into kyc_fe_improve_failure_messages_for_idv_wall-400
…thub.com:yauheni-kryzhyk-deriv/deriv-app into kyc_fe_improve_failure_messages_for_idv_wall-400
* feat: ✨ incorporated IDV form for expired * feat: ✨ incorporated IDV form for expired
* fix(cashier): 🐛 fix cashier dark mode issue * test(cashier): ✅ fix the failing test --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com>
* feat: change logo when user tries to signup * refactor: delete --mobile class, useStore and observer
* chore: fix language error when clients sign up * fix: imporved code * fix: rename constant to snake case
* fix: fixed redirection back to dp2p * fix: pr comment resolved * fix: show button for idv poi submission * fix: pr comment fix * fix: pr comment fix * fix: added destructuring default value * fix: style fix * fix: moved inline function outside * fix: style fix for redirect button in idv submit * fix: check for p2p using platform param * fix: removed unused function * fix: changed param checking from p2p to dp2p * fix: persist local storage value until cleared
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…tion_ux_improvement_with_example
* feat: 🎨 refactored IDV failure * fix: reverted changes
…e' of github.com:yauheni-kryzhyk-deriv/deriv-app into evgeniy-likhith/wall-400/incorporate-IDV-failure-message
yauheni-deriv
force-pushed
the
evgeniy-wall-376/likhith-wall-379/verification_ux_improvement_with_example
branch
from
June 1, 2023 11:09
e058562
to
522ebc5
Compare
yauheni-deriv
pushed a commit
that referenced
this pull request
Nov 8, 2023
* feat: add key files from prev tech tebt branch * feat: add digits file from prev branch * feat: add contract types file from prev branch * feat: add trade params mobile from prev branch * fix: remove duplicates * Maryia/dtra-401/TS migration: multiplier components (#34) * chore: migrate cancel-deal to ts * chore: migrate expiration & expiration modal * chore: migrated multiplier * chore: migrate stop-loss * chore: migrate take-profit * chore: migrate widgets * build: trigger build with empty commit * Kate / DTRA-398 / TS migration: Widget components in Trader package (#33) * refactor: ts of contract replay widget * refactor: ts of mobile widgets * refactor: ts of chart widgets * refactor: ts of top widgets * refactor: ts of top widgets * refactor: types for widgets * refactor: apply suggestions * refactor: add position prop * fix: extention of the imported file * chore: replace some localizes (#36) * Kate / DTRA-400 / [Refactoring]: delete duplicated unused files from Markers folder in Trader package and migrate to TS marker.jsx (#37) * refactor: marker folder * fix: change file extension in test * Kate / DTRA-404 / [Refactoring]: Divide trade-categories.tsx file and cover changes with tests (#35) * refactor: add rise fall description * refactor: separate stay end high contract description * refactor: separate description of digits contracts * refactor: separate asian reset runhighlow touch contracts * refactor: separate callputspread lb tickhighlow and vanilla contracts * refactor: separate multipliers contract * refactor: add unit tests for contract descriptions * refactor: add more tests * refactor: add tests for touch ans vanilla contracts * refactor: tests for trade categories * refactor: contract description structure * refactor: apply suggestions * refactor: add missing test case * Maryia/DTRA-403/feat: migrate Routes files in Trader package to TS (#38) * feat: migrate routes files to ts * fix: routes extension * refactor: for consistency * refactor: import order * refactor: renamed prop types * refactor: type for consistency * refactor: remove index as key * fix: ts migrate settingsmodal and remove unused file (#39) * fix: ts migrate settingsmodal and remove unused file * fix: failing tests * Kate/ fix: code smells (#40) * fix: code smells * chore: empty commit * fix: function arguments * refactor: tests * fix: codesmells * refactor: code smells * chore: change optional chaining * refactor: tests * refactor: tests for widgets component * fix: tests * fix: conflicts * fix: more conflicts * fix: tests * refactor: add more test cases * fix: types in tests * fix: test extention * fix: return turbos back to types * fix: revert unplanned files * fix: code smells (#42) * fix: test extention * fix: bug with inserting objecting into the backticks * fix: file extention after ts migration * chore: sort imports * chore: revert file * chore: revert wallet changes * chore: remove extra file * chore: apply nit * fix: language switching issue with the chart --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.