Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move tket2 code to a workspace member #210

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

aborgna-q
Copy link
Collaborator

Moves the tket2 crate code to ./tket2/, and adds it to the workspace. This is mostly for cleaning up, as part of the python module cleanup task.

As a drive-by, makes sure that all the Cargo.tomls shale the workspace metadata.

@aborgna-q aborgna-q requested a review from ss2165 November 2, 2023 15:55
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #210 (2a1069d) into main (9af1bee) will increase coverage by 11.33%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #210       +/-   ##
===========================================
+ Coverage   75.26%   86.59%   +11.33%     
===========================================
  Files          35        5       -30     
  Lines        4115       97     -4018     
  Branches     4018        0     -4018     
===========================================
- Hits         3097       84     -3013     
+ Misses        838       13      -825     
+ Partials      180        0      -180     

see 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -145,7 +145,7 @@ mod tests {
#[cfg_attr(miri, ignore)] // Opening files is not supported in (isolated) miri
fn test_read_rep() {
let rep_map: HashMap<String, Circuit> =
load_representative_set("test_files/h_rz_cxrepresentative_set.json");
load_representative_set("../test_files/h_rz_cxrepresentative_set.json");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set some kind of workspace environment variable or something to make this less flaky?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be a bit noisy, so I'll open an issue for that.

@@ -0,0 +1,62 @@
#![cfg(feature = "portmatching")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason github didn't recognize this file move

@aborgna-q aborgna-q added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit dc03c31 Nov 3, 2023
11 checks passed
@aborgna-q aborgna-q deleted the refactor/restructure-core branch November 3, 2023 14:21
github-merge-queue bot pushed a commit that referenced this pull request May 24, 2024
## 🤖 New release
* `tket2`: 0.1.0-alpha.1

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.0.0-alpha.1](https://github.com/CQCL/tket2/releases/tag/tket2-v0.0.0-alpha.1)
- 2024-05-24

### Bug Fixes
- Check for rewrite composition in badger
([#255](#255))
- induced cycles in depth optimisation
([#264](#264))
- Encode opaque symbolic constants
([#273](#273))
- Correctly detect custom ops by name
([#281](#281))
- Track input linear units in `Command`
([#310](#310))
- Don't convert tket2 measurements into tket1 ops
([#331](#331))

### Documentation
- Expand the main module and README docs
([#298](#298))

### New Features
- add angle type to tket2 extension
([#231](#231))
- bindings for circuit cost and hash
([#252](#252))
- Implement `PyErr` conversion locally in `tket2-py`
([#258](#258))
- Add a "progress timeout" to badger
([#259](#259))
- [**breaking**] Add lexicographic cost
([#270](#270))
- rewrite tracing ([#267](#267))
- Move pre/post rewrite cost to the RewriteStrategy API
([#276](#276))
- [**breaking**] Lexicographic cost fn
([#277](#277))
- Return rewrite strategies as a generator
([#275](#275))
- add qalloc, qfree, reset ops
([#284](#284))
- [**breaking**] Support any ops in portmatching
([#293](#293))
- Add `PatternMatch::nodes` and `subcircuit` + matching example
([#299](#299))
- Use `IncomingPort` and `OutgoingPort` instead of `Port` where
possible. ([#296](#296))
- expose Tk2Op name ([#307](#307))

### Refactor
- Move tket2 code to a workspace member
([#210](#210))
- Restructure the python code
([#211](#211))
- s/taso/badger/ ([#228](#228))
- Move python bindings from `tket2` to `tket2-py`
([#235](#235))
- rename t2op ([#256](#256))

### Testing
- Add small parallel badger test
([#237](#237))
- fix non-deterministic badger test
([#245](#245))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Agustin Borgna <agustin.borgna@quantinuum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants