feat: rewrite tracing #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 83.44% 83.40% -0.04%
==========================================
Files 34 35 +1
Lines 4191 4285 +94
Branches 4075 4169 +94
==========================================
+ Hits 3497 3574 +77
- Misses 511 526 +15
- Partials 183 185 +2 ☔ View full report in Codecov by Sentry. |
ss2165
approved these changes
Dec 14, 2023
| /// | ||
| /// Note that circuits must be explicitly enabled for rewrite tracing by calling | ||
| /// [`RewriteTracer::enable_rewrite_tracing`]. | ||
| pub const REWRITE_TRACING_ENABLED: bool = cfg!(feature = "rewrite-tracing"); |
There was a problem hiding this comment.
is rust analyzer etc. good enough to ignore code guarded by this constant?
There was a problem hiding this comment.
rust analyser checks the default features unless configured differently, but this should work the same as any const flag.
| } | ||
| let meta = self.get_metadata(self.root(), METADATA_REWRITES)?; | ||
| let rewrites = meta.as_array()?; | ||
| Some(rewrites.iter().map_into().collect_vec()) |
There was a problem hiding this comment.
Not possible with the .map_into, but we could return an impl Iterator once RPITIT` is here...
|
There doesn't seem to be any key or namespace reservation happening in the metadata to denote a section as being for rewrites? |
|
There is no structure for the metadata namespace yet. There's a discussion thread for that: CQCL/hugr#268 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 24, 2024
## 🤖 New release * `tket2`: 0.1.0-alpha.1 <details><summary><i><b>Changelog</b></i></summary><p> ## `tket2` <blockquote> ## [0.0.0-alpha.1](https://github.com/CQCL/tket2/releases/tag/tket2-v0.0.0-alpha.1) - 2024-05-24 ### Bug Fixes - Check for rewrite composition in badger ([#255](#255)) - induced cycles in depth optimisation ([#264](#264)) - Encode opaque symbolic constants ([#273](#273)) - Correctly detect custom ops by name ([#281](#281)) - Track input linear units in `Command` ([#310](#310)) - Don't convert tket2 measurements into tket1 ops ([#331](#331)) ### Documentation - Expand the main module and README docs ([#298](#298)) ### New Features - add angle type to tket2 extension ([#231](#231)) - bindings for circuit cost and hash ([#252](#252)) - Implement `PyErr` conversion locally in `tket2-py` ([#258](#258)) - Add a "progress timeout" to badger ([#259](#259)) - [**breaking**] Add lexicographic cost ([#270](#270)) - rewrite tracing ([#267](#267)) - Move pre/post rewrite cost to the RewriteStrategy API ([#276](#276)) - [**breaking**] Lexicographic cost fn ([#277](#277)) - Return rewrite strategies as a generator ([#275](#275)) - add qalloc, qfree, reset ops ([#284](#284)) - [**breaking**] Support any ops in portmatching ([#293](#293)) - Add `PatternMatch::nodes` and `subcircuit` + matching example ([#299](#299)) - Use `IncomingPort` and `OutgoingPort` instead of `Port` where possible. ([#296](#296)) - expose Tk2Op name ([#307](#307)) ### Refactor - Move tket2 code to a workspace member ([#210](#210)) - Restructure the python code ([#211](#211)) - s/taso/badger/ ([#228](#228)) - Move python bindings from `tket2` to `tket2-py` ([#235](#235)) - rename t2op ([#256](#256)) ### Testing - Add small parallel badger test ([#237](#237)) - fix non-deterministic badger test ([#245](#245)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Agustin Borgna <agustin.borgna@quantinuum.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally store metadata about the rewrites applied to a circuit.
If the
rewrite-tracingfeature is disabled, this has no effect on the runtime.If the feature is enabled, circuits must opt-in to the tracing by calling
RewriteTracer::enable_rewrite_tracing.Closes #216