Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canned fruit, canned tomatoes and canned livers not filling the right amounts #37504

Closed
Illgowiththisname opened this issue Jan 29, 2020 · 1 comment · Fixed by #38226
Closed
Labels
Game: Balance Balancing of (existing) in-game features. Good First Issue This is a good first issue for a new contributor Items: Food / Vitamins Comestibles and drinks

Comments

@Illgowiththisname
Copy link

Illgowiththisname commented Jan 29, 2020

Describe the bug

Canned fruit and canned tomatoes only fill the containers halfway and the canned liver is twice the amount the tin can should be able to contain

Steps To Reproduce

Steps to reproduce the behavior:

  1. need level 5 or higher cooking, tools with metal sawing 1 or higher, hammering 1 or higher, cutting 1 or higher, food cooking 3 or higher, some form of heat source for cooking, can sealer, canning pot, 3 scrap metal, 3 small opened tins, 2 glass jars, 2 3L glass jars, 30 of a fruit, 8 raw livers, 15 tomatoes and 54 water or clean water
  2. Shift + 7 for crafting menu then shift +f search either canned fruit, canned tomato or canned liver (for canned liver only the small tin can version seems weird)
  3. craft whichever item you picked.
  4. check max amount container could hold vs what is in container.

Expected behavior

for the livers either make a 4 liver recipe using the small tin can or use the medium sized tin can for the 8 livers since its double the size. for the canned fruit and tomatoes either double the amount put into the container or half the amount of fruit and tomatoes it says the containers can store.

Screenshots

food containers

Versions and configuration

  • OS: Windows
    • OS Version: Windows 7 Ultimate
  • Game Version: 0.D-11709-g9d46c12 [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Monsters [Only_Wildlife]
    ]

Additional context

not putting in a save in for this one cause of how messy i made my save checking pretty much every can sealer and canning pot recipe i saw

@codemime codemime added Items: Food / Vitamins Comestibles and drinks Game: Balance Balancing of (existing) in-game features. Good First Issue This is a good first issue for a new contributor labels Jan 29, 2020
jkraybill added a commit to jkraybill/Cataclysm-DDA that referenced this issue Jan 30, 2020
@jkraybill
Copy link
Contributor

Nice catch, thanks @Illgowiththisname! I noticed some other ratio inconsistencies and plan on doing a little project to clean up canning recipes on a larger scale in #37551 .

If you're actively using canning in the game, and have any observations about things you would like to see improved or changed in the future, please leave your input as comments in #37551! I suspect these systems like canning/brewing/smoking don't get a whole lot of use from mainstream players so any feedback from survivalist cooks would help in generating ideas for future changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game: Balance Balancing of (existing) in-game features. Good First Issue This is a good first issue for a new contributor Items: Food / Vitamins Comestibles and drinks
Projects
None yet
3 participants