Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You lived your life, like a candle in the wind... #27935

Merged
merged 2 commits into from Feb 4, 2019
Merged

You lived your life, like a candle in the wind... #27935

merged 2 commits into from Feb 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 28, 2019

Summary

SUMMARY: Features "Candles are now blown out by the wind"

Purpose of change

Candles should be blown out by the wind.
Now they are.
It's silly really, but it's realism(tm)

Describe the solution

I made the candle,
get blown out
by the wind.

Describe alternatives you've considered

Considered candles turning into flamethrowers but discarded that idea due to performance reasons.

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact Mechanics: Weather Rain, snow, portal storms and non-temperature environment <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON labels Jan 28, 2019
src/item.cpp Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit b496d74 into CleverRaven:master Feb 4, 2019
ZhilkinSerg added a commit that referenced this pull request Feb 6, 2019
* upstream/pr/28084: (88 commits)
  Fix wet morale cycling
  clear player morale effects in clear_player (#28045)
  Adds some money types. (#27963)
  You lived your life, like a candle in the wind... (#27935)
  [CR] Joint torsion ratchet CBM increases stamina drain (toggleable) (#27882)
  Allowed Snowstorms to happen - added snow wet and glare effects ( and fixed test_weather ) (#27870)
  I didn't make this mod! (#28033)
  Replaced popup with a message in a sidebar
  Added a popup after the start describing scenario
  Added Color manager mention to COLOR.md (#27991)
  Fix some more mission completion dialog bugs
  Fix NPC dialog around lying and succeeding mission
  Update MSX++DeadPeopleEdition 2019-01-31
  Update RetroDays - Mouse mutants, mailboxes
  Update lab_1.json
  Clear traps in test clear_map helper
  Fixed cyan color in COLOR.md (#27969)
  Update gfx/RetroASCIITileset/tile_config.json
  RetroAscii tileset - cleanup, update, lint
  Add lab terrain
  ...
@ghost ghost deleted the candle_in_the_wind branch February 8, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Mechanics: Weather Rain, snow, portal storms and non-temperature environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants