Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some money types. #27963

Merged
merged 15 commits into from
Feb 4, 2019
Merged

Adds some money types. #27963

merged 15 commits into from
Feb 4, 2019

Conversation

I-am-Erk
Copy link
Member

Summary

SUMMARY: Content "Adds Free Merchant currency'"

Purpose of change

This adds free merchant currency as discussed in #27955, #27449 and #27447

I do not believe it fully satisfies the latter two issues yet as this is just free merchants, with a small infrastructural change for the Campus mainly because I hope to soon add a few references to their existence amongst the merchants.

Describe the solution

Adds the Free Merchant Certified Note, commonly called the Merch. This is a promissory note printed on old US large-denom currency.

Currently the only way to get this is by bartering with the free merchant shopkeeper. I cannot see any way at this time to make the money less valuable outside the free merchant faction; the code will probably need to be updated to give a factional flag to currency allowing us to give it no or partial value to other factions.

I may add further support for the currency within this PR, eg selling food, but I need it added so that my NPCs can start asking for it.

Describe alternatives you've considered

There's been a long and involved discussion on various options for currency, but ultimately a promissory note is the most logical and this one has a good post apocalyptic flavour.

Additional context

Not yet checked in-game.

I-am-Erk and others added 9 commits January 23, 2019 08:48
This reverts commit 753b1ac, reversing
changes made to 9a32197.
Adds two new currencies, for the free merchants and the as-yet nonexistent campus faction.
This makes sure the shopkeeper will have some, but the amount will vary randomly
Adds a price value, pretty much randomly set for now.
@anothersimulacrum
Copy link
Member

You've got some unrelated changes in with this PR.

@I-am-Erk
Copy link
Member Author

Yes, my local repository seems to be borked. I'm trying to fix it, but it's not updating... will probably have to restart this pr after I've figured it out

@Leland
Copy link
Contributor

Leland commented Jan 30, 2019

Suppose the PR is as good a place for this as any: the (standard game mode) CDDA starts 5 days after the Cataclysm. Is this currency one that the Free Merchants developed pre-Cataclysm? And if so, why?

I ask because developing a currency is no small thing (and there's likely been other things on peoples minds in the week after the apocalypse).

@I-am-Erk
Copy link
Member Author

I-am-Erk commented Jan 30, 2019

The Free Merchants would probably have worked out some form of promissory note within a few days of the Cataclysm; one of the reasons I like the signed bills is that they feel like something that would have started naturally ("sure, I'll take cash... but only if you write on it something to guarantee it's worth the food I'm owed!") and been rapidly adopted among them.

I assume that the lag between "end of the world" and "free merchants adopt promissory notes for internal allocation of resources" is short enough that there's not a lot of value in the number of conditionals it would take to simulate the transition period. What is going to eventually be simulated is the longer period where it's slowly adopted by other groups, but for now they only really work among the merchants.

@AMurkin
Copy link
Contributor

AMurkin commented Jan 30, 2019

Maybe limit for some random period of time per world to rumors about new currency only? End game economics.

@I-am-Erk
Copy link
Member Author

There's not really a ton of value to limiting it to a period of time. It adds a huge amount of work to every dialogue file related to paying for services, for the niche times a player makes it to the refugee center incredibly early or starts out there. Plus I currently can't limit item spawning in merchant inventories based on game time, so it would prevent me from letting the merchant trade for it.

@kevingranade kevingranade merged commit e352e81 into CleverRaven:master Feb 4, 2019
ZhilkinSerg added a commit that referenced this pull request Feb 6, 2019
* upstream/pr/28084: (88 commits)
  Fix wet morale cycling
  clear player morale effects in clear_player (#28045)
  Adds some money types. (#27963)
  You lived your life, like a candle in the wind... (#27935)
  [CR] Joint torsion ratchet CBM increases stamina drain (toggleable) (#27882)
  Allowed Snowstorms to happen - added snow wet and glare effects ( and fixed test_weather ) (#27870)
  I didn't make this mod! (#28033)
  Replaced popup with a message in a sidebar
  Added a popup after the start describing scenario
  Added Color manager mention to COLOR.md (#27991)
  Fix some more mission completion dialog bugs
  Fix NPC dialog around lying and succeeding mission
  Update MSX++DeadPeopleEdition 2019-01-31
  Update RetroDays - Mouse mutants, mailboxes
  Update lab_1.json
  Clear traps in test clear_map helper
  Fixed cyan color in COLOR.md (#27969)
  Update gfx/RetroASCIITileset/tile_config.json
  RetroAscii tileset - cleanup, update, lint
  Add lab terrain
  ...
@I-am-Erk I-am-Erk deleted the FM-Money branch March 21, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants