Allow professions to start with a nearby vehicle - trucker profession

[ghost]

Summary

SUMMARY: Features "Allow professions to start with a nearby vehicle - trucker profession"

Purpose of change

Allow professions to start with a nearby vehicle - trucker profession

Describe the solution

Define a vproto_id in the profession json.
This will get loaded on new game, it will try and place the vehicle on a nearby road ( some scenarios may make this difficult ) - it will always place on z-level 0, no matter where the player starts.
It will try 10 times in an expanding radius, it wont merge with other vehicles or cause wreckage.
It will then mark it on the overmap as if oyu had selected "remember this vehicles position".

Added a trucker profession as a basic showcase, starts with a semi truck nearby.

Describe alternatives you've considered

N/A

Testing

Made new game, chose trucker profession, tried around 10 times, in each case, the truck was rarely more than like 5 -10 omts away, on a road.
This was in the shelter start.

Additional context

N/A

[codemime]

The idea is awesome, but the implementation needs some polishing.

[Amoebka]

The fact that it can just give up and not spawn the vehicle if it can't find a road makes the profession way too random in some cases. A number of starting locations aren't guaranteed to spawn anywhere near roads, and some worldgen settings generate worlds without any roads at all. This can be confusing to players - the description says you have a truck but you don't.

Ideally there should be a way to blacklist professions based on world settings and blacklist starting locations based on professions for this to work properly. Alternatively, it should spawn the truck on an empty field tile if it can't find a road.

[ghost]

The fact that it can just give up and not spawn the vehicle if it can't find a road makes the profession way too random in some cases. A number of starting locations aren't guaranteed to spawn anywhere near roads, and some worldgen settings generate worlds without any roads at all. This can be confusing to players - the description says you have a truck but you don't.

Ideally there should be a way to blacklist professions based on world settings and blacklist starting locations based on professions for this to work properly. Alternatively, it should spawn the truck on an empty field tile if it can't find a road.

spawning in a field, yeah.. this could end up with the vehicle spawning totally enclosed by forest or something, and "beached", ,but I guess thats better than no vehicle at all.

I suppose yes, if you spawn on a lake island or something, this could be impossible to spawn the vehicle, and also what if a profession selects a boat to start with?

I will think on some elegant ( hopefully ) solutions to this, ill put this into WIP ( its in feature freeze anyway )

Ill think of some more fallback options to make sure peeps get their starting vehicle.

[ghost]

Added fallback options depending on whether the vehicle is a boat or car or both, so if road fails, it will go to fields, and for boats it will search for rivers and lakes.

[codemime]

Almost there. The comments below are mostly nitpicking (nice to have done, but not strictly necessary). The code is reasonably good as it is. Didn't test the behavior though.

[ghost]

Thanks for the thorough review, tested and working after changes.

[ZhilkinSerg]

Apparently it should be MAKE_NULL_ID2 as vehicle_prototype is a struct, not a class. It seems not to affect most compilers, but VS would bitch about this when linking.