Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.20.0 #1294

Merged
merged 68 commits into from
Jun 1, 2023
Merged

Release 1.20.0 #1294

merged 68 commits into from
Jun 1, 2023

Conversation

maxep
Copy link
Member

@maxep maxep commented May 30, 2023

What and why?

Release 1.20.0

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

maciejburda and others added 30 commits April 26, 2023 18:11
Merge `release/1.19.0` to `develop`
…oller-support

REPLAY-1512 UIAlertController support
### What and why?

On x86 a `fatalError()` results on a SIGILL signal but on an ARM machine it results in a `SIGTRAP`.

Hence, the test case fail on the ARM machine. In order to update the CI to ARM, this needs to be fixed.

### How?

Use preprocessor macros to check the architecture and then use the appropriate signal.
…error-test-on-develop

[porting to develop] RUMM-3266 fix: use arch conditionals to assert arch specific signal
…viewcontroller-support

REPLAY-1516 Unsupported ViewController placeholder
### What and why?

Currently, to find out the FPS of a view, the SDK look for the frame duration and inverses it to get the FPS.

Eg. if the frame duration is 16ms (0.016s), the FPS is 1/0.016 = 60FPS (rounded).

This generally works but when comes to variable refresh rate displays, it becomes an issue. For example, let's say OS has decided to increase the frame duration to 32ms to save battery, the FPS will be 30FPS but that doesn't mean the app is having a poor UI performance. It can very well be that the app is doing nothing.

### How?

`CADisplayLink` has a property called `targetTimestamp` which is the time when the next frame is scheduled to be displayed. This is the time when the frame is actually displayed on the screen. Hence, the SDK uses this property to calculate the expected frame duration and then inverses it to get the FPS.

At the same time, SDK continues to use the old logic to calculate the FPS using the `timestamp` property.

Finally, the SDK normalizes the FPS to 60FPS as Datadog backend only supports 60FPS rate for now described [here](https://www.datadoghq.com/blog/monitor-mobile-vitals-datadog/#slow-rendering).
ncreated and others added 23 commits May 9, 2023 09:30
as it was wrongly listing `DD_OVERRIDE_TOOLS_TESTS` instead of
the actual `DD_OVERRIDE_RUN_TOOLS_TESTS`
Fix `run_nightly_smoke_and_tools_tests` workflow
…g-sdk-2.3.0

Update to version 2.3.0 of testing framework
…acy-rules

REPLAY-1610 Align text and appearance masking rules
…ger-duplicate-crashes

RUMM-3277 Prevent sending RUM Error from Cross Platform crash logs
Introduces the SDKInit command when RUM Monitor is created in order to guarantee all correlated logs and traces have a valid session_id matching the session.
RUMM-3237 Introduce SDKInit command in order to force new session on SDK initialization
Do not start Application Launch View on `RUMSDKInitCommand`
…-tests

RUMM-3237 Fix Application Launch View Creation
### What and why?

During fixing the variable refresh rate calculation, the normalization was applied during the refresh rate determination phase, but the logic to normalize it again during the reporting was kept which resulted in double normalization.

Eg. First we normalize based on the logic of targetTimestamp and then divide by 2 for 120Hz display.

### How?

Remove second normalization phase during the reporting.
…rmalization

RUMM-3222 Don't scale down refresh rate multiple times
@maxep maxep self-assigned this May 30, 2023
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 30, 2023

Datadog Report

Branch report: release/1.20.0
Commit report: 3e8b15e

dd-sdk-ios: 0 Failed, 0 New Flaky, 116 Passed, 0 Skipped, 3m 29.28s Wall Time

@maxep maxep marked this pull request as ready for review June 1, 2023 07:30
@maxep maxep requested a review from a team as a code owner June 1, 2023 07:30
@maxep maxep merged commit 9cfa552 into master Jun 1, 2023
@maxep maxep mentioned this pull request Jun 1, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants