Fix infinite spinner when signing into an account after signing out

[alex-mechler]

cc @Julesssss @marcaaron

Details

Moves the DeleteLogin call to be before we clear the auth token, ensuring that we do not make a network request without an auth token.

** This does introduce a new bug, where we drop the user into /r/ after signing in and out. We have decided that this should not block the release. **

Fixed Issues

Fixes #3488

Tests / QA Steps

1. Sign into an account
2. Sign out of the account
3. Verify you can sign into a different account
   • you will be dropped into /r/, and not a chat. This is a different issue which we have decided to live with for now to not block release

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[alex-mechler]

Ready for review, follow up issue here. @marcaaron This solves a deploy blocker, so a quick review would be great if you can!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[aliabbasmalik8]

This issue still produces on the latest main branch.
VIDEO: http://recordit.co/vO2GdLgryh

[alex-mechler]

@aliabbasmalik8 Did you npm i? there was a change that had to be made in onyx that fixed that behavior

[aliabbasmalik8]

Okay, Got it. let me check

[aliabbasmalik8]

@alex-mechler No, it did not produce after run npm i.
it's working fine

[roryabraham]

I am going to manually CP this to staging. P.S. if you want to CP a PR to staging the easiest/default way of doing that is by adding the CP Staging label before it's merged 😁

[OSBotify]

🚀 Cherry-picked to staging in version: 1.0.68-3🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.68-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging in version: 1.0.68-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.73-3🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

@roryabraham Not sure why this PR was added to the staging checklist again. Looks like it was already deployed to production.