Prepared spot_instance_basic for inclusion in C.G.C. documentation #5950

saqibkhanspeaks12 · 2022-04-18T12:21:14Z

Created sample for creating spot basic Spot VM for CGC
https://cloud.google.com/compute/docs/instances/create-use-spot#create

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2022-04-18T12:22:15Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@shuyama1, please review this PR or find an appropriate assignee.

modular-magician · 2022-04-18T12:36:42Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 54 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 28 insertions(+))

modular-magician · 2022-04-18T13:14:39Z

Tests analytics

Total tests: 1987
Passed tests 1744
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccCGCSnippet_spotInstanceBasicExample

modular-magician · 2022-04-18T13:21:28Z

Tests passed during RECORDING mode:
TestAccCGCSnippet_spotInstanceBasicExample[view]
TestAccServiceNetworkingPeeredDNSDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]

All tests passed
View the build log or the debug log for each test

shuyama1 · 2022-04-23T01:32:13Z

/gcbrun

modular-magician · 2022-04-23T01:46:54Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 54 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 28 insertions(+))

modular-magician · 2022-04-23T02:30:38Z

Tests analytics

Total tests: 1986
Passed tests 1743
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_update|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

modular-magician · 2022-04-23T02:41:27Z

Tests passed during RECORDING mode:
TestAccServiceNetworkingPeeredDNSDomain_basic[view]
TestAccComputeForwardingRule_update[view]

Tests failed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]

Please fix these to complete your PR
View the build log or the debug log for each test

saqibkhanspeaks12 · 2022-04-25T18:58:51Z

Fixed the conflict, please initiate test again

shuyama1 · 2022-04-25T20:04:03Z

Hey @saqibkhanspeaks12. Looks like the conflicts still exit. Would you mind taking a look? Sorry about that. Please let me if you have any questions. Also we just promoted Spot VMs to GA recently in #5960. But it's totally your call if you want to add this in GA as well :)

saqibkhanspeaks12 · 2022-04-25T20:20:29Z

@shuyama1 Thanks for letting me know. I wasn't aware of the update to GA. If it makes more sense, should I just close the beta PR and raise a new PR for GA provider itself? that way this remains more relevant. Looking for the best way to take this forward.

shuyama1 · 2022-04-25T20:30:24Z

Simply removing min_version: beta in the terramform.yaml and provider = google-beta in your sample should generate the GA documentation and tests for both providers I believe! Sorry about the extra work!

…latform#5940)

…stance_template` & `google_compute_instance` resource (GoogleCloudPlatform#5696) * update instance template validatefunc values Co-authored-by: upodroid <cy@borg.dev> * add the change to instances as well * fix docs again * remove ValidateFunc

…5949)

* Add new IGM.UpdatePolicy features - minimal_action=REFRESH and most_disruptive_allowed_action * Fix documentation of most_disruptive_allowed_action * Make most_disruptive_allowed_action an Optional field. * Fix RMIG UpdatePolicy flattening. * Fix most_disruptive_allowed_action documentation - new field is Optional. * Fix most_disruptive_allowed_action documentation - and improve testing. * Fix whitespaces in test. Co-authored-by: Grzegorz Sancewicz <gsancewicz@google.com>

* Fixed database version * Updated DB versions

* Added Cloud SQL flags and user examples * Changed name to id to fix Reference to undeclared resource error * fixed references * fixed flags * Removed the user part because it's causing errors

…udPlatform#5946)

…leCloudPlatform#5953)

Co-authored-by: upodroid <cy@borg.dev> Co-authored-by: Riley Karson <rileykarson@google.com>

…#4956)" (GoogleCloudPlatform#5964) This reverts commit 31d1d16.

)" (GoogleCloudPlatform#5968) This reverts commit e379f06.

…#5961)

…oudPlatform#5858)

Prepared spot_instance_basic for inclusion in C.G.C. documentation

22bc5d4

modular-magician requested a review from shuyama1 April 18, 2022 12:22

Updated terraform.yaml to avoid conflicts

ced46bc

miticojo and others added 15 commits April 25, 2022 21:12

add gke_backup_agent_config to google_container_cluster (GoogleCloudP…

0446b37

…latform#5940)

add GOOGLE_ORG_2 to vcr (GoogleCloudPlatform#5951)

d5a8f03

Allow deleting google_logging_*_bucket_config (GoogleCloudPlatform#…

5f48e8a

…5949)

Fixed database version (GoogleCloudPlatform#5927)

46f7f03

* Fixed database version * Updated DB versions

Added Cloud SQL flag examples (GoogleCloudPlatform#5943)

35658d3

* Added Cloud SQL flags and user examples * Changed name to id to fix Reference to undeclared resource error * fixed references * fixed flags * Removed the user part because it's causing errors

include 'Exceed Redirect Options' in security policy rules (GoogleClo…

702677f

…udPlatform#5946)

Add Warnings about sensitive Google Credentials in Remote State (Goog…

4b9f37e

…leCloudPlatform#5953)

Update beta mentions in Provider docs (GoogleCloudPlatform#5667)

a933c2d

Co-authored-by: upodroid <cy@borg.dev> Co-authored-by: Riley Karson <rileykarson@google.com>

add deletion protection for CA (GoogleCloudPlatform#5932)

c9f8128

Turn Spot VMs to GA on GCE. (GoogleCloudPlatform#5960)

704a887

Fix missing fields on Certificate (GoogleCloudPlatform#5941)

89ac90f

Add deprecated annotation for output fields (GoogleCloudPlatform#5962)

556f13e

Fixed binary log doc (GoogleCloudPlatform#5963)

d5c16c2

murphyjacob4 and others added 9 commits April 25, 2022 21:12

Add support for L4 ILB subsetting policy (GoogleCloudPlatform#5944)

93e9aad

Revert "Support new features of IGM.updatePolicy (GoogleCloudPlatform…

7d27a42

…#4956)" (GoogleCloudPlatform#5964) This reverts commit 31d1d16.

Revert "Add support for Cloud Deploy resources (GoogleCloudPlatform#5710

5fb1acd

)" (GoogleCloudPlatform#5968) This reverts commit e379f06.

Add dependencies to fix VCR testing (GoogleCloudPlatform#5969)

e635ba2

Add a review time call-to-action to the Magician (GoogleCloudPlatform…

99297af

…#5961)

Fix docstring error (GoogleCloudPlatform#5966)

e3fa5c7

Support Managed Envoy in google_compute_instance_template (GoogleCl…

5e1a16f

…oudPlatform#5858)

Updated to resolve merge conflicts

c880e1e

Changed from Beta to GA provider

79dc36d

saqibkhanspeaks12 closed this Apr 25, 2022

saqibkhanspeaks12 deleted the bug-216854681 branch April 25, 2022 21:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepared spot_instance_basic for inclusion in C.G.C. documentation #5950

Prepared spot_instance_basic for inclusion in C.G.C. documentation #5950

saqibkhanspeaks12 commented Apr 18, 2022 •

edited by shuyama1

Loading

modular-magician commented Apr 18, 2022

modular-magician commented Apr 18, 2022

modular-magician commented Apr 18, 2022

modular-magician commented Apr 18, 2022

shuyama1 commented Apr 23, 2022

modular-magician commented Apr 23, 2022

modular-magician commented Apr 23, 2022

modular-magician commented Apr 23, 2022

saqibkhanspeaks12 commented Apr 25, 2022

shuyama1 commented Apr 25, 2022 •

edited

Loading

saqibkhanspeaks12 commented Apr 25, 2022

shuyama1 commented Apr 25, 2022

Prepared spot_instance_basic for inclusion in C.G.C. documentation #5950

Prepared spot_instance_basic for inclusion in C.G.C. documentation #5950

Conversation

saqibkhanspeaks12 commented Apr 18, 2022 • edited by shuyama1 Loading

modular-magician commented Apr 18, 2022

modular-magician commented Apr 18, 2022

Diff report:

modular-magician commented Apr 18, 2022

Tests analytics

Action taken

modular-magician commented Apr 18, 2022

shuyama1 commented Apr 23, 2022

modular-magician commented Apr 23, 2022

Diff report:

modular-magician commented Apr 23, 2022

Tests analytics

Action taken

modular-magician commented Apr 23, 2022

saqibkhanspeaks12 commented Apr 25, 2022

shuyama1 commented Apr 25, 2022 • edited Loading

saqibkhanspeaks12 commented Apr 25, 2022

shuyama1 commented Apr 25, 2022

saqibkhanspeaks12 commented Apr 18, 2022 •

edited by shuyama1

Loading

shuyama1 commented Apr 25, 2022 •

edited

Loading