Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create network security url lists #7584

Conversation

diogoEsteves42
Copy link
Contributor

Adding network security urlLists resource support.

fixes: hashicorp/terraform-provider-google#14161

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

release-note: new-resource

diogo esteves and others added 24 commits March 30, 2023 20:10
* chore(ci): allowfailure in tfv tests

* Add allowfailure to tfv-base and tfv-head
…m#7509)

Co-authored-by: Madhura Phadnis <madhurap@google.com>
…gleCloudPlatform#7488)

* Add Apigee Keystore aliases resource for Self Signed Cert Format

* Second commit for selfsigned and initial commit for pkcs

* remove pkcs resource files

* Update selfsigned code

* update the reference link for API

* fix syntax error

* add ignore_Read to ignore force_replacement errors

* Update the files according to PR reviews per best practices

* align indentation

* update the primary resource id

---------

Co-authored-by: Anuhya P <anuhyap@google.com>
…bullseye for containers (GoogleCloudPlatform#7557)" (GoogleCloudPlatform#7559)

* Revert "Use Go 1.19-bullseye for containers (GoogleCloudPlatform#7557)"

This reverts commit 0e38305.

* Revert "Upgrade Go 1.19 (GoogleCloudPlatform#7550)"

This reverts commit 767d8bb.
* Add files via upload

* Delete cai.go

* Delete convert.go

* Delete custom_org_policy.go

* Delete example_custom_org_policy.json

* Delete example_custom_org_policy.tf

* Delete example_custom_org_policy.tfplan.json

* Delete read_test.go

* Delete resource_converters.go

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update cli_test.go.erb

* Update terraform_validator.rb

* Update resource_converters.go.erb

* Update example_custom_org_policy.json

* Update example_custom_org_policy.tfplan.json

* Update example_custom_org_policy.tfplan.json

* Update example_custom_org_policy.tf

* Update example_custom_org_policy.tf

* Update example_custom_org_policy.tf

* Update example_custom_org_policy.json

* Update example_custom_org_policy.tf

* Update cli_test.go.erb

* Update terraform_validator.rb

* Update resource_converters.go.erb

* Update cai.go

* Update cai.go

* Update and rename custom_org_policy.go to org_policy_policy.go

* Update and rename example_custom_org_policy.tf to example_org_policy_policy.tf

* Update and rename example_custom_org_policy.json to example_org_policy_policy.json

* Update and rename example_custom_org_policy.tfplan.json to example_org_policy_policy.tfplan.json

* Update cli_test.go.erb

* Update cli_test.go.erb

* Update cai.go

* Update org_policy_policy.go
…form#7501)

* Revert "revert plugin framework code (GoogleCloudPlatform#7287)"

This reverts commit 06f9b2e.

* changes to plugin-framework work for parity

* add some provider tests fix other inconsistent errors with the sdk provider

* update provider alias name

* other changes

* fix up base path test

* update tests to use muxer

* use beta provider when we need to for some of the provider tests

* remove all the specific providers from the config

* attempt to fix vcr tests

* refactor the vcr configuration

* capitalize provider factories

* some test failure fixes

* remove skip step if vcr

* review comments

* fixed pointer errors

* move providerversion450 to be dependent on resource, revers diag pointers

* reverse another pointer

* update firebase apple app config datasource to plugin-framework

* update with latest plugin-framework changes

* Revert "revert plugin framework code (GoogleCloudPlatform#7287)"

This reverts commit 06f9b2e.

* changes to plugin-framework work for parity

* add some provider tests fix other inconsistent errors with the sdk provider

* update tests to use muxer

* use beta provider when we need to for some of the provider tests

* remove all the specific providers from the config

* changes after merge

* attempt to fix vcr tests

* refactor the vcr configuration

* capitalize provider factories

* some test failure fixes

* remove skip step if vcr

* review comments

* fixed pointer errors

* move providerversion450 to be dependent on resource, revers diag pointers

* update firebase apple app config datasource to plugin-framework

* update web app config

* update external provider version tests

* rm non erb, bad merge maybe

* update after a bad merge

* add comments

* review comments, applied them to dns data sources as well
…ess issues (GoogleCloudPlatform#7553)

* Update TestAccBillingBudget_budgetFilterProjectsOrdering to create projects use main billing account

* Remove billing datasource for primary billing account
* Tune output of missing test detector

* Remove PR guard for missing test detection

* Use a go template to render output
@diogoEsteves42 diogoEsteves42 requested a review from a team as a code owner March 31, 2023 17:14
@diogoEsteves42 diogoEsteves42 requested review from c2thorn and removed request for a team March 31, 2023 17:14
@google-cla
Copy link

google-cla bot commented Mar 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician
Copy link
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@diogoEsteves42 diogoEsteves42 deleted the create-gateway-url-lists-resource branch March 31, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetworkSecurity - create the resource of UrlLists