Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google_container_cluster): support fqdn network policy #8461

Merged

Conversation

toVersus
Copy link
Contributor

@toVersus toVersus commented Jul 27, 2023

Fixes: hashicorp/terraform-provider-google#15295

This PR added support for enabling FQDN Network Policy for the google_container_cluster resource. This allows users to enable / disable FQDN Network Policy feature. For standard GKE cluster users, they need to restart anetd DaemonSet after enablement. See Control Pod egress traffic using FQDN network policies and corresponding REST API doc.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added `enable_fqdn_network_policy` field to `google_container_cluster`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 27, 2023
@toVersus toVersus force-pushed the feat/fqdn-network-policy branch 2 times, most recently from 0deb514 to 50f253b Compare July 27, 2023 05:09
@toVersus
Copy link
Contributor Author

I ran the test locally and got the following error. I'll look into it.

✖  make testacc TEST=./google-beta TESTARGS='-run=TestAccContainerCluster_withFQDNNetworkPolicy'
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta -v -run=TestAccContainerCluster_withFQDNNetworkPolicy -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN   TestAccContainerCluster_withFQDNNetworkPolicy
=== PAUSE TestAccContainerCluster_withFQDNNetworkPolicy
=== CONT  TestAccContainerCluster_withFQDNNetworkPolicy
    vcr_utils.go:152: Step 5/6 error: Error running apply: exit status 1

        Error: googleapi: Error 400: Must specify a field to update.
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.RequestInfo",
            "requestId": "0xb457adc22a798dd2"
          }
        ]
        , badRequest

          with google_container_cluster.cluster,
          on terraform_plugin_test.tf line 41, in resource "google_container_cluster" "cluster":

@toVersus toVersus force-pushed the feat/fqdn-network-policy branch from 50f253b to 1d164a4 Compare July 27, 2023 06:40
@toVersus
Copy link
Contributor Author

Once the FQDN network policy feature is enabled, it seems that it cannot be disabled. I added the CustomizeDiff similar to L4 ILB subsetting, and changed the allow value from false to true. Otherwise force recreate it.

@toVersus
Copy link
Contributor Author

toVersus commented Aug 4, 2023

ping @rileykarson

@em-le-ts
Copy link

em-le-ts commented Aug 5, 2023

+1

@rileykarson rileykarson requested review from slevenick and removed request for rileykarson August 7, 2023 20:25
@rileykarson
Copy link
Member

Rolling alt reviewer as I'll be out for a bit

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 8, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 123 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (227 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  enable_fqdn_network_policy = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2940
Passed tests 2637
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withFQDNNetworkPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withFQDNNetworkPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}
View the build log or the debug log for each test

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
@toVersus toVersus force-pushed the feat/fqdn-network-policy branch from 1d164a4 to 6f9bca1 Compare August 17, 2023 08:15
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 17, 2023
@toVersus
Copy link
Contributor Author

Gentle ping @slevenick

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 17, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 123 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (227 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  enable_fqdn_network_policy = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2962
Passed tests 2657
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Aug 28, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023
@toVersus toVersus deleted the feat/fqdn-network-policy branch August 29, 2023 00:27
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Aug 29, 2023
melinath added a commit that referenced this pull request Sep 6, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (#8520)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (#8744)

* Made breaking change detector own its own setup and build process (#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Go changelog (#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Fix acctest import specifying the beta version instead of GA (#8736)

* Cleanup deprecated folders (#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (#8761)

* Update example for google_compute_addresses data source (#8765)

* Remove myself from vacation list (#8770)

* Document database flags type change (#8769)

* Added some missing what's next links (#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (#8751)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Add workflow for membership checker unit tests (#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Key upload (#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (#8776)

* make distribution_policy_target_shape updatable (#8774)

Co-authored-by: Edward Sun <sunedward@google.com>

* feat(google_container_cluster): support fqdn network policy (#8461)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

* Redis cluster terraform support (#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <khimani@google.com>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com>
Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Yanwei Guo <yanweiguo@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: himanikh <himani.arora78@gmail.com>
Co-authored-by: Himani Khanduja <khimani@google.com>
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Sep 7, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <sunedward@google.com>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <khimani@google.com>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com>
Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Yanwei Guo <yanweiguo@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: himanikh <himani.arora78@gmail.com>
Co-authored-by: Himani Khanduja <khimani@google.com>
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Sep 7, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <sunedward@google.com>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <khimani@google.com>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com>
Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Yanwei Guo <yanweiguo@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: himanikh <himani.arora78@gmail.com>
Co-authored-by: Himani Khanduja <khimani@google.com>
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <sunedward@google.com>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <khimani@google.com>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com>
Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Yanwei Guo <yanweiguo@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: himanikh <himani.arora78@gmail.com>
Co-authored-by: Himani Khanduja <khimani@google.com>
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <sunedward@google.com>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <khimani@google.com>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com>
Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Yanwei Guo <yanweiguo@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: himanikh <himani.arora78@gmail.com>
Co-authored-by: Himani Khanduja <khimani@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[google_container_cluster] fqdn network policy setting
5 participants