-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis cluster terraform support #8567
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
Hello! I am a robot. It looks like you are a community contributor. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
mmv1/third_party/terraform/tests/resource_redis_cluster_test.go
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 302 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_redis_cluster" "primary" {
display_name = # value needed
psc_configs {
network = # value needed
}
region = # value needed
replica_count = # value needed
transit_encryption_mode = # value needed
}
|
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisCluster_redisClusterNonhaExample|TestAccRedisCluster_updateShardCount|TestAccRedisCluster_updateReplicaCount |
|
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 300 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_redis_cluster" "primary" {
psc_configs {
network = # value needed
}
}
|
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisCluster_updateShardCount|TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_redisClusterHaExample |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 300 insertions(+)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 299 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisCluster_updateShardCount|TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_redisClusterHaExample |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this resource publicly available? I'm seeing failures on 404 no such method errors, which generally mean the URL is wrong or the API is not public yet.
The visibility is restricted but the endpoint would be public available by 10/12. Meanwhile I can add the test accounts to allowlist to validate the changes. From the office hours I learnt that these are the accounts to allowlist: |
Cool, is the goal to get this to a state where we can merge it on 10/12? |
Correct! |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 299 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisCluster_redisClusterHaExample|TestAccRedisCluster_updateShardCount|TestAccRedisCluster_updateReplicaCount |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 380 insertions(+), 29 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_updateShardCount|TestAccRedisCluster_redisClusterHaExample |
Rerun these tests in REPLAYING mode to catch issues
|
mmv1/third_party/terraform/services/redis/resource_redis_cluster_test.go.erb
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 544 insertions(+), 27 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_updateShardCount |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I talked with the team about the change to ServiceConnectionPolicies being considered a breaking change. Usually we try not to make changes like this even if they're technically correct, but since the current failure mode is so severe (panic on read) it makes sense to change this.
* Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com>
* Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com>
* Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com>
* Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com>
* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (#8520) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (#8744) * Made breaking change detector own its own setup and build process (#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Go changelog (#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Fix acctest import specifying the beta version instead of GA (#8736) * Cleanup deprecated folders (#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (#8763) * Adds the synthetic monitor target type as an option for uptime checks. (#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (#8761) * Update example for google_compute_addresses data source (#8765) * Remove myself from vacation list (#8770) * Document database flags type change (#8769) * Added some missing what's next links (#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (#8751) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Add workflow for membership checker unit tests (#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Key upload (#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (#8776) * make distribution_policy_target_shape updatable (#8774) Co-authored-by: Edward Sun <sunedward@google.com> * feat(google_container_cluster): support fqdn network policy (#8461) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> * Redis cluster terraform support (#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com> Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com> Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: Yanwei Guo <yanweiguo@google.com> Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com> Co-authored-by: Edward Sun <sunedward@google.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: himanikh <himani.arora78@gmail.com> Co-authored-by: Himani Khanduja <khimani@google.com>
* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <sunedward@google.com> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com> Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com> Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: Yanwei Guo <yanweiguo@google.com> Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com> Co-authored-by: Edward Sun <sunedward@google.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: himanikh <himani.arora78@gmail.com> Co-authored-by: Himani Khanduja <khimani@google.com>
* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <sunedward@google.com> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com> Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com> Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: Yanwei Guo <yanweiguo@google.com> Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com> Co-authored-by: Edward Sun <sunedward@google.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: himanikh <himani.arora78@gmail.com> Co-authored-by: Himani Khanduja <khimani@google.com>
* Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com>
* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <sunedward@google.com> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com> Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com> Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: Yanwei Guo <yanweiguo@google.com> Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com> Co-authored-by: Edward Sun <sunedward@google.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: himanikh <himani.arora78@gmail.com> Co-authored-by: Himani Khanduja <khimani@google.com>
* Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com>
* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <sunedward@google.com> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com> Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com> Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: Yanwei Guo <yanweiguo@google.com> Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com> Co-authored-by: Edward Sun <sunedward@google.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: himanikh <himani.arora78@gmail.com> Co-authored-by: Himani Khanduja <khimani@google.com>
Supporting redis cluster - a new Cloud Memorystore Redis offering (beta)
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.