Removed MembershipRBACRoleBinding from ga provider #8776

ScottSuarez · 2023-08-25T21:24:48Z

Fix forward for #8440

https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_Google_NightlyTests_GOOGLE_PACKAGE_GKEHUB2/16141?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildProblemsSection=true&expandBuildTestsSection=true&expandBuildChangesSection=true

The change to add this resource to the GA provider is breaking as the API doesn't appear to support it at the GA level. As it has not been released yet I will remove this resource from the GA provider and cherry pick it into our 4.80.0 release branches.

=== RUN   TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample
=== PAUSE TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample
=== CONT  TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample
    vcr_utils.go:152: Step 1/2 error: Error running apply: exit status 1
        Error: Error creating MembershipRBACRoleBinding: googleapi: got HTTP response code 404 with body: <!DOCTYPE html>

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2023-08-25T21:36:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Resource google_gke_hub_membership_rbac_role_binding was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 4 insertions(+), 591 deletions(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))

melinath

LGTM assuming tests pass

modular-magician · 2023-08-25T21:48:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Resource google_gke_hub_membership_rbac_role_binding was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 11 insertions(+), 593 deletions(-))
Terraform Beta: Diff ( 2 files changed, 17 insertions(+), 5 deletions(-))

modular-magician · 2023-08-25T22:58:59Z

Tests analytics

Total tests: 2989
Passed tests 2693
Skipped tests: 296
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

…rm#8776)

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (#8520) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (#8744) * Made breaking change detector own its own setup and build process (#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Go changelog (#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Fix acctest import specifying the beta version instead of GA (#8736) * Cleanup deprecated folders (#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (#8763) * Adds the synthetic monitor target type as an option for uptime checks. (#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (#8761) * Update example for google_compute_addresses data source (#8765) * Remove myself from vacation list (#8770) * Document database flags type change (#8769) * Added some missing what's next links (#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (#8751) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Add workflow for membership checker unit tests (#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Key upload (#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (#8776) * make distribution_policy_target_shape updatable (#8774) Co-authored-by: Edward Sun <sunedward@google.com> * feat(google_container_cluster): support fqdn network policy (#8461) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> * Redis cluster terraform support (#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com> Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com> Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: Yanwei Guo <yanweiguo@google.com> Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com> Co-authored-by: Edward Sun <sunedward@google.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: himanikh <himani.arora78@gmail.com> Co-authored-by: Himani Khanduja <khimani@google.com>

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <sunedward@google.com> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com> Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com> Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: Yanwei Guo <yanweiguo@google.com> Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com> Co-authored-by: Edward Sun <sunedward@google.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: himanikh <himani.arora78@gmail.com> Co-authored-by: Himani Khanduja <khimani@google.com>

…rm#8776)

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <sunedward@google.com> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com> Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com> Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: Yanwei Guo <yanweiguo@google.com> Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com> Co-authored-by: Edward Sun <sunedward@google.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: himanikh <himani.arora78@gmail.com> Co-authored-by: Himani Khanduja <khimani@google.com>

…rm#8776)

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <sunedward@google.com> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com> Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> Co-authored-by: Ryan Oaks <ryanoaks@google.com> Co-authored-by: Zhenhua Li <zhenhuali@google.com> Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com> Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com> Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: Yanwei Guo <yanweiguo@google.com> Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com> Co-authored-by: Edward Sun <sunedward@google.com> Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com> Co-authored-by: himanikh <himani.arora78@gmail.com> Co-authored-by: Himani Khanduja <khimani@google.com>

membership_rbac_is_beta_only: && git push

16561ee

membership_rbac_is_beta_only: && git push

e5983a0

ScottSuarez added the override-breaking-change Allows a potential breaking change to be merged label Aug 25, 2023

melinath approved these changes Aug 25, 2023

View reviewed changes

ScottSuarez mentioned this pull request Aug 25, 2023

GA 4.80.0 change logs hashicorp/terraform-provider-google#15619

Merged

ScottSuarez merged commit fc9f320 into GoogleCloudPlatform:main Aug 25, 2023

This was referenced Aug 25, 2023

Removed MembershipRBACRoleBinding from ga provider hashicorp/terraform-provider-google-beta#6155

Merged

Removed MembershipRBACRoleBinding from ga provider hashicorp/terraform-provider-google#15639

Merged

nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023

Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatfo…

d41ff15

…rm#8776)

zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Aug 28, 2023

Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatfo…

8a4888e

…rm#8776)

shuyama1 mentioned this pull request Aug 28, 2023

Sync 5.0.0 with main #8785

Merged

5 tasks

nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023

Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatfo…

adbd21d

…rm#8776)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Aug 29, 2023

Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatfo…

0f23502

…rm#8776)

RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023

Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatfo…

66836ec

…rm#8776)

joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023

Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatfo…

dd11956

…rm#8776)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed MembershipRBACRoleBinding from ga provider #8776

Removed MembershipRBACRoleBinding from ga provider #8776

ScottSuarez commented Aug 25, 2023 •

edited

Loading

modular-magician commented Aug 25, 2023

melinath left a comment

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

Removed MembershipRBACRoleBinding from ga provider #8776

Removed MembershipRBACRoleBinding from ga provider #8776

Conversation

ScottSuarez commented Aug 25, 2023 • edited Loading

modular-magician commented Aug 25, 2023

Breaking Change(s) Detected

Diff report

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 25, 2023

Breaking Change(s) Detected

Diff report

modular-magician commented Aug 25, 2023

Tests analytics

ScottSuarez commented Aug 25, 2023 •

edited

Loading