-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add certificate manager trust config resource #8623
Add certificate manager trust config resource #8623
Conversation
Hello! I am a robot. It looks like you are a community contributor. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 1038 insertions(+), 2 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_certificate_manager_trust_config" "primary" {
description = # value needed
labels = # value needed
location = # value needed
name = # value needed
trust_stores {
intermediate_cas {
pem_certificate = # value needed
}
trust_anchors {
pem_certificate = # value needed
}
}
}
|
I removed the whitespaces and whiteline to pass the linter but I am a little stumped on why it believes there are no acceptance tests. |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample |
Rerun these tests in REPLAYING mode to catch issues
|
@trodge could you share the test failure for |
This is the error:
|
The missing test detector currently isn't seeing any tests because they've been moved to service packages. |
Ah that explains it, I have multiple PR's claiming fields to be missing in acceptance tests and was already curious what was going on. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 1038 insertions(+), 2 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_certificate_manager_trust_config" "primary" {
description = # value needed
labels = # value needed
location = # value needed
name = # value needed
trust_stores {
intermediate_cas {
pem_certificate = # value needed
}
trust_anchors {
pem_certificate = # value needed
}
}
}
|
I will take a look tomorrow why |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1051 insertions(+), 2 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_certificate_manager_trust_config" "primary" {
description = # value needed
labels = # value needed
location = # value needed
name = # value needed
trust_stores {
intermediate_cas {
pem_certificate = # value needed
}
trust_anchors {
pem_certificate = # value needed
}
}
}
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 1046 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample |
|
…gger.source_to_build, supporting manual, pub/sub and webhook triggers. (GoogleCloudPlatform#8544) Also fixes TestAccCloudBuildTrigger_basic_bitbucket test. Co-authored-by: Mario Machado <mariomachado@google.com>
…oogle (GoogleCloudPlatform#8526) * add scalingConfig object for google_dataproc_metastore_service * add an example of a DPMS 2 config * remove invalid value for instanceSize * WIP: Add tests for scaling_factor * changes for ga provider - removed google-beta provider - removed fields from tests that require google-beta provider (gRPC) * add exactly_one_of for instance_size and scaling_factor
…atform#8612) * Add Backupdr with Management Server resource * Fixing lint issue * Fixing Variable name * FIxing values of type and peering mode * Fixing description and example * Adding type and Peering_mode to coverage * Changing release version of provider to only beta * Changing variable name * Fixing Acceptance test and trademark
…eCloudPlatform#8378) * Generate Mmv1 test files to the service packages * Fix test-fixtures * Copy test-fixtures in service packages * Replace test-fixtures path * Fix rebasing errors * Fix function usage * Fix test TestAccBigQueryExternalDataTable_objectTable * Fix test-fixtures * Keep deprecated utility functions * Move tests * Fixing rebasing error * Move more tests to the service packages * Add back resource_resourcemanager_lien_test.go * Change package name * Fix test-fixtures * Fix the test-fixtures
…leCloudPlatform#8585) * Made reviewer assignment comment include detected reviewer type Also made it clearly state whether tests will run automatically * Temporarily made it run for core contributors * Revert "Temporarily made it run for core contributors" This reverts commit 18314a0. * Fixed formatting for non-Googler comments * gofmt * Switched back to using the embedded string for the comment template * Fixed conditions for posting new comment
…8508) * Build provider before running tests * Exit if build fails * Move pending status after build
…Y instead of deprecated INTERNAL_HTTPS_LOAD_BALANCER (GoogleCloudPlatform#8571) * Update subnetwork descriptions and tests to use REGIONAL_MANAGED_PROXY instead of deprecated INTERNAL_HTTPS_LOAD_BALANCER. * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Remove remaining references to INTERNAL_HTTPS_LOAD_BALANCER. --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
This reverts commit 63eca84.
…t resource (GoogleCloudPlatform#8555) * Added support for versionAliases field in google_secret_manager_secret resource * Removed redundant test step from the version_aliases field testcases
…oogleCloudPlatform#8629) * Add `BRANCH_NAME` parameter to projects. This will be used by the manually-configured VCS root * Update comment above where `BRANCH_NAME` is set
…#8627) Also added unit tests for labeler and backfill script
… resource (GoogleCloudPlatform#8625) * Add a new supported value to the scope field in certificate resource * Improve the naming of the examples to avoid concurrency errors while running acceptance tests --------- Co-authored-by: Hamza Hassan <hamzahassan@google.com>
* Look for test files in service packages * Remove TPG_LOCAL_PATH
…8217) * Move gcp_sweeper_test.go to the sweeper package * Change the sweeper path
…dentMapping's default value (GoogleCloudPlatform#8634)
I am going to close this PR and create a new one, I can't seem to fix the branch after rebasing it with main and the changes were relatively small so I will opt on making a new one. Sorry for the unwanted noise everyone. |
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Closes: