Sync main -> 5.0.0 feature branch

[c2thorn]

Release Note Template for Downstream PRs (will be copied)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[modular-magician]

Tests analytics

Total tests: 3099
Passed tests 2744
Skipped tests: 313
Affected tests: 42

Action taken

Found 42 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbInstance_update|TestAccAlloydbBackup_update|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteAptExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_EuropeWest8|TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference|TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsEast1|TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsCentral1LowerCase|TestAccBigQueryExternalDataTable_connectionIdDiff_UseNameReference|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeSubnetwork_subnetworkPurposePrivateNatExample|TestAccComputeInstance_NetworkAttachmentUpdate|TestAccComputeInstance_NetworkAttachment|TestAccComputeInstance_update|TestAccComputeInstance_PTRRecord|TestAccDataSourceGoogleComputeRouterNat_basic|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_withPrivateNatAndRules|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withPrivateNat|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_update|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouterNat_withNatRules|TestAccComputeRouterNat_basic|TestAccContainerCluster_withAddons|TestAccContainerNodePool_withLinuxNodeConfig|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccSecretManagerSecret_rotationPeriodUpdate|TestAccSecurityCenterFolderCustomModule|TestAccSecurityCenterProjectCustomModule|TestAccSecurityCenterOrganizationCustomModule|TestAccStorageTransferJob_eventStream|TestAccWorkstationsWorkstationConfig_serviceAccount|TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample|TestAccWorkstationsWorkstationConfigIamMemberGenerated|TestAccWorkstationsWorkstationConfig_update|TestAccWorkstationsWorkstationConfigIamBindingGenerated|TestAccWorkstationsWorkstationConfig_updateHostDetails|TestAccWorkstationsWorkstationConfigIamPolicyGenerated

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbBackup_update[Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteAptExample[Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_EuropeWest8[Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference[Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsEast1[Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsCentral1LowerCase[Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseNameReference[Debug log]
TestAccComputeSubnetwork_subnetworkPurposePrivateNatExample[Debug log]
TestAccComputeInstance_NetworkAttachmentUpdate[Debug log]
TestAccComputeInstance_NetworkAttachment[Debug log]
TestAccComputeInstance_update[Debug log]
TestAccComputeInstance_PTRRecord[Debug log]
TestAccDataSourceGoogleComputeRouterNat_basic[Debug log]
TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log]
TestAccComputeRouterNat_withPrivateNatAndRules[Debug log]
TestAccComputeRouterNat_withPortAllocationMethods[Debug log]
TestAccComputeRouterNat_withPrivateNat[Debug log]
TestAccComputeRouterNat_removeLogConfig[Debug log]
TestAccComputeRouterNat_update[Debug log]
TestAccComputeRouterNat_withNatIpsAndDrainNatIps[Debug log]
TestAccComputeRouterNat_withNatRules[Debug log]
TestAccComputeRouterNat_basic[Debug log]
TestAccContainerNodePool_withLinuxNodeConfig[Debug log]
TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample[Debug log]
TestAccSecretManagerSecret_rotationPeriodUpdate[Debug log]
TestAccSecurityCenterProjectCustomModule[Debug log]
TestAccSecurityCenterOrganizationCustomModule[Debug log]
TestAccStorageTransferJob_eventStream[Debug log]
TestAccWorkstationsWorkstationConfig_serviceAccount[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Debug log]
TestAccWorkstationsWorkstationConfig_updateHostDetails[Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupFullExample[Error message] [Debug log]
TestAccAlloydbBackup_alloydbBackupBasicExample[Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample[Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccSecurityCenterFolderCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[c2thorn]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field effective_labels within resource google_alloydb_backup was either removed or renamed - reference
• Field metadata.contents_delta_uri changed from optional to required on google_vertex_ai_index - reference
• Field terraform_labels within resource google_alloydb_backup was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 62 files changed, 5862 insertions(+), 427 deletions(-))
Terraform Beta: Diff ( 71 files changed, 9064 insertions(+), 1477 deletions(-))
TF Conversion: Diff ( 10 files changed, 993 insertions(+), 17 deletions(-))
TF OiCS: Diff ( 15 files changed, 354 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_backup (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_backup" "primary" {
  annotations  = # value needed
  display_name = # value needed
}

Resource: google_alloydb_cluster (59 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_cluster" "primary" {
  annotations = # value needed
  etag        = # value needed
}

Resource: google_alloydb_instance (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  query_insights_config {
    query_plans_per_minute  = # value needed
    query_string_length     = # value needed
    record_application_tags = # value needed
    record_client_address   = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    network_attachment = # value needed
    security_policy    = # value needed
  }
}

Resource: google_compute_instance_from_template (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    network_attachment = # value needed
    security_policy    = # value needed
  }
}

Resource: google_compute_router_nat (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_nat" "primary" {
  rules {
    action {
      source_nat_active_ranges = # value needed
      source_nat_drain_ranges  = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3099
Passed tests 2782
Skipped tests: 313
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccContainerCluster_withAddons|TestAccSecurityCenterFolderCustomModule

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccSecurityCenterFolderCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test