-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Makie.mesh
compatible with MultiMesh (GeometryBasics refactor)
#4368
Draft
ffreyer
wants to merge
28
commits into
ff/GeometryBasics_refactor
Choose a base branch
from
ff/MetaMesh_integration
base: ff/GeometryBasics_refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* show data inspector on NaN if nan_color is set * clean up * Update inspector.jl --------- Co-authored-by: Ben Arthur <bjarthur70@gmail.com>
* Use `Base.depwarn()` exclusively, and fix deprecation tests A few changes: - Use `Base.depwarn()` instead of `Base.@deprecate_binding` to avoid warnings when importing symbols. - Pass the missing `funcsym` argument to `Base.depwarn()` in `Combined()`. - Fix the deprecation tests. Most of them were actually getting skipped because `@depwarn_message` had a `return` statement, causing the entire testset to return early as soon as the passed expression was evaluated. * fixup! Use `Base.depwarn()` exclusively, and fix deprecation tests
…Org/Makie.jl into ff/GeometryBasics_refactor
* consistently clip based on voxel centers * make test more stable * update changelog
* support images with reversed axes * changelog * add reference tests * fix reverse heatmap * squash refimages and also test surface * fix typo --------- Co-authored-by: Simon <sdanisch@protonmail.com> Co-authored-by: ffreyer <frederic481994@hotmail.de>
…ding via PNGFiles
…/Makie.jl into ff/MetaMesh_integration
I need to stop using rebase... I added this as a refimg test: I think we can also use this as a example for further lighting improvements in the future, e.g. adding an ambient multiplier or adding normal maps, bump maps etc. The model is the Sponza model from https://casual-effects.com/data/, about 6MB in total, loosely licensed for non-commerical use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is test/prototype for using MetaMesh from JuliaGeometry/GeometryBasics.jl#219 to render a mesh with materials loaded with JuliaIO/MeshIO.jl#98. This is effectively a continuation of #4319.
With this branch (and the related MeshIO, ShaderAbstractions & GeometryBasics branches), using https://free3d.com/3d-model/girl-blind-703979.html:
Type of change
Checklist