-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimum required params to orders #4470
Conversation
Co-authored-by: Gustavo Antunes <gantunes@uc.cl>
* fix subtitle mapping * delete * fix pt * put setTimeout back Co-authored-by: Curtis David <Curtis.David7@gmail.com>
…#4360) Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
* Refactor Transaction into Order for fiat orders * Fix uppercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
in e14871c @rickycodes I added the id because backend sometimes is not responding with the same id parameter it was requested with (it is a bug) |
> This PR is using baserelease/5.2.0
. When that branch is merged tomain
, this should be updated to point tomain
as base.This PR makes sure the orders added to the state have the minimum required parameters to keep track of them