Fix #4157 dart enum toJson method #6111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
|
cc @ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @nickmeinhold (2019/09) @athornz (2019/12) @amondnet (2019/12) |
josh-burton
approved these changes
May 8, 2020
jimschubert
added a commit
that referenced
this pull request
May 16, 2020
* master: Update username (arun-nalla) (#6319) [typescript-axios] Implement useSingleRequestParameter option (#6288) [typescript] Remove "v4-compat" value of enumSuffix (#6308) Mark swift4 generator as deprecated (#6311) Remove @nickmeinhold from Dart technical committee (#6309) Migrate Erlang samples to use OAS 3 spec (#6297) update dart samples Improve parameter documentation (#6092) Minor improvements to `plantuml` doc generator (#6298) undo changes to petstore.yaml oas3.0 (#6299) Allow passing progress callbacks through client methods. (#6261) Create method to json (#6111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just create a toJson method for enum serialization. As you can see on: #4157 (comment) :
On the version 4.3.1 the serialize function delegate on dart convert library json.encode(). It return an error because serializing this enums because the enum is not "encodable" (is not a number, boolean, string, null, list or a map), so the encode() method looks for a toJson() on the Object passed:
So I implemented this method on the template.