Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to plantuml doc generator #6298

Merged
merged 3 commits into from
May 15, 2020
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 14, 2020

  • Minor improvements to plantuml doc generator (such as copyright note, mark as beta, use OAS 3, etc)

cc @pburls

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 added this to the 5.0.0 milestone May 14, 2020
@wing328 wing328 merged commit 62d103d into master May 15, 2020
@wing328 wing328 deleted the plantuml_improve branch May 15, 2020 01:16
@wing328
Copy link
Member Author

wing328 commented May 15, 2020

@pburls is https://twitter.com/pburls your twitter account? If yes, I'll tag you in a tweet to promote the new generator.

@pburls
Copy link
Contributor

pburls commented May 15, 2020

@pburls is https://twitter.com/pburls your twitter account? If yes, I'll tag you in a tweet to promote the new generator.

@wing328 Yes, that's me. Thanks 😊

@wing328
Copy link
Member Author

wing328 commented May 15, 2020

jimschubert added a commit that referenced this pull request May 16, 2020
* master:
  Update username (arun-nalla) (#6319)
  [typescript-axios] Implement useSingleRequestParameter option (#6288)
  [typescript] Remove "v4-compat" value of enumSuffix (#6308)
  Mark swift4 generator as deprecated (#6311)
  Remove @nickmeinhold from Dart technical committee (#6309)
  Migrate Erlang samples to use OAS 3 spec (#6297)
  update dart samples
  Improve parameter documentation (#6092)
  Minor improvements to `plantuml` doc generator (#6298)
  undo changes to petstore.yaml oas3.0 (#6299)
  Allow passing progress callbacks through client methods. (#6261)
  Create method to json (#6111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants