[typescript] Remove "v4-compat" value of enumSuffix #6308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
@amakhrov thanks for the PR. |
|
@macjohnny - done! |
jimschubert
added a commit
that referenced
this pull request
May 16, 2020
* master: Update username (arun-nalla) (#6319) [typescript-axios] Implement useSingleRequestParameter option (#6288) [typescript] Remove "v4-compat" value of enumSuffix (#6308) Mark swift4 generator as deprecated (#6311) Remove @nickmeinhold from Dart technical committee (#6309) Migrate Erlang samples to use OAS 3 spec (#6297) update dart samples Improve parameter documentation (#6092) Minor improvements to `plantuml` doc generator (#6298) undo changes to petstore.yaml oas3.0 (#6299) Allow passing progress callbacks through client methods. (#6261) Create method to json (#6111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5138 , a new
enumSuffixoption was introduced. Before that the logic for generating enum names was inconsistent across generators / different modes. So in order to keep backward compatibility, a specialv4-compatvalue for this option was introduced (and used by default) to simulate the original behavior as of pre v4.2.3 .Now, for 5.0 release we can get rid of this v4-compat mode. Consumers can still get the original
behavior by setting
enumSuffixto the value they need in their project.The new default value of
enumSuffixis"Enum".It results in minimal changes in the generated samples - most of the sample projects were already configured in a way that emited the same enum names as with the new default.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir @petejohansonxo