Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark swift4 generator as deprecated #6311

Merged
merged 2 commits into from
May 15, 2020
Merged

Mark swift4 generator as deprecated #6311

merged 2 commits into from
May 15, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 15, 2020

Mark swift4 generator as deprecated

swift4 generator will be removed in the 5.x release.

cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 added this to the 5.0.0 milestone May 15, 2020
@4brunu
Copy link
Contributor

4brunu commented May 15, 2020

Looks good to me.
But I propose that we also remove the files inside bin/ and samples/ related to Swift, Swift2 and Swift3.
Or do you prefer to do that in a separated PR?

@wing328
Copy link
Member Author

wing328 commented May 15, 2020

Or do you prefer to do that in a separated PR?

Yes.

@4brunu
Copy link
Contributor

4brunu commented May 15, 2020

So This PR looks good to me for merge.
Do you want to remove the old samples related to old versions of swift or should I do it?

@wing328
Copy link
Member Author

wing328 commented May 15, 2020

Do you want to remove the old samples related to old versions of swift or should I do it?

I'll do it later.

@wing328 wing328 merged commit 26830bf into master May 15, 2020
jimschubert added a commit that referenced this pull request May 16, 2020
* master:
  Update username (arun-nalla) (#6319)
  [typescript-axios] Implement useSingleRequestParameter option (#6288)
  [typescript] Remove "v4-compat" value of enumSuffix (#6308)
  Mark swift4 generator as deprecated (#6311)
  Remove @nickmeinhold from Dart technical committee (#6309)
  Migrate Erlang samples to use OAS 3 spec (#6297)
  update dart samples
  Improve parameter documentation (#6092)
  Minor improvements to `plantuml` doc generator (#6298)
  undo changes to petstore.yaml oas3.0 (#6299)
  Allow passing progress callbacks through client methods. (#6261)
  Create method to json (#6111)
@wing328 wing328 deleted the swift4-deprecated branch May 26, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants