Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Elements of "Personal Access Tokens" section out of alignment and unusable on very small screens #17129

Merged
merged 3 commits into from
May 20, 2020

Conversation

Nikhil713
Copy link
Contributor

Closes #17003

Desktop View:

PAT_Desktop

Mobile View:

PAT_Mobile

@Nikhil713 Nikhil713 force-pushed the personalaccesstoken branch from adbdc17 to 560ac74 Compare April 2, 2020 08:57
@ashwaniYDV
Copy link
Contributor

ashwaniYDV commented Apr 2, 2020

hi @Nikhil713
Can you please exclude the package-lock.json file :)
Thanks

@Nikhil713 Nikhil713 force-pushed the personalaccesstoken branch from d251f47 to 9e961f4 Compare April 3, 2020 06:09
@Nikhil713
Copy link
Contributor Author

@ashwaniYDV I have corrected the mistake. Thanks for pointing it out :)

@engelgabriel engelgabriel requested a review from tassoevan April 4, 2020 14:58
@engelgabriel engelgabriel added this to the 3.1.0 milestone Apr 4, 2020
@engelgabriel engelgabriel modified the milestones: 3.1.0, 3.2.0 Apr 20, 2020
@engelgabriel
Copy link
Member

@tassoevan is this being refactored on the new ReactJS UI? Or should we review and merge this?

@rodrigok rodrigok changed the title [FIX] UI of Personal Access Token section [FIX] Elements of "Personal Access Tokens" section out of alignment and unusable on very small screens May 20, 2020
@rodrigok rodrigok merged commit d1f2f22 into RocketChat:develop May 20, 2020
ggazzo added a commit that referenced this pull request May 21, 2020
…ession/status-color

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Remove index files from action-links, accounts and assets (#17607)
  [FIX] Remove a non working setting "Notification Duration" (#15737)
  Update Apps-Engine version (#17706)
  Regression: Click to join button not working (#17705)
  [IMPROVE] Always shows the exact match first on user's and room's autocomplete for mentions and on sidebar search (#16394)
  [NEW] API endpoint to fetch Omnichannel's room transfer history (#17694)
  Fix typo "You aren't part of any channel yet" (#17498)
  [IMPROVE] Display status information in the Omnichannel Agents list (#17701)
  [NEW] Option to remove users from RocketChat if not found in Crowd (#17619)
  [FIX] Elements of  "Personal Access Tokens" section out of alignment and unusable on very small screens (#17129)
  Regression: Integrations edit/history crashing (#17702)
  [FIX] Allow owners to react inside broadcast channels (#17687)
  Regression: User edit form missing fields (#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (#17522)
  Update Helper.js (#17700)
  [FIX] UI KIT Modal Width (#17697)
  Update Contributing Guide (#17653)
ggazzo added a commit to ritwizsinha/Rocket.Chat that referenced this pull request May 21, 2020
…6537-ritwizsinha-Issue#16499

* 'develop' of github.com:RocketChat/Rocket.Chat: (428 commits)
  Regression: Status presence  color (RocketChat#17707)
  [IMPROVE] Remove index files from action-links, accounts and assets (RocketChat#17607)
  [FIX] Remove a non working setting "Notification Duration" (RocketChat#15737)
  Update Apps-Engine version (RocketChat#17706)
  Regression: Click to join button not working (RocketChat#17705)
  [IMPROVE] Always shows the exact match first on user's and room's autocomplete for mentions and on sidebar search (RocketChat#16394)
  [NEW] API endpoint to fetch Omnichannel's room transfer history (RocketChat#17694)
  Fix typo "You aren't part of any channel yet" (RocketChat#17498)
  [IMPROVE] Display status information in the Omnichannel Agents list (RocketChat#17701)
  [NEW] Option to remove users from RocketChat if not found in Crowd (RocketChat#17619)
  [FIX] Elements of  "Personal Access Tokens" section out of alignment and unusable on very small screens (RocketChat#17129)
  Regression: Integrations edit/history crashing (RocketChat#17702)
  [FIX] Allow owners to react inside broadcast channels (RocketChat#17687)
  Regression: User edit form missing fields (RocketChat#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (RocketChat#17522)
  Update Helper.js (RocketChat#17700)
  [FIX] UI KIT Modal Width (RocketChat#17697)
  Update Contributing Guide (RocketChat#17653)
  LingoHub based on develop (RocketChat#17693)
  [NEW] Added custom fields to Add/Edit user (RocketChat#17681)
  ...
This was referenced May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI of Personal Access Token section
5 participants