Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contributing Guide #17653

Merged
merged 5 commits into from
May 20, 2020
Merged

Update Contributing Guide #17653

merged 5 commits into from
May 20, 2020

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented May 14, 2020 •
edited
Loading

Proposed changes

  • Improve our current contributing guide, there are a lot of out of date info.
  • Add new info about the new technologies and standards.
  • Add standards for PRs
  • Add extra code rules

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@rodrigok rodrigok marked this pull request as draft May 14, 2020 16:03
@luciafallavena-zz
Copy link

Hi @rodrigok!

Is it possible to place something like this in the guide?

**There are many ways to contribute to Rocket.Chat even if you're not technical or a developer:

✔email us at marketing@rocket.chat to tell us how much you love the project
✔or write about us in your blogs
✔or fixing some small typos in our documentation
✔or become our GitHub sponsor
✔or tell others about us and help us spread the word

Every bit of contribution is appreciated 🙂 thank you!**

Thanks!

Sing-Li
Sing-Li reviewed May 16, 2020
View reviewed changes
Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPER COOL !!!! While I don't necessarily agree with all technical bits, this will NO QUESTION greatly enhance the contributors' experience and even our relationship with technical community members. THANKS!!!!

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@rodrigok
Copy link
Member Author

SUPER COOL !!!! While I don't necessarily agree with all technical bits, this will NO QUESTION greatly enhance the contributors' experience and even our relationship with technical community members. THANKS!!!!

Thanks @Sing-Li, I've just applied all of your suggestions.

@rodrigok rodrigok marked this pull request as ready for review May 19, 2020 11:50
@rodrigok rodrigok added this to the 3.3.0 milestone May 19, 2020
@sampaiodiego sampaiodiego merged commit dbcaacc into develop May 20, 2020
@sampaiodiego sampaiodiego deleted the Update-Contributing-Guide branch May 20, 2020 14:49
ggazzo added a commit that referenced this pull request May 21, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into regr…
3a81933 
…ession/status-color

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Remove index files from action-links, accounts and assets (#17607)
  [FIX] Remove a non working setting "Notification Duration" (#15737)
  Update Apps-Engine version (#17706)
  Regression: Click to join button not working (#17705)
  [IMPROVE] Always shows the exact match first on user's and room's autocomplete for mentions and on sidebar search (#16394)
  [NEW] API endpoint to fetch Omnichannel's room transfer history (#17694)
  Fix typo "You aren't part of any channel yet" (#17498)
  [IMPROVE] Display status information in the Omnichannel Agents list (#17701)
  [NEW] Option to remove users from RocketChat if not found in Crowd (#17619)
  [FIX] Elements of  "Personal Access Tokens" section out of alignment and unusable on very small screens (#17129)
  Regression: Integrations edit/history crashing (#17702)
  [FIX] Allow owners to react inside broadcast channels (#17687)
  Regression: User edit form missing fields (#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (#17522)
  Update Helper.js (#17700)
  [FIX] UI KIT Modal Width (#17697)
  Update Contributing Guide (#17653)
ggazzo added a commit to ritwizsinha/Rocket.Chat that referenced this pull request May 21, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into pr/1…
0ab7301 
…6537-ritwizsinha-Issue#16499

* 'develop' of github.com:RocketChat/Rocket.Chat: (428 commits)
  Regression: Status presence  color (RocketChat#17707)
  [IMPROVE] Remove index files from action-links, accounts and assets (RocketChat#17607)
  [FIX] Remove a non working setting "Notification Duration" (RocketChat#15737)
  Update Apps-Engine version (RocketChat#17706)
  Regression: Click to join button not working (RocketChat#17705)
  [IMPROVE] Always shows the exact match first on user's and room's autocomplete for mentions and on sidebar search (RocketChat#16394)
  [NEW] API endpoint to fetch Omnichannel's room transfer history (RocketChat#17694)
  Fix typo "You aren't part of any channel yet" (RocketChat#17498)
  [IMPROVE] Display status information in the Omnichannel Agents list (RocketChat#17701)
  [NEW] Option to remove users from RocketChat if not found in Crowd (RocketChat#17619)
  [FIX] Elements of  "Personal Access Tokens" section out of alignment and unusable on very small screens (RocketChat#17129)
  Regression: Integrations edit/history crashing (RocketChat#17702)
  [FIX] Allow owners to react inside broadcast channels (RocketChat#17687)
  Regression: User edit form missing fields (RocketChat#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (RocketChat#17522)
  Update Helper.js (RocketChat#17700)
  [FIX] UI KIT Modal Width (RocketChat#17697)
  Update Contributing Guide (RocketChat#17653)
  LingoHub based on develop (RocketChat#17693)
  [NEW] Added custom fields to Add/Edit user (RocketChat#17681)
  ...
gabriellsh added a commit that referenced this pull request May 22, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
7fc4af0 
…apps_rewrite

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Integrations edit/history crashing (#17702)
  [FIX] Allow owners to react inside broadcast channels (#17687)
  Regression: User edit form missing fields (#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (#17522)
  Update Helper.js (#17700)
  [FIX] UI KIT Modal Width (#17697)
  Update Contributing Guide (#17653)
  LingoHub based on develop (#17693)
  [NEW] Added custom fields to Add/Edit user (#17681)
  Regression: Fix incorrect imports of the Apps-Engine (#17695)
  Improve: Remove uncessary RegExp query by email (#17654)
  [NEW] [Apps-Engine] New Room events (#17487)
  [IMPROVE] Add env var to configure Chatpal URL and remove it from beta (#16665)
  Regression: Set retryWrites=false as default Mongo options (#17683)
This was referenced May 28, 2020
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@Sing-Li Sing-Li Sing-Li approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigok @luciafallavena-zz @Sing-Li @sampaiodiego