Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Default filters on Omnichannel Current Chats screen not showing on first load #17522

Merged
merged 1 commit into from
May 20, 2020

Conversation

renatobecker
Copy link
Contributor

The default filters on the Omnichannel Current Chats template weren't working properly because the values were being loaded on the onCreated instead of the onRendered event, but the components/selectors may not exist until the creating process is completed.

@renatobecker renatobecker added this to the 3.3.0 milestone May 4, 2020
@renatobecker renatobecker requested review from rodrigok and ggazzo May 4, 2020 14:44
@sampaiodiego sampaiodiego changed the title [FIX] Default filters not working on the Omnichannel Current Chats template [FIX] Default filters on Omnichannel Current Chats screen not showing on first load May 20, 2020
@sampaiodiego sampaiodiego merged commit c8fa37c into develop May 20, 2020
@sampaiodiego sampaiodiego deleted the omnichannel/fix-current-chats-default-filters branch May 20, 2020 16:46
ggazzo added a commit that referenced this pull request May 21, 2020
…ession/status-color

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Remove index files from action-links, accounts and assets (#17607)
  [FIX] Remove a non working setting "Notification Duration" (#15737)
  Update Apps-Engine version (#17706)
  Regression: Click to join button not working (#17705)
  [IMPROVE] Always shows the exact match first on user's and room's autocomplete for mentions and on sidebar search (#16394)
  [NEW] API endpoint to fetch Omnichannel's room transfer history (#17694)
  Fix typo "You aren't part of any channel yet" (#17498)
  [IMPROVE] Display status information in the Omnichannel Agents list (#17701)
  [NEW] Option to remove users from RocketChat if not found in Crowd (#17619)
  [FIX] Elements of  "Personal Access Tokens" section out of alignment and unusable on very small screens (#17129)
  Regression: Integrations edit/history crashing (#17702)
  [FIX] Allow owners to react inside broadcast channels (#17687)
  Regression: User edit form missing fields (#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (#17522)
  Update Helper.js (#17700)
  [FIX] UI KIT Modal Width (#17697)
  Update Contributing Guide (#17653)
ggazzo added a commit to ritwizsinha/Rocket.Chat that referenced this pull request May 21, 2020
…6537-ritwizsinha-Issue#16499

* 'develop' of github.com:RocketChat/Rocket.Chat: (428 commits)
  Regression: Status presence  color (RocketChat#17707)
  [IMPROVE] Remove index files from action-links, accounts and assets (RocketChat#17607)
  [FIX] Remove a non working setting "Notification Duration" (RocketChat#15737)
  Update Apps-Engine version (RocketChat#17706)
  Regression: Click to join button not working (RocketChat#17705)
  [IMPROVE] Always shows the exact match first on user's and room's autocomplete for mentions and on sidebar search (RocketChat#16394)
  [NEW] API endpoint to fetch Omnichannel's room transfer history (RocketChat#17694)
  Fix typo "You aren't part of any channel yet" (RocketChat#17498)
  [IMPROVE] Display status information in the Omnichannel Agents list (RocketChat#17701)
  [NEW] Option to remove users from RocketChat if not found in Crowd (RocketChat#17619)
  [FIX] Elements of  "Personal Access Tokens" section out of alignment and unusable on very small screens (RocketChat#17129)
  Regression: Integrations edit/history crashing (RocketChat#17702)
  [FIX] Allow owners to react inside broadcast channels (RocketChat#17687)
  Regression: User edit form missing fields (RocketChat#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (RocketChat#17522)
  Update Helper.js (RocketChat#17700)
  [FIX] UI KIT Modal Width (RocketChat#17697)
  Update Contributing Guide (RocketChat#17653)
  LingoHub based on develop (RocketChat#17693)
  [NEW] Added custom fields to Add/Edit user (RocketChat#17681)
  ...
gabriellsh added a commit that referenced this pull request May 22, 2020
…apps_rewrite

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Integrations edit/history crashing (#17702)
  [FIX] Allow owners to react inside broadcast channels (#17687)
  Regression: User edit form missing fields (#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (#17522)
  Update Helper.js (#17700)
  [FIX] UI KIT Modal Width (#17697)
  Update Contributing Guide (#17653)
  LingoHub based on develop (#17693)
  [NEW] Added custom fields to Add/Edit user (#17681)
  Regression: Fix incorrect imports of the Apps-Engine (#17695)
  Improve: Remove uncessary RegExp query by email (#17654)
  [NEW] [Apps-Engine] New Room events (#17487)
  [IMPROVE] Add env var to configure Chatpal URL and remove it from beta (#16665)
  Regression: Set retryWrites=false as default Mongo options (#17683)
This was referenced May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants