Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Allow owners to react inside broadcast channels #17687

Merged
merged 6 commits into from
May 20, 2020

Conversation

dudizilla
Copy link
Contributor

@dudizilla dudizilla commented May 19, 2020

Proposed changes

Issue(s)

closes #11819
closes #17588
closes #16856

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@dudizilla dudizilla changed the title REsolving broadcast bugs [FIX] Resolving broadcast bugs May 19, 2020
@luixxiul
Copy link

This too? #16856

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request introduces 1 alert when merging 0d1031c into bbb3133 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@dudizilla dudizilla changed the title [FIX] Resolving broadcast bugs [FIX] Allow owners to react inside broadcast channels May 20, 2020
@dudizilla dudizilla marked this pull request as ready for review May 20, 2020 01:35
@ggazzo ggazzo added this to the 3.3.0 milestone May 20, 2020
@ggazzo ggazzo self-requested a review May 20, 2020 02:47
@ggazzo ggazzo merged commit 6d6aae2 into develop May 20, 2020
@ggazzo ggazzo deleted the reactions-in-broadcast branch May 20, 2020 17:07
ggazzo added a commit that referenced this pull request May 21, 2020
…ession/status-color

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Remove index files from action-links, accounts and assets (#17607)
  [FIX] Remove a non working setting "Notification Duration" (#15737)
  Update Apps-Engine version (#17706)
  Regression: Click to join button not working (#17705)
  [IMPROVE] Always shows the exact match first on user's and room's autocomplete for mentions and on sidebar search (#16394)
  [NEW] API endpoint to fetch Omnichannel's room transfer history (#17694)
  Fix typo "You aren't part of any channel yet" (#17498)
  [IMPROVE] Display status information in the Omnichannel Agents list (#17701)
  [NEW] Option to remove users from RocketChat if not found in Crowd (#17619)
  [FIX] Elements of  "Personal Access Tokens" section out of alignment and unusable on very small screens (#17129)
  Regression: Integrations edit/history crashing (#17702)
  [FIX] Allow owners to react inside broadcast channels (#17687)
  Regression: User edit form missing fields (#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (#17522)
  Update Helper.js (#17700)
  [FIX] UI KIT Modal Width (#17697)
  Update Contributing Guide (#17653)
ggazzo added a commit to ritwizsinha/Rocket.Chat that referenced this pull request May 21, 2020
…6537-ritwizsinha-Issue#16499

* 'develop' of github.com:RocketChat/Rocket.Chat: (428 commits)
  Regression: Status presence  color (RocketChat#17707)
  [IMPROVE] Remove index files from action-links, accounts and assets (RocketChat#17607)
  [FIX] Remove a non working setting "Notification Duration" (RocketChat#15737)
  Update Apps-Engine version (RocketChat#17706)
  Regression: Click to join button not working (RocketChat#17705)
  [IMPROVE] Always shows the exact match first on user's and room's autocomplete for mentions and on sidebar search (RocketChat#16394)
  [NEW] API endpoint to fetch Omnichannel's room transfer history (RocketChat#17694)
  Fix typo "You aren't part of any channel yet" (RocketChat#17498)
  [IMPROVE] Display status information in the Omnichannel Agents list (RocketChat#17701)
  [NEW] Option to remove users from RocketChat if not found in Crowd (RocketChat#17619)
  [FIX] Elements of  "Personal Access Tokens" section out of alignment and unusable on very small screens (RocketChat#17129)
  Regression: Integrations edit/history crashing (RocketChat#17702)
  [FIX] Allow owners to react inside broadcast channels (RocketChat#17687)
  Regression: User edit form missing fields (RocketChat#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (RocketChat#17522)
  Update Helper.js (RocketChat#17700)
  [FIX] UI KIT Modal Width (RocketChat#17697)
  Update Contributing Guide (RocketChat#17653)
  LingoHub based on develop (RocketChat#17693)
  [NEW] Added custom fields to Add/Edit user (RocketChat#17681)
  ...
gabriellsh added a commit that referenced this pull request May 22, 2020
…apps_rewrite

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Integrations edit/history crashing (#17702)
  [FIX] Allow owners to react inside broadcast channels (#17687)
  Regression: User edit form missing fields (#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (#17522)
  Update Helper.js (#17700)
  [FIX] UI KIT Modal Width (#17697)
  Update Contributing Guide (#17653)
  LingoHub based on develop (#17693)
  [NEW] Added custom fields to Add/Edit user (#17681)
  Regression: Fix incorrect imports of the Apps-Engine (#17695)
  Improve: Remove uncessary RegExp query by email (#17654)
  [NEW] [Apps-Engine] New Room events (#17487)
  [IMPROVE] Add env var to configure Chatpal URL and remove it from beta (#16665)
  Regression: Set retryWrites=false as default Mongo options (#17683)
This was referenced May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants