v0.2.6
EchelleCCFs v0.2.6
- Minor bug fixes from code review
- Documentation updates
Closed issues:
calc_ccf_template(ccfs, ccf_vars)
not using normed values ifassume_normalized=false
(#31)covar_out
argument not used in function (besides asserts); should replace all instances ofccf_sample_covar
withcovar_out
(#33)- empty functors/constructors? (#36)
in
argument of typeMeasureRvFromCCFTemplateNonDiagCovar
does not havefrac_of_width_to_fit
andmeasure_width_at_frac_depth
fields (#48)- dangerous assertion? (#53)
- (not an issue) (#55)
- check if
calc_length_ccf_v_grid
is doing what is intended (see Issue #52) (#56) - function sometimes uses
length(plan.line_list)
and sometimes useslength(plan.line_list.λ)
(#59) - check if documentation for struct is accurate (#62)
num_chunks
not defined in function (#66)- default value for
plan_for_chunk
optional argument does not match type (#72) num_chunks(clt)
should be the same asnorders
(#74)- assert on an array of values (#80)
v_offset
andσ_sqrt2
should be fields ofm
(#85)- unknown type
FuncT
in struct (#86) - if intended to index
x
in steps of 2i, should check thatlength(ifo.x) = 2*length(info.gw)
? (#88) - check if
n1
= 0/1 for even/odd or vice versa (#89) - should
σ_new
be multiplied bysqrt(2)
or is it already included? (#91) - check if
psf_width
is correct (or address TODOs)? (#94) - early return to save time? Also the type of the output would be different ('Nothing') (#95)
Merged pull requests: