Skip to content

v0.2.6

Compare
Choose a tag to compare
@github-actions github-actions released this 05 Jul 15:12
· 22 commits to main since this release
57f86dc

EchelleCCFs v0.2.6

Diff since v0.2.5

  • Minor bug fixes from code review
  • Documentation updates

Closed issues:

  • calc_ccf_template(ccfs, ccf_vars) not using normed values if assume_normalized=false (#31)
  • covar_out argument not used in function (besides asserts); should replace all instances of ccf_sample_covar with covar_out (#33)
  • empty functors/constructors? (#36)
  • in argument of type MeasureRvFromCCFTemplateNonDiagCovar does not have frac_of_width_to_fit and measure_width_at_frac_depth fields (#48)
  • dangerous assertion? (#53)
  • (not an issue) (#55)
  • check if calc_length_ccf_v_grid is doing what is intended (see Issue #52) (#56)
  • function sometimes uses length(plan.line_list) and sometimes uses length(plan.line_list.λ) (#59)
  • check if documentation for struct is accurate (#62)
  • num_chunks not defined in function (#66)
  • default value for plan_for_chunk optional argument does not match type (#72)
  • num_chunks(clt) should be the same as norders (#74)
  • assert on an array of values (#80)
  • v_offset and σ_sqrt2 should be fields of m (#85)
  • unknown type FuncT in struct (#86)
  • if intended to index x in steps of 2i, should check that length(ifo.x) = 2*length(info.gw)? (#88)
  • check if n1 = 0/1 for even/odd or vice versa (#89)
  • should σ_new be multiplied by sqrt(2) or is it already included? (#91)
  • check if psf_width is correct (or address TODOs)? (#94)
  • early return to save time? Also the type of the output would be different ('Nothing') (#95)

Merged pull requests:

  • Fix typos and indentation for all I could find in src/calc_rv/ (#49) (@hematthi)