Update WordPress trunk to Gutenberg 5.3 #14532

window.getSelection() can return an empty range, causing getRangeAt() to fail

* Improve publish panel landmark and button position. * Use outline for navigate regions focus style. * Avoid conflict with publish panel animation. * Make the outline animation expand inwards. * CSS lint after rebase. * Rebuild outline animation. * Try negative z-indexes. * Change animation timing to 0.1s.

* Add new package for editor configuration, initially containing just feature flags Rework build commands to use correct NODE_ENV for feature flags * Revert "Rework build commands to use correct NODE_ENV for feature flags" This reverts commit 4cb0a39. Revert "Add new package for editor configuration, initially containing just feature flags" This reverts commit 0c21fc2. * Switch to using webpack define plugin to inject a global GUTENBERG_PHASE variable * Iterate: use window.GUTENBERG_PHASE to avoid thrown errors from an undefined global * Add custom eslint rule for usage of GUTENBERG_PHASE * Disable new eslint rule when used in webpack config * Add readme * Include phase 2 features in e2e tests * Allow use of GUTENBERG_PHASE in a ternary and update documentation. * Add links to docs * Minor docs changes * Switch from window.GUTENBERG_PHASE to process.env.GUTENBERG_PHASE * Update docs for feature flags. Move `Basic Use` section higher up, and simplify a sentence * Ensure GUTENBERG_PHASE environment variable is available for webpack * Ensure GUTENBERG_PHASE is a number * Ensure GUTENBERG_PHASE is set in unit tests * Use <rootDir> in jest config * switch to using package.json config to define the value of GUTENBERG_PHASE * Sort custom lint rules alphabetically * Add comment about GUTENBERG_PHASE * Update jest config for GUTENBERG_PHASE * Add webpack as dependency to main package.json

* RichText: don't set selection during selectionchange * Add e2e test

The block editor supports an inverted UI to ensure contrast in themes that register themselves as having dark backgrounds (see https://wordpress.org/gutenberg/handbook/designers-developers/developers/themes/theme-support/#dark-backgrounds). What this mode does, is invert the UI wherever it can, so dark gray borders are light gray on black backgrounds, and the mover icons are white instead of black. But they shouldn't be in nested contexts, because in nested contexts the movers have a white background. This PR fixes that.

* RichText: Fix browser formatting buttons * Simplify * componentDidMount instead of componentWillMount

* Basic functionality * Only update width on submit * Fix styles * Push a little polish * Select objects when clicked * Fix getDerivedStateFromProps * Reselect image after update * Move PositionedAtSelection * Export PositionAtSelection in same way we export other @wordpress/components

* Plugin: Extract block editor styles replacement as filter * Plugin: Override default styles by exact file contents match * Plugin: Fix editor styles prepend behavior

* Decode URL encoding slug in sidebar permalink * Decode URL encoding slug in sidebar permalink pt.2. * Decode URL encoding slug in sidebar permalink pt.3. * Decode URL encoding slug in sidebar permalink pt.4.

* Have a image placeholder while image size is being calculated. * Move placeholder image to image block code.

* Allow progress call to update the thumbnail image. * If we already have a subscription don’t go it again. * Fix bottomsheet event removal.

* onReplace: select the last block * Update tests * Add second test to cover cases of REPLACE_BLOCKS

* Store current selection in RichText state * Make native RichText use format-library This is a work in progress. Sometimes it works, sometimes it doesn't, I haven't figured out the right way to wire the RichText structure into Aztec * Fix bad merge * Don't use applyRecord for now * Missing newlines * Do not change lastContent on formatChange, let the component rerender and update record. Also minor cleanup * Make sure the component rerenders when isSelected changes so FormatToolbar is removed * Make a simple version of Link that displays on mobile * Rerender on selection change to update record * Make it update onFormatChange when url changes * Cleanup changes in Heading and Paragraph * Remove unnecessary components and styles added while testing * Improve link editing UI * Fix adding a new url without a selection * Fix editing the text part of the url * Fill modal URL to current value * Pressing Remove dismisses the popup. Improve styles * Bring back multilineTag prop * Remove unused param in shouldComponentUpdate * Remove withBlockEditContext for now, it will need a better refactor to properly deal with focus from Aztec * Temporary fix for whitespace in HTML, will need to be addressed later * Make sure end is always greater than start for the text selection * Remove unsupported css property * Disable autoCapitalize and autoCorrect for URLInput * Fix lint errors in mobile and in rnmobile/rich-text-formats * Use a template string to generate html for Aztec in RichText * Preprocess the HTML value before sending it to Aztec, removing whitespaces in the process * Use custom button instead of native provided by react-native * Add some padding to our custom button * Send active formats to RCTAztecView so we can type new words in a format * Handle multiple formats with format placeholder * Cleanup applyFormat * Make applyFormat support applying multiple formats at once * Keep formatting when onSelectionChange is emitted without changes * Keep the same order of formats * Prevent inserting anything other that a formatting element from the link modal * Make sure wrapping tags returned by aztec are removed so it's not added to formats * Improve styling of the modal * Make sure we don't pass undefined values in activeFormats * Update formatPlaceholder when user decides to unselect a format in an existing formatted text * Update props.value on format change * Force update native view onFormatChange by not setting this.lastContent * Handle inserting a link * Fix updating format properties * Expand link selection automatically so we can edit a link without selecting it explicitly * Force an aztec text refresh on format change so we make sure the active formats are in sync * Add comment and make the code more consistent for debugging * Make sure we don't use format ref inside the placeholder formats * Make sure we don't use format ref inside the placeholder formats * Do not try to call valueToFormat on format change without selection * Fix editing link url * Add the ability to remove a link without selection * Do not remove trailing whitespace characters * Unescape spaces coming from Aztec * Fix code styling issues * Pick the formats of the first char when in text start * Fix lint errors * RichText value may be undefined * Update lastEventCount on enter and selection changes * Update ModalLinkUI to avoid the keyboard * Lint fixes

* Mobile BottomSheet: Added the posibility of selecting the cell separator style. * Mobile BottomSheet: Increased space between top and table * Mobile BottomSheet: Truncating long values at the middle of the string. * Fix lint issues * Fix syntax error to pass CI * Fix lint issue * Mobile Picker: Tweak Android styles. * Mobile BottomSheet: Simplified Android cell styling. * Mobile: Fix swipe to dismiss on BottomSheet * Fix lint issues * Mobile BottomSheet: Fixes sensibility of pan vs tap gestures on swipe to dismiss. * Fix lint issues * Fixed failed tests * Mobile BottomSheet cell: Removed unnecessary variable init. * Fixed set state after component is unmounted * Revert "Fixed set state after component is unmounted" This reverts commit 787df73.

Remove an unnecessary word from the readme.

…13880)

…is deprecated (#12757) * Use attributes as parsed when determining a block migration, not the attributes from the failed created block * Updated tests with new migratedBlocks signature and add new test to cover deprecated default use case * Fix typo with attribute type in test

* Mobile BottomSheet: Adding max-width and centering. * Mobile BottomSheet: Fixed drag indicator width. * Mobile BottomSheet: Fix max-width on Android. * Mobile BottomSheet: Added children container. * Mobile BottomSheet: Added function to get bottom-sheet width * Fix lint issues

* Refactor raw-handler and paste-handler into their own files * Add undefined and null checks for jsdom-jscore node methods/properties * Implement createRecord method for converting native content to RichText * Refactor splitContent and onEnter for common interface with onPaste * Begin implementing onPaste for plain and styled text * Fix some lint errors and some invalid references. * Add undefined check for jsdom-jscore node in phrasing-content-reducer * Add onReplace method to ParagraphEdit * Refactor raw-handler back into index.js * Remove unused parameters from RichText create method

* Fix column moved in itself error * Update packages/editor/src/components/block-drop-zone/index.js Co-Authored-By: Naerriel <naerriel@gmail.com>

* Update button block description by using wording about link. * Add keyword: link. * Update index.js

… picker. (#13708) * Change custom color control into a text link. Changes the custom color control into a text link instead of a multi-colored palette icon. Updates styles to properly line it up to the left of the clear button. * Add missing top/bottom padding to color picker controls. * Update snapshot * Remove unnecessary tooltip on the color picker button. * Update snapshot. * Update test + snapshot * Remove unnecessary type declaration for the toggle button.

* Match height of font range control with the size select. This also aligns the range up/down controls to the right side of the input. * update font range control inline docs * update with master * bring up to date with master branch * wider range number controls to account for OS specific input spinners. * Use the same height as our other number inputs. * wider number inputs to account for OS specific spinners. * Revert "wider range number controls to account for OS specific input spinners." This reverts commit d26c659. * make number input styles more consistent across components * refresh with upstream * smaller changes

* Data: Fix inaccurate persistence plugin documentation * Data: Leave unpersisted keys intact in initial persisted state * Data: Add initialState option for namespace stores * Data: Use initialState option for persistence restore * Data: Deeply merge into persistence default value * Data: Remove outdated code comment for effecting initialState * Data: Persistence: Defer to default initial state in object-like mismatch * Data: Persistence: Revert to persisted value as preferred Merge if possible when both it and the default initial state are objects

) * Block Editor: Reimplement removeBlocks previous selection as control * Editor: Reimplement select previous/next as independent controls * Refactor controls to actions * Editor: Pass initialPosition in selectPreviousBlock * Editor: Rename storeKey to storeName

* RichText: only ignore input types that insert HTML * Mark RichTextInputEvent as unstable * Use Set

* Fix character newlines in pre * Add e2e test

* Use correct font and padding for block placeholder. * Match text for placeholder for paragraph to block placeholder. * Make placeholder text simpler. * Make min height smaller to make component entered. * Fix default placeholder color. * Use variable for color. * Change minimum height of text blocks. * Remove top padding on the appender.

* Add ESNext syntax to meta block tutorial * Applied WordPress code styles to the examples * Apply suggestions from code review Co-Authored-By: mkaz <marcus@mkaz.com>

) * Added a snippet for observing the browser when running e2e tests

…#13814) * New build-config package with webpack config. Pull the Gutenberg webpack config into a package so it can be re-used for block/extension development. * Require new build-config package. * Dynamically handle WP externals with a function. Use code from WP Calypso for handling WP externals so we don't have to have the actual list of packages accessible in our webpack configuration. * Use webpack config from build-config package. * Require build-config package. * Adjust file refs for WP packages. * Move main gutenberg entry definition and webpack copy plugin out of build-config. * Add react-dev-utils for formatting webpack compiler messages. * Implement build script using webpack config from build-config. * Adjust output path so build goes to working directory. * Update package name to webpack-config * Apply more tweaks to the way webpack config package is structured * Update the way externals are handled * Add default values for entry and output * Move shared webpack config under @wordpress/scripts package * Improve the way how loaders are handled * Replace GUTENBERG with WP in webpack config env variables Co-Authored-By: gziolo <grzegorz@gziolo.pl> * Bring back feature flag to webpack config accidentally removed during merge * Add missing dev dependencies for the packages used in webpack config * Fix the list of excluded folders for babel-loader

* Use globals instead of imports * Update docs/designers-developers/developers/tutorials/metabox/meta-block-3-add.md Co-Authored-By: nosolosw <nosolosw@users.noreply.github.com> * Update docs/designers-developers/developers/tutorials/metabox/meta-block-3-add.md Co-Authored-By: nosolosw <nosolosw@users.noreply.github.com>

* Use chevron instead of ellipsis in url input field options. * Mimic toolbar icon styles for the icons in the URL popover. * Add a left divider before the URL settings toggle * Even up the spacing in the settings panel. * Add periods to code comments. * Update snapshot

* Upgrade React to 16.8.2 * Update package-lock.json file * Expose React Hooks

This reverts commit 6f88bec.

As noted in #13973, this stylesheet uses a relatively non-standard SCSS method of nesting some classnames. For instance: `.editor-url-popover { &__settings-toggle { ... } }`. ... instead of: `.editor-url-popover__settings-toggle { ... }` This is different from the conventions used elsewhere in Gutenberg, and is a bit more difficult to follow for that reason. This commit un-nests those styles, and should have no effect on the compiled CSS.

* RichText: warn when using inline container * Add env check * Update documentation

* Bump plugin version to 5.1.0-rc.1 * RichText: only ignore input types that insert HTML (#13914) * RichText: only ignore input types that insert HTML * Mark RichTextInputEvent as unstable * Use Set * Bump plugin version to 5.1.0 * Deprecate RichTextInputEvent on mobile too (#13975) * The undelying RichText component implementation has changed the parameters returned onChange, and we forgot to update the PostTitle component (#13967) * Fixes wrong state comparison (#13987) Upload media progress bar is missing while media is uploading new * Re-add rootTagsToEliminate prop (#14006) * [Mobile]Update PostTitle to apply borders when it is focused (#13970) * Trigger onFocusStatusChange from PostTitle * Fix lint issue * Update post title shadow mechanism Also open inner ref so that focus state can be updated when focus is made programmatically * Update props * Update onRef as ref * Update title padding&margin * Mobile: Rename ref to innerRef on PostTitle (#14024) * Fixes a red screen in mobile. (#14011) * Change background color on image placeholder block (#14033) * Changed upload media icon color * Changed media placeholder background color * Fix post title native syntax (#14041) * Fix unexpected token in native code * Dummy commit to trigger Travis * Include the rnmobile release branch to Travis builds * Mobile: Links UI using BottomSheet component (#13972) * Mobile: Replaced Links UI with bottom-sheet component * Mobile links UI: Removed commented code. * Mobile: Fix lint issues * Mobile Links UI: Remove autofocus on Android. This hides an issue where the modal sometimes will be under the keyboard on Android. * Fixes pasting links. (#14038) * Update post title vertical paddings (#14040) * Add try/catch fallback to plain text for pasteHandler (#14044) * Fix link interface. (#14052) * [Mobile]Fix title padding on Android (#14057) * Remove title vertical paddings for Android * Revert "Remove title vertical paddings for Android" This reverts commit 09f0d35. * Import padding variables * Revert wrong format image color (#14058) * Stop building the mobile release branch on Travis (#14060)

…t` (#13809) * Test: Add test which verifies wheter JSX pragma detects WP global * Update packages/babel-plugin-import-jsx-pragma/test/index.js Co-Authored-By: gziolo <grzegorz@gziolo.pl> * Skip import when the scope variable is already defined * Add failing tests for inner scope variable defined verification * Add import statement when there is any undefined scope variable * Docs: Add details about changes introduced to Babel plugin

* Upgrade Jest to version 24 (breaking changes) * Update changelog files to list all dependencies upgraded * Downgrade puppeteer to the previous version 1.6.1 * Try to fix failing e2e tests setup * Added clarification in the changelog * Testing: Remove expect-puppeteer import reference * Address issues raised during code review

@chrisvanpatten

* Codeowners changes for @chrisvanpatten * Remove obsolete ghost placeholder for no longer onowned styles

* Include custome JSX pragma support in Babel preset * Stop using Babel tranpiliation for two packages babel-plugin-import-jsx-pragma and postcss-themes * Add engines field to node based packages

* Docs: release.md: misc. fixes

) * Use aria-disabled instead of disabled. * Fix unrecognized prop warning. * Disable Document Outline items in text mode. * Improve buttons alignment. * Pass isTextModeEnabled as prop from parent.

* Fix selector in document outline. * Import getBlocks from its new location.

…ions (#14096) * Plugin: Fix 5.1.0 deprecated functions to correct plugin version * Plugin: Require includes for deprecated `use_block_editor_for_` functions

…14097) `gutenberg_prepare_blocks_for_js` was deprecated in Gutenberg 5.0

Fixes #13659. The current quote block icon appears to have some over-simplified edges. This replaces it with a crisper version.

…bs (#13956) * Add subtle animation to the is-active indicator for sidebar tabs * Re-instate the empty border, to prevent browser defaults from kicking in. * Remove extra 1px of empty space * Focus state cleanup for tab buttons Allow them to inherit the box shadow (used for the active tab) Use the usual standard dotted outline instead of a solid one. * Add a pseudoclass to ensure the active border appears in Windows High Contrast Mode. * Fix typo. This should match the value from `/packages/edit-post/src/components/sidebar/settings-header/style.scss`

…es (#14099)

@aduth

Props to @aduth for coding this optimization.

…14113) ## Description This PR updates the format API tutorial (toolbar button section) to include a sample of a button that only renders on a certain block. Answers a question posted on #14104. Closes: #14104 ## How has this been tested? I pasted the sample code on the browser console and verified it works as expected.

* Use the editor settings to pass a mediaUpload handler * Update media block snapshots

* Block Editor: Consider RECEIVE_BLOCKS as non-persistent change * Block Editor: Compare last action in reducer enhancer only if non-ignored

* Plugin: Remove PHP functions slated for removal in 5.2 * Documentation: Update FAQ to avoid reference to deprecated function

…14116)

* Testing: Bump `enzyme-adapter-react-16` to 1.10.0 * Testing: Avoid unforwarded Button mock No longer necessary with native support for forwardRef in Enzyme * Testing: Un-skip BlockControls snapshot test

* Plugin: Preserve inline scripts in Gutenberg override * Plugin: Restore storageKey assignment for persistence migration

…13716) This pull is the first step in moving away from the lingering usage of effects in various data stores among packages. This pull specifically deals with post related effects in the @wordpress/editor package (`core/editor` store).

@aduth

…14154) ## Description Adds a rule to make sure Array functions that iterate on the array and should return something contain the return statement, otherwise, a forEach should probably be used instead. A case like this was fixed at #13953. In PR #13953 @aduth suggested the implementation of a lint rule to catch these cases. While trying to implement the rule and researching the best ways to do it, I noticed a rule like that already existed in the community and this PR is enabling it. We are also changing the code to respect the new rule no observable changes should be expected. ## How has this been tested? Observe the tests pass. Do some smoke testing, adding blocks, uploading files, and verify everything still works as before.

* Update text displayed when an embed can't be previewed * Add translator note for update to embedded content np preview message

… the edit gallery view (#12435)

* RichText: fix wordwise selection on Windows * Fix crtl ctrl typo. * Add docs

… block-editor (#14161) We missed to update the editor references from selectPreviousBlock, and selectNextBlock. ## Tests I added multiple blocks, I verified that when I remove a block the previous block still gets selected.

* Make IconButton able to get referenced. * Components: Forward IconButton ref as stateless function * Components: Restore IconButton aria-pressed prop pass-through

* Plugin: Add Text Domain to plugin headers * Bring i18n functionality up to date * Plugin: Set Gutenberg script translations as default domain Filter loading behavior to load from plugin translation files * Testing: Update gutenberg_override_script per localization changes * Plugin: Provide second argument for set script translations Technically optional, only after WP5.1+, which is newer than the current minimum version supported by Gutenberg

## Description This PR fixes a problem: if the post contains one block and it is removed the focus is lost. This is a regression that happened when removeBlocks action was refactored to be a generator. We had an effect that inserts the default block during remove blocks action when certain conditions are met, this effect stopped working. This PR removes the effect and makes sure everything is handled by the removeBlocks action creator. End to end test available at #14191. ## How has this been tested? I created a new post. I wrote something in a paragraph I removed the paragraph using the remove button in the side menu and I verified the default block was added.

@aduth

* Add repository.directory rule to npm-package-json-lint-config (fix #13947) * Fix lock file (props @aduth) * Fix rule, update changelogs * Add PR reference * Add directory field to packages/docgen * Apply changes suggested by @ntwb * Update CHANGELOG.md

… supports (#14144) * Plugin: Remove deprecated `gutenberg` theme supports * Plugin: Remove deprecated `_wpLoadGutenbergEditor`

…#14212)

…Practices (#14205) ## Description I've updated all references to Block Editor to be lowercase as they aren't proper nouns. This conforms to the core spelling Best Practices; “block editor” or “block-based editor” | “Block Editor” or “Gutenberg” | When referring to the new editor. Reference - https://make.wordpress.org/core/handbook/best-practices/spelling/ Also ties back to the original discussion around the capitalization convention here; #12856 Previously opened #14203 to handle the Classic Editor changes. ## How has this been tested? Only tested that it didn't break anything. ## Types of changes Mostly comment changes, there was one string change and a couple translator comment changes. ## Checklist: - [x] My code is tested. - [x] My code follows the WordPress code style.  - [x] My code follows the accessibility standards.  - [x] My code has proper inline documentation.  - [x] I've included developer documentation if appropriate.

* Babel Preset Default: Remove redundant (defaulted) corejs option * Scripts: Assign Babel runtime regenerator as externals in Webpack config * Babel Preset Default: Avoid disabling regenerator option

* Testing: Await E2E promise interactions * Testing: Disable animations on every admin screen * Testing: Refactor reusable block management to compare before/after entry count

@torres126

* Lowercase classic editor when not in reference to the plugin. * Reverted heading to use capitalized as the heading choice throughout uses full capitalization style on headings so went back to make consistent as @torres126 recommended. Also updated the snap file to resolve the Travis CI error. * Missed saving README.md where the revert on headding capitalization was in my editor.

…the editor (#13873)

#14109) ## Description The title in latest posts block was clickable across the full width of the row, making it easy to click on the title by mistake. This problem only affects the editor on the front end things worked as expected. ## How has this been tested? I added the latest posts block. I verified that the title is only clickable if the mouse is above the title and not above any part of its row. ## Screenshots  Before: ![feb-25-2019 21-49-15](https://user-images.githubusercontent.com/11271197/53371643-b3e3f380-3948-11e9-95f5-a8f235fabab2.gif) After: ![feb-25-2019 21-53-30](https://user-images.githubusercontent.com/11271197/53371657-c2320f80-3948-11e9-8dfd-ab7ae4640955.gif)

…Date (#14230)

* Fix undo after pattern * Update e2e test

* RichText: don't use DOM to add line padding * Clean up * Keep track of user inserted line breaks * Mark isEditableTree param unstable

)

@aduth

…toolbar (#14247) This PR updates our end to end tests to use escape key press instead of mouse movement to show the block toolbar. The PR follows a suggestion by @aduth in #14191 (comment) ## How has this been tested? We only need to make sure end 2 end tests pass

- @wordpress/a11y@2.1.0 - @wordpress/annotations@1.1.0 - @wordpress/api-fetch@3.0.0 - @wordpress/autop@2.1.0 - @wordpress/babel-plugin-import-jsx-pragma@2.0.0 - @wordpress/babel-plugin-makepot@3.0.0 - @wordpress/babel-preset-default@4.0.0 - @wordpress/blob@2.2.0 - @wordpress/block-editor@1.0.0 - @wordpress/block-library@2.3.0 - @wordpress/block-serialization-default-parser@3.0.0 - @wordpress/block-serialization-spec-parser@3.0.0 - @wordpress/blocks@6.1.0 - @wordpress/browserslist-config@2.3.0 - @wordpress/components@7.1.0 - @wordpress/compose@3.1.0 - @wordpress/core-data@2.1.0 - @wordpress/custom-templated-path-webpack-plugin@1.2.0 - @wordpress/data@4.3.0 - @wordpress/date@3.1.0 - @wordpress/deprecated@2.1.0 - @wordpress/docgen@1.0.0 - @wordpress/dom-ready@2.1.0 - @wordpress/dom@2.1.0 - @wordpress/e2e-test-utils@1.0.0 - @wordpress/e2e-tests@1.0.0 - @wordpress/edit-post@3.2.0 - @wordpress/edit-widgets@0.1.0 - @wordpress/editor@9.1.0 - @wordpress/element@2.2.0 - @wordpress/escape-html@1.1.0 - @wordpress/eslint-plugin@2.0.0 - @wordpress/format-library@1.3.0 - @wordpress/hooks@2.1.0 - @wordpress/html-entities@2.1.0 - @wordpress/i18n@3.2.0 - @wordpress/is-shallow-equal@1.2.0 - @wordpress/jest-console@3.0.0 - @wordpress/jest-preset-default@4.0.0 - @wordpress/jest-puppeteer-axe@1.0.0 - @wordpress/keycodes@2.1.0 - @wordpress/library-export-default-webpack-plugin@1.1.0 - @wordpress/list-reusable-blocks@1.2.0 - @wordpress/notices@1.2.0 - @wordpress/npm-package-json-lint-config@1.2.0 - @wordpress/nux@3.1.0 - @wordpress/plugins@2.1.0 - @wordpress/postcss-themes@2.0.0 - @wordpress/priority-queue@1.0.0 - @wordpress/redux-routine@3.1.0 - @wordpress/rich-text@3.1.0 - @wordpress/scripts@3.0.0 - @wordpress/shortcode@2.1.0 - @wordpress/token-list@1.2.0 - @wordpress/url@2.4.0 - @wordpress/viewport@2.2.0 - @wordpress/wordcount@2.1.0

This PR adds an end 2 end test util that allows clicking in a block toolbar button and refactors existing code to use it. ## How has this been tested? We only need to verify that the end 2 end tests pass.

…with background color of block (#14257)

…se branches (#14260)

#13455) * Adding an e2e test verifying simple keyboard navigation through blocks (Issue #12392) using bug resolved in #11773 as the basis for the steps * Moving `navigateToContentEditorTop`, `tabThroughParagraphBlock`, `tabThroughBlockMoverControl` and `tabThroughBlockToolbar` to the parent scope. Using pressKeyWithModifier within navigateToContentEditorTop.

The double dash was being converted to a single dash (–)

* add new actions for invalidating resolution caches * use path array for omit * clarify logic

…14280)

* RichText: collapse toolbar * Move inline image * Add balanced margin * Add tooltip * Update e2e test * Update e2e test * Remove RichTextInserterItem * Ensure there are fills before rendering * Make toggle button bigger * Use clickBlockToolbarButton * Fix e2e test

* RichText: fix br padding in multiline and nesting * Add e2e test

@gziolo

* Update packages used by eslint plugin to remove warnings * Manually modify package-lock.json Props @gziolo. * Specify React version in eslint-plugin-react settings * Fix react/jsx-no-target lint errors

@melchoyce

## Description Implements: #4770 This PR is a **proof of concept** of a legacy widget block. A block that allows existing WordPress widgets to be added as Gutenberg blocks. The design is similar to the one proposed by @melchoyce in #4770 (comment) (option 1). Although it seems option two was preferred, it would require to expose each widget as a block similar to what embeds do, and it would increase the technical complexity and make testing/debugging harder, so I preferred to use option 1 for now. I will gladly iterate on the UX after this proof of concept gets more stable. ## Some technical details The available widgets are preloaded to Gutenberg similar to what happens with page templates. ### REST-API user story I want to able to pass a widget identifier to an endpoint, pass the existing widget attributes and the changes the user is making if any, and receive from the rest API, the sanitized new widget attributes ready to save and an HTML form that allows the user to edit the widget in the new state. ### REST-API endpoint A very simple REST-API endpoint was implemented. The endpoint receives the previous instance of a widget (previous attributes) the changed instance of a widget (changed attributes if any) and returns the new instance of the widget and the HTML form that allows editing this widget. There are two ajax-admin endpoints save-widget and update-widget. It looks like each one has specificities that make using it here complex. The ajax admin code would probably require some changes to be used here. Our use case is straightforward from the backend perspective as the widget does not need to be saved anywhere, and the widget is not associated with any widget area. The most straightforward approach seemed to be using a very simple endpoint. If I missed something and adapting existing endpoints is simpler feel free to comment, and I will have a look. ### Block Architecture The edit component of the block handles the start placeholder that allows selecting a widget, and the tab mechanism that allows switching between edit and preview. The preview is done using the ServerSideRender component. The edit is done using two components: **WidgetEditHandler:** Is responsible for server communication using the endpoint we created, and for keeping the required local state for the edition. Renders an update button, when pressed we retrieve from the dom the changed fields (using a method provided by WidgetEditDomManager) issues a request to the server and updates the legacy widget instance attribute with the server answer. **WidgetEditDomManager:** Component responsible for rendering the starting dom for a widget. After the first render React never rerenders the component again, the content rendered by this component is then managed by the scripts the widgets may implement. When a new instance of the form HTML is received we manually update the dom changing .widget-content (like the customizer and the widget screen) do. This component provides a method that returns an object with the widget changed attributes. When this component is mounted it triggers a widget-added event when a new update happens and the dom is changed by the component widget-update jQuery event is triggered. On front end widget are rendered with a simple call to [the_widget](https://codex.wordpress.org/Function_Reference/the_widget). ## Screenshots  ![jan-25-2019 19-37-44](https://user-images.githubusercontent.com/11271197/51768637-c3b5b100-20d8-11e9-941f-00adb4c7b0a1.gif) ![jan-25-2019 18-58-49](https://user-images.githubusercontent.com/11271197/51768645-cb755580-20d8-11e9-89e7-1aa9ba7256c3.gif) ## Known problems - The block is not aware of any change inside the widget until the update button is pressed. This replicates the save button on the widgets screen. But it is annoying if we change something on the widget and go to the widget preview right away our changes are not reflected in the preview. Having an explicit update, makes testing and debugging easier, we may than explore other approaches e.g.: also save when preview happens, save on blur events, etc. - The text widget that contains TinyMCE crashes and fails to init. It calls wp.editor.initialize to reference TinyMCE and on Gutenberg, wp.editor is our editor module. This problem may have happened with meta boxes if it was solved probably the same approach may be applied. - The widget design may be affected by CSS that exists in Gutenberg, so the design of the widgets does not look the same. Ideally, Gutenberg CSS would not affect the widgets but as they are on the same page that's not the case. - Some third-party widgets using don't initialize correctly. That happens because the dom of the editor is not equal to the dom of the customizer and/or the widget screen. Some JS widgets use click events on the widgets screen to initialize while on Gutenberg these events don't happen, some check if they are on the customizer page (body contains customizer classes) before handling widget-updated events. Normally adapting a widget that does not initialize correctly is a matter of changing a very simple condition on the plugin.

…ault block appender gets inserter and selected (#14191)

The *Deprecated Blocks link* was pointing to the wrong URL.

* Added testcases for isKeyboardEvent in keycodes module * Fixed assertion checks and updated attachEventListeners function * Added testcases for isKeyboardEvent in keycodes module * Fixed assertion checks and updated attachEventListeners function

* ToggleControl allows setting custom classes Related Issue: #11349 This pull request fixes the "ToggleControl does not allow setting custom classes" problem. This lets the user to add a custom classname on the element, just like in TextControl. * Update README of toggle-control Add property className and its description * Update packages/components/src/toggle-control/README.md Formatted style of README Co-Authored-By: AmartyaU <44530193+AmartyaU@users.noreply.github.com>

* Plugin: Remove postinstall step * Framework: Run build for JS unit tests Assumed previously relied on postinstall

) If trying to merge a blank heading or paragraph, if this check isn't performed, the result is the string 'Null' appearing in the text.

@nosolosw

…13909) * Update internationalization process with complete updated example. * Minor edits * Update i18n package documentation Updates with links to expanded section in Gutenberg Handbook Fixes instructions to use wp-cli which is the recommended tool for creating pot files, and po2json to convert the format. * Apply suggestions from code review Co-Authored-By: mkaz <marcus@mkaz.com> * Remove duplicate documentation, just link to Handbook * Batch of changes from reviews props @swisspiddy * :shakes-fist-at-whitespace: * Updates to include full .pot and .po files per @nosolosw review * Add JSON translation example

* Rename variable to make code more clear * Fix display of expected and actual block HTML The variable were in the wrong order, making the message confusing. It would show the actual HTML as the expected HTML and visa versa. * Change wording to be more clear Expected & Actual were confusing words to use in this content. This change makes the message actually reflect what the values are. * Regenerate docs

…4020)

…ided (#13877) * Use a default webpack config if none is provided * Extract webpack utils from build command * Update start command * Add docs * Add Webpack documentation * Add example of how to overwrite the default plugins * Do not export hasWebpackConfig as it is not used anywhere else. * Always pass webpack CLI args to command * Update README * Remove section on extending the default webpack config file * Simplify array passing Co-Authored-By: nosolosw <nosolosw@users.noreply.github.com> * Simplify pushing to array Co-Authored-By: nosolosw <nosolosw@users.noreply.github.com> * Fix externals docs * Use webpack instead of Webpack * Add Changelog entry

* Fix use of __experimentalCreatePrepareEditableTree without __experimentalCreateOnChangeEditableValue * Add unit tests

…ats (#13948) * Add objects and lineFormats * Update RichText * Fix image toolbar * Update format placeholder * lineFormat => lines * concatPair => mergePair * Update selectedFormat checks * Add some extra info to create docs * Move create docs inline * Merge lines and objects * Fix typos * Add getActiveObject unit tests * Update docs * Rebase * Adjust unstableToDom arguments * Remove normaliseFormats from list functions * Update native files * Update native file

* RichText: try alternative list shortcuts * Try tooltips * Change tooltips to use text * Add inline comments * Add e2e test * Rebase

These changes add design documentation. Co-Authored-By: kjellr <kjell@kjellr.com>

* Adjust document outline to use an a tag vs button * target href links directly to page anchors, remove onClick handler * update test snapshot * update snapshot * better titleNode targeting * update snapshot * update snapshot * Close the table of contents panel when a link is clicked * add deterministic block id to tests * remove redundant screen reader text * Adjust map to avoid mutating original object * update snapshot * Update packages/editor/src/components/document-outline/index.js Co-Authored-By: adamsilverstein <adam@10up.com> * Update packages/editor/src/components/document-outline/test/index.js remove leading _ Co-Authored-By: adamsilverstein <adam@10up.com> * Update packages/editor/src/components/document-outline/index.js Co-Authored-By: adamsilverstein <adam@10up.com> * update snapshot * update snapshots * update snapshot * update snapshots * fix up e2e tests * Fix snapshots by removing single quotes from outline links * Update packages/editor/src/components/document-outline/index.js Co-Authored-By: adamsilverstein <adam@10up.com> * change target to href * rename close -> closeOutline * update snapshots after property name changes * rename close/onClose -> onRequestClose for TOC, on * restore onSelect * complete renaming * Block links are only valid for the current session - remove hash after following * update snapshot * cleanup; move block id hash removal functionality up to document outline; now includes title * update snapshot * use replaceState vs pushState * use defer and import at top of file * removeURLHash as helper * remove passing event in select handler * improve doc block * Skip title in outline when title node not found * remove removeURLHash

* Plugin: Remove replace_editor filter, extend core editor * Plugin: Avoid dynamic dependencies for wp-block-library style This is handled by core in common blocks style enqueues behavior https://github.com/WordPress/wordpress-develop/blob/e421f26/src/wp-includes/script-loader.php#L2626-L2630 * Testing: Leverage saveDraft for meta boxes save

* Use <s> for strikethrough, not <del> * Update e2e test

* Add anchor link * Add anchor link to second reference

* added an interactive argument to the test-e2e script * mend * added a way to bypass certain args from Jest, reverted to normal argument passing using double dash * simplified the argument cleanup function * simplified the argument cleanup function * added a way to bypass certain args from Jest, reverted to normal argument passing using double dash * simplified the argument cleanup function * simplified the argument cleanup function * cleaned up the code by moving the prefixed arguments removal to getcliargs

…; Add: end to end tests; (#14390)

) * Input Interaction: fix buffer for the triggering of multi-select * Add inline comment * Add e2e test

…s it (#14450) * Input Interaction: only consider selection at edge if directed towards it * Add e2e test

* Initial commit to update CheckboxControl readme These changes add design documentation. * Fix tabbing on code example

* Add thick borders to the left of blocks when they're hovred + selected. * Add thick left border to the page title. * Turn off block toolbar centering for alignwide blocks. This splits the left border in two, which looks a bit weird. * Move block breadcrump to the left side, position it on top of the block. * Clean up the block toolbar's left border. * Use inset borders on mobile. * Prevent inset borders from overlapping with full-bleed content. * Use a gray border instead of a blue one on hover. * Use a sass variable to define the left block border width * Fix breadcrumb potision for alignfull blocks. * Clean up breadcrumb position for left & right-aligned blocks. * Sync block mover animation up with the hover state. * Darken focused block borders slightly. From $light-gray-500 to $light-gray-800. * Switch to using border instead of outline for block borders. Also, change the thick left border to a solid color, to prevent weird overlap. * Make this work better with Windows High Contrast Mode * Adjust z-index of border + breadcrumb for child blocks. So that they're not overlapped by the parent block's border + toolbar. * Remove extra z-index rule from the block border. Turns out this wasn't needed anyway. * Remove extra z-index rule from the block border. Minor description cleanup. * Ensure these styles are compatible with Top Toolbar mode. * Use the new gray value for the mobile toolbar border. * Add a matching left border to the post permalink area above the title. * Improve border position for mobile screens, especially for elements that float left/right. * Remove a couple unnecessary border updates from 047e1e4. Turns out these styles can be preserved on all screen sizes with no ill effect. * Clean up bugs related to the hover + focus states of the classic editor block. * Classic Block toolbar icon cleanup. Even out margins, remove white background. * Reusable Block border cleanup. * Keeping a light border on the classic block when it's inactive. * Clean up borders on warning blocks. * Switch to a solid color border color for the permalink box. This mirrors the approach we use for block toolbars, and also ensures that we don't layer opacities and make the permalink toolbar darker than intended. * Update z-index rule name to match the one used in the latest merge. * Combine full-wide toolbar centering rules. Previously, these were declared in two separate palces. * Add a darker hover state for dark themes. * Remove the left toolbar border on mobile screens. This fixes some visual bugs with themes like TwentyNineteen, which include margins on either side of the block on mobile.

* Input Interaction: allow outer vertical edge to be selected * Add e2e test

…blocks.test.js (#14458)

* DOM: Limit single tabbable radio input by name * DOM: Avoid consolidating unnamed radio inputs

Add design guidelines and screenshots.

* Update MenuGroup Readme. Add design guidelines and screenshots. * Adjust introduction to be more concise.

…14322)

#14470)

@codebykat

* Fix: Pasting captions without an image fails Fixes #13527 See original work in #12315 When pasting content which includes the `[caption]` shortcode we assume that the content is well-formed (that there is not only an `<img />` in there but also in the first position). In this patch we fix the problem by removing the old code, which removed the first `Element` node, and replaced it with code that removes the first `IMG` node _if one is found_. We're leaving other image nodes in place in case the caption contains image nodes and we're not requiring that the `IMG` be the first child of the caption shortcode in case people are wrapping the image in other valid HTML like this... ```html [caption]<a href="some.link"><img src="some.image"></a>[/caption] ``` See the new unit tests for a more complete specification of the intended behaviors. PR reviewed, debugged, and created by: -> LANNISTER MOB <- - @codebykat - @dmsnell - @gwwar - @kwight - @mmtr - @obenland - @rodrigoi - @vindl * Update stripFirstImage behavior to also remove matching topmost parent node

…1y notes to the animation docs. (#14021)

…t-jsx-pragma with @wordpress/babel-preset-default (#14482)

…lures in inner blocks allowed blocks test. (#14460)

* Clarify that JSX is not part of ESNext in JS build setup tutorial * Docs: Polish @wordpress/scripts README and related tutorial * Emphasize that build and start scripts should be used with the default config * Add Advanced information subsection for all scripts * Link the existing tutorial for build and start scripts

Commits on Mar 20, 2019

Update plugin version to 5.3

jorgefilipecosta committed Mar 20, 2019

Configuration menu

View commit details

Copy full SHA for 0563f6f

Browse repository at this point

Copy the full SHA

0563f6f View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update WordPress trunk to Gutenberg 5.3 #14532

Update WordPress trunk to Gutenberg 5.3 #14532

Commits on Feb 15, 2019

Commits on Feb 16, 2019

Commits on Feb 18, 2019

Commits on Feb 19, 2019

Commits on Feb 20, 2019

Commits on Feb 21, 2019

Commits on Feb 22, 2019

Commits on Feb 24, 2019

Commits on Feb 25, 2019

Commits on Feb 26, 2019

Commits on Feb 27, 2019

Commits on Feb 28, 2019

Commits on Mar 1, 2019

Commits on Mar 4, 2019

Commits on Mar 5, 2019

Commits on Mar 6, 2019

Commits on Mar 7, 2019

Commits on Mar 8, 2019

Commits on Mar 9, 2019

Commits on Mar 10, 2019

Commits on Mar 11, 2019

Commits on Mar 12, 2019

Commits on Mar 13, 2019

Commits on Mar 14, 2019

Commits on Mar 15, 2019

Commits on Mar 16, 2019

Commits on Mar 18, 2019

Commits on Mar 20, 2019