Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] - React Native 0.69.4 Upgrade - Android #43486

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

geriux
Copy link
Member

@geriux geriux commented Aug 22, 2022

Related PRs

Feature branch

Android integration

iOS integration

What?

This PR includes the needed Android changes to upgrade the React Native framework to the 0.69.4 version.

Why?

To keep up to date with the latest stable React Native version.

How?

Using the React Native Upgrade Helper (list of changes):

  • It adds all of the new files to support the new React Native architecture, files under the gutenberg/newarchitecture and main/jni all of those were copied with no changes other than the package name package com.gutenberg.newarchitecture;
  • It updates the usage of GestureHandlerRootView since it is now deprecated to do it in the MainActivity, so it was removed from here and added in the javascript side.
  • It updates the path for hermesc since it is now under the React Native folder.

Before merging:

  • Update the third-party dependencies for React Native Video, React Native Reanimated and React Native Gesture Handler.

Testing Instructions

The Android app should build and open the editor correctly.

Screenshots or screencast

N/A

@geriux geriux added [Status] In Progress Tracking issues with work in progress Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Aug 22, 2022
@geriux geriux changed the title [Mobile] - React Native 0.69.4 Upgrade - Android changes [Mobile] - React Native 0.69.4 Upgrade - Android Aug 22, 2022
@geriux geriux added the Mobile App - Automation Label used to initiate Mobile App PR Automation label Aug 23, 2022
package.json Outdated Show resolved Hide resolved
@geriux geriux removed the [Status] In Progress Tracking issues with work in progress label Oct 10, 2022
@geriux geriux marked this pull request as ready for review October 10, 2022 10:53
Copy link
Member

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the updates to react-native-reanimated and react-native-gesture-handler. 🚀

@geriux geriux force-pushed the rnmobile/upgrade/0.69.4-android branch from 32c5271 to 5e46b84 Compare October 11, 2022 11:30
@geriux geriux merged commit 3162889 into rnmobile/upgrade/0.69.4 Oct 11, 2022
@geriux geriux deleted the rnmobile/upgrade/0.69.4-android branch October 11, 2022 11:32
geriux pushed a commit that referenced this pull request Oct 19, 2022
* Mobile - React Native 0.69.4 upgrade, base Android changes

* Mobile - Remove RNGestureHandlerEnabledRootView since its now deprecated

* Mobile - Update bundle android script
geriux pushed a commit that referenced this pull request Nov 28, 2022
* Mobile - React Native 0.69.4 upgrade, base Android changes

* Mobile - Remove RNGestureHandlerEnabledRootView since its now deprecated

* Mobile - Update bundle android script
jsnajdr pushed a commit that referenced this pull request Nov 28, 2022
* Mobile - React Native 0.69.4 upgrade, base Android changes

* Mobile - Remove RNGestureHandlerEnabledRootView since its now deprecated

* Mobile - Update bundle android script
jsnajdr pushed a commit that referenced this pull request Dec 1, 2022
* Mobile - React Native 0.69.4 upgrade, base Android changes

* Mobile - Remove RNGestureHandlerEnabledRootView since its now deprecated

* Mobile - Update bundle android script
jsnajdr added a commit that referenced this pull request Dec 1, 2022
* Upgrade React packages to v18

* Upgrade framer-motion to get React 18 support and updated types

* React Native: upgrade to 0.69.4

* React Native: upgrade libraries

* LinkControl: fix unit tests

* Components: fix unit tests

* Block Editor: fix unit tests

* NUX: fix unit tests

* useSelect: fix unit tests (partially)

* LinkSettings test: fix finding blocks by label text

* BlockDraggable test: fix finding blocks by label text

* React Native test helpers: fix getting blocks

* Block Library tests: fix finding blocks by label text

* ToggleGroupControl: fix unit test by waiting for tooltip

* File Block: update snapshots to account for empty children

* Embed native tests: improve mocked API response

* Embed native tests: wait for rich preview to appear

* Format Library: fix finding blocks by label text

* Edit Post: fix finding blocks by label text

* Update native snapshots

* useNestedSettingsUpdate: deoptimize/unbatch dispatching the updateBlockListSettings actions

* Color Palette: wait for dropdown to appear

* Add custom Jest matcher: toBePositionedPopover

* Use toBePositionedPopover matcher in tests

* Mobile - Update tests

* Mobile - Update gitignore

* Mobile - Update ruby config

* [Mobile] - React Native 0.69.4 Upgrade - Android (#43486)

* Mobile - React Native 0.69.4 upgrade, base Android changes

* Mobile - Remove RNGestureHandlerEnabledRootView since its now deprecated

* Mobile - Update bundle android script

* [Mobile] - React Native 0.69.4 Upgrade - iOS

* Mobile - Check for a local bundle running with metro and use a jsbundle as a fallback

* Remove duplicated import of Gesture handler

* Remove deprecated initialization for Reanimated

* Update Podfile.lock after updating dependencies

* Remove React peer deps from packages that don't need them

* Add changelog entries about React 18 upgrade

* Extract useIsScreenReaderEnabled hook, set state only if enabled=true

* Mobile - Update Podfile.lock

Co-authored-by: Marin Atanasov <tyxla@abv.bg>
Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>
Co-authored-by: Derek Blank <derekpblank@gmail.com>
mpkelly pushed a commit to mpkelly/gutenberg that referenced this pull request Dec 7, 2022
* Upgrade React packages to v18

* Upgrade framer-motion to get React 18 support and updated types

* React Native: upgrade to 0.69.4

* React Native: upgrade libraries

* LinkControl: fix unit tests

* Components: fix unit tests

* Block Editor: fix unit tests

* NUX: fix unit tests

* useSelect: fix unit tests (partially)

* LinkSettings test: fix finding blocks by label text

* BlockDraggable test: fix finding blocks by label text

* React Native test helpers: fix getting blocks

* Block Library tests: fix finding blocks by label text

* ToggleGroupControl: fix unit test by waiting for tooltip

* File Block: update snapshots to account for empty children

* Embed native tests: improve mocked API response

* Embed native tests: wait for rich preview to appear

* Format Library: fix finding blocks by label text

* Edit Post: fix finding blocks by label text

* Update native snapshots

* useNestedSettingsUpdate: deoptimize/unbatch dispatching the updateBlockListSettings actions

* Color Palette: wait for dropdown to appear

* Add custom Jest matcher: toBePositionedPopover

* Use toBePositionedPopover matcher in tests

* Mobile - Update tests

* Mobile - Update gitignore

* Mobile - Update ruby config

* [Mobile] - React Native 0.69.4 Upgrade - Android (WordPress#43486)

* Mobile - React Native 0.69.4 upgrade, base Android changes

* Mobile - Remove RNGestureHandlerEnabledRootView since its now deprecated

* Mobile - Update bundle android script

* [Mobile] - React Native 0.69.4 Upgrade - iOS

* Mobile - Check for a local bundle running with metro and use a jsbundle as a fallback

* Remove duplicated import of Gesture handler

* Remove deprecated initialization for Reanimated

* Update Podfile.lock after updating dependencies

* Remove React peer deps from packages that don't need them

* Add changelog entries about React 18 upgrade

* Extract useIsScreenReaderEnabled hook, set state only if enabled=true

* Mobile - Update Podfile.lock

Co-authored-by: Marin Atanasov <tyxla@abv.bg>
Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>
Co-authored-by: Derek Blank <derekpblank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants