-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] - React Native 0.69.4 Upgrade - iOS #44724
Merged
derekblank
merged 85 commits into
rnmobile/upgrade/0.69.4
from
rnmobile/upgrade/0.69.4-ios
Oct 11, 2022
Merged
[Mobile] - React Native 0.69.4 Upgrade - iOS #44724
derekblank
merged 85 commits into
rnmobile/upgrade/0.69.4
from
rnmobile/upgrade/0.69.4-ios
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework animation of color array and hover state. It constructs a backdrop with a blurred out color palette from the json.
Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.2 to 3.0.6. - [Release notes](https://github.com/TooTallNate/node-plist/releases) - [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md) - [Commits](https://github.com/TooTallNate/node-plist/commits) --- updated-dependencies: - dependency-name: plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix doc for extending prettier-config in .prettierrc file * Add step for adding prettier-config in .prettierrc.js file * Add changelog
…ock) (#44415) * Removes unstable limit attribute * Remove attribute from Nav block
Use colored text icon only when colors are set, otherwise fallback to color drop icon.
Respect discussion settings in the new Comments block while working in the Site Editor. We are loading some placeholders, and they should follow the discussion settings as much as possible in order to reflect the frontend output. Co-authored-by: Bernie Reiter <ockham@raz.or.at>
…4646) * Address review comments * Update lib/compat/wordpress-6.1/block-template-utils.php Co-authored-by: Bernie Reiter <ockham@raz.or.at>
- @wordpress/a11y@3.19.0 - @wordpress/annotations@2.19.0 - @wordpress/api-fetch@6.16.0 - @wordpress/autop@3.19.0 - @wordpress/babel-plugin-import-jsx-pragma@4.2.0 - @wordpress/babel-plugin-makepot@5.3.0 - @wordpress/babel-preset-default@7.3.0 - @wordpress/base-styles@4.10.0 - @wordpress/blob@3.19.0 - @wordpress/block-directory@3.17.0 - @wordpress/block-editor@10.2.0 - @wordpress/block-library@7.16.0 - @wordpress/block-serialization-default-parser@4.19.0 - @wordpress/block-serialization-spec-parser@4.19.0 - @wordpress/blocks@11.18.0 - @wordpress/browserslist-config@5.2.0 - @wordpress/components@21.2.0 - @wordpress/compose@5.17.0 - @wordpress/core-data@5.2.0 - @wordpress/create-block-tutorial-template@2.7.0 - @wordpress/create-block@4.3.0 - @wordpress/custom-templated-path-webpack-plugin@2.3.0 - @wordpress/customize-widgets@3.16.0 - @wordpress/data-controls@2.19.0 - @wordpress/data@7.3.0 - @wordpress/date@4.19.0 - @wordpress/dependency-extraction-webpack-plugin@4.2.0 - @wordpress/deprecated@3.19.0 - @wordpress/docgen@1.28.0 - @wordpress/dom-ready@3.19.0 - @wordpress/dom@3.19.0 - @wordpress/e2e-test-utils@8.3.0 - @wordpress/e2e-tests@5.3.0 - @wordpress/edit-post@6.16.0 - @wordpress/edit-site@4.16.0 - @wordpress/edit-widgets@4.16.0 - @wordpress/editor@12.18.0 - @wordpress/element@4.17.0 - @wordpress/env@5.4.0 - @wordpress/escape-html@2.19.0 - @wordpress/eslint-plugin@13.3.0 - @wordpress/experiments@0.1.0 - @wordpress/format-library@3.17.0 - @wordpress/hooks@3.19.0 - @wordpress/html-entities@3.19.0 - @wordpress/i18n@4.19.0 - @wordpress/icons@9.10.0 - @wordpress/interface@4.18.0 - @wordpress/is-shallow-equal@4.19.0 - @wordpress/jest-console@6.2.0 - @wordpress/jest-preset-default@10.0.0 - @wordpress/jest-puppeteer-axe@5.2.0 - @wordpress/keyboard-shortcuts@3.17.0 - @wordpress/keycodes@3.19.0 - @wordpress/lazy-import@1.6.0 - @wordpress/library-export-default-webpack-plugin@2.5.0 - @wordpress/list-reusable-blocks@3.17.0 - @wordpress/media-utils@4.10.0 - @wordpress/notices@3.19.0 - @wordpress/npm-package-json-lint-config@4.4.0 - @wordpress/nux@5.17.0 - @wordpress/plugins@4.17.0 - @wordpress/postcss-plugins-preset@4.3.0 - @wordpress/postcss-themes@5.2.0 - @wordpress/preferences-persistence@1.11.0 - @wordpress/preferences@2.11.0 - @wordpress/prettier-config@2.2.0 - @wordpress/primitives@3.17.0 - @wordpress/priority-queue@2.19.0 - @wordpress/project-management-automation@1.18.0 - @wordpress/react-i18n@3.17.0 - @wordpress/readable-js-assets-webpack-plugin@2.2.0 - @wordpress/redux-routine@4.19.0 - @wordpress/reusable-blocks@3.17.0 - @wordpress/rich-text@5.17.0 - @wordpress/scripts@24.3.0 - @wordpress/server-side-render@3.17.0 - @wordpress/shortcode@3.19.0 - @wordpress/style-engine@1.2.0 - @wordpress/stylelint-config@21.2.0 - @wordpress/token-list@2.19.0 - @wordpress/url@3.20.0 - @wordpress/viewport@4.17.0 - @wordpress/warning@2.19.0 - @wordpress/widgets@2.17.0 - @wordpress/wordcount@3.19.0
derekblank
added
[Status] In Progress
Tracking issues with work in progress
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
labels
Oct 6, 2022
This was referenced Oct 6, 2022
Hey @derekblank 👋 I wonder why there are |
* Inserter: add a more pronounced hover effect. * Protect against insufficient contrast in some admin color schemes.
* [Documentation]: Update Extending the Query Loop block docs * Apply suggestions from code review Co-authored-by: Ryan Welcher <me@ryanwelcher.com> Co-authored-by: Lucio Giannotta <sunyatasattva@gmail.com> * Apply suggestions from code review Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com> Co-authored-by: Ryan Welcher <me@ryanwelcher.com> Co-authored-by: Lucio Giannotta <sunyatasattva@gmail.com> Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
* Compose: Refactor useViewportMatch tests to RTL * Add a clarifying comment
* Data: Refactor 'useDispatch' tests to use RTL * Clear mock function between assertions * Simplify userEvent setup * Update tests to observer actual store behavior * Remove leftover comment * Return action call tests
* enhances the effect of the reduceUI preference - hide all the chrome of the editor, including the block toolbar, top bar, most top bar buttons, insertion point and closes any sidebars Co-authored-by: Matias Ventura <548849+mtias@users.noreply.github.com> Co-authored-by: James Koster <846565+jameskoster@users.noreply.github.com> * snapshot update * remove useless prop * Adds framer motion animation to header elements in distraction free mode. Co-authored-by: Matias Ventura <548849+mtias@users.noreply.github.com> Co-authored-by: James Koster <846565+jameskoster@users.noreply.github.com> * Adjusts the bottom distance of snackbars for distraction free mode. Co-authored-by: Javier Arce <4933+javierarce@users.noreply.github.com> * Deals with editor notices: - moves them to the header of the interface skeleton - moves them on top of the interface header to make them dismissable Co-authored-by: Javier Arce <4933+javierarce@users.noreply.github.com> Co-authored-by: Joen A. <1204802+jasmussen@users.noreply.github.com> * Limits notices in interface header only when distraction free mode is on. Co-authored-by: Matias Ventura <548849+mtias@users.noreply.github.com> * Handles toolbar focus in distraction free mode: - Shift+Tab shows the top toolbar and allos reverse tabbing - Alt+F10 is disabled like in other situations when focusin the toolbar not possible Co-authored-by: Alex Stine <13755480+alexstine@users.noreply.github.com> * Removes wrong visual margin artefact for notifications in DFM Co-authored-by: Javier Arce <4933+javierarce@users.noreply.github.com> * refactores reducedUI to distractionFree and hasReducedUI to isDistractionFree * Fixes the page jump in distraction free mode. Part of this bug but with a different cause exists in trunk as well. Co-authored-by: Ella van Durpe <4710635+ellatrix@users.noreply.github.com> * Bulk adds the same distraction free mode toggle effects to: - toggle in the writing menu - the keyboard shortcut - the preference toggle Adds a new action to set a feature to a desired value. Some duplication, not sure how to DRY. * Removes "reduce UI" from the prefferences modal. Co-authored-by: Matias Ventura <548849+mtias@users.noreply.github.com> * adds back slash to allowed chars in shortcuts visual expression * fix snapshot and pref modal test * fix pref modal bug introduced by prev commit * use only one useSelect for easier mock implementation * adds correct order of mocked return values for useSelect * fix order of flags in the prefferences modal * Moves focus on distraction free toggle to first block via block selection. Unclear what to do when there is not a post edited by a block editor, but one where the flow of the block list is not linear. Co-authored-by: Alex Stine <13755480+alexstine@users.noreply.github.com> * Remove double border in header and add subtle backdrop transparency. * Let's not use "Toggle interface" as a name. * Removes the inline toolbar in distraction free mode. For those who have tested this PR run this in console to unset the preference, which is not otherwise visible anywhere: ``` wp.data.dispatch( 'core/preferences' ).set('core/edit-post', 'inlineToolbar', false); ``` Co-authored-by: Matias Ventura <548849+mtias@users.noreply.github.com> * Adds the mode selector, undo, redo and doc stats back to the toolbar. Co-authored-by: Matias Ventura <548849+mtias@users.noreply.github.com> * creates the distraction free experiment * Revert "creates the distraction free experiment" This reverts commit 4565b66. * Combines two css rules into one. Co-authored-by: Matias Ventura <548849+mtias@users.noreply.github.com> * Undo a new public API `setFeature` in the prefferences package. Use the store directly instead. Co-authored-by: Daniel Richards <677833+talldan@users.noreply.github.com> * Fixes small nits in code. Co-authored-by: Ben Dwyer <275961+scruffian@users.noreply.github.com> Co-authored-by: Matias Ventura <548849+mtias@users.noreply.github.com> Co-authored-by: James Koster <846565+jameskoster@users.noreply.github.com> Co-authored-by: Javier Arce <4933+javierarce@users.noreply.github.com> Co-authored-by: Joen A. <1204802+jasmussen@users.noreply.github.com> Co-authored-by: Alex Stine <13755480+alexstine@users.noreply.github.com> Co-authored-by: Ella van Durpe <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Matías Ventura <mv@matiasventura.com> Co-authored-by: Daniel Richards <677833+talldan@users.noreply.github.com> Co-authored-by: Ben Dwyer <275961+scruffian@users.noreply.github.com>
…les (#44640) * Update client-assets.php * Update client-assets.php * Update client-assets.php * Update lib/client-assets.php Co-authored-by: Ari Stathopoulos <aristath@gmail.com> Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
…block (#44827) * [Block Settings]: Show `move to` on nested blocks when only one root block * use `getBlockRootClientId`
…values (#44764) * This commit ensures that custom font size values that appear in the style attribute of block content are converted to fluid typography (if activated) * Adding comments * Bail early if we don't find a custom font size * Adding tests yo * Updating PHP doc to describe incoming type of $raw_value (string|number)
…re not calculated for custom values (#44761) * Fluid Typography: Fix bug where fluid clamp rules were not calculated for custom global styles values * Add inline comments * Add tests for JS changes * Fluid Typography: ensure global styles preset fluid sizes are calculated correctly (#44791) * Forked #44761 * Ensuring the font size picker select box shows the right labels * update comment. Typescript has beaten me. It's much more convenient to use getFontSizeOptions(), but I guess we'll have to refactor. * Adding comment about Typescript bug (YAY, it wasn't me being dumb with TS for once) * Added tests yo * Changeo loggo * Create a new FontSizeSelectOption return type for getSelectedOption to: 1. Clean up type changes in #44791 2. Make TS linter be quiet * Revert accidental changes to emptytheme * Revert type changes and other calamities * Remove additional size value from getToggleGroupOptions test as I believe it is no longer expected Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: ramonjd <ramonjd@gmail.com>
* For serverside rendered typography block support styles, covert font size values to fluid values in the inline styles if fluid typography is activated. Added unit tests * Add fluid font size to Nav Link * Add fluid typography to Search block * Fix fluid typography for Submenu block with open on click * Fix fluid typography for Page List block * Remove unnecessary parameter * Call esc_attr only once on the whole typography string Co-authored-by: tellthemachines <isabel@tellthemachines.com>
…ses from being printed twice (#44439) * Tag Cloud Block: Prevent block support styles and additional CSS classes from being printed twice * Fix Typo Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> * Fix Typo Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> * Use new option * move the box-sizing: border-box to the style.scss file Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
* Updating PHP doc to describe incoming type of $raw_value (string|int) This PR also harmonizes the JS checks And review comments from #44807 (review) These changes have already been backported to Core in WordPress/wordpress-develop#3428 * Update changelog Add extra test for floats Add i18n domain * Font sizes can be string|int|float Updated tests and JSDoc type * Expand tests for gutenberg_get_typography_value_and_unit Fix typo in CHANGELOG.md
- ensure that we convert fluid font sizes to fluid values in the editor for search block block supports - we do this by passing the getTypographyClassesAndStyles hook a flag to tell it whether to convert Updated CHANGELOG.md Added tests
This happens when the spring animation overshoots above scale(1) during the transition.
derekblank
force-pushed
the
rnmobile/upgrade/0.69.4-ios
branch
from
October 11, 2022 08:07
063be77
to
60923d9
Compare
derekblank
force-pushed
the
rnmobile/upgrade/0.69.4-ios
branch
2 times, most recently
from
October 11, 2022 08:25
051bef5
to
b5173bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress...
Related PRs
Feature branch
Android integration
iOS integration
What?
Why?
How?
Testing Instructions
Screenshots or screencast