[Gutenberg] - React Native 0.69.4 Upgrade #17066

geriux · 2022-08-22T15:23:18Z

This PR adds changes to support the React Native 0.69.4 upgrade.

It removes the reference to hermes-mirror since it's no longer used.

It also adds several implementations in libs/editor/build.gradle since they're not included with the React Native and Hermes binaries.

Related PRs

Feature branch

Android integration

iOS integration

To test:

CI checks should pass, as well as checking the editor opens correctly with the builds from this PR.

Regression Notes

Potential unintended areas of impact
Editor
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing, CI tests.
What automated tests I added (or what prevented me from doing so)
None as there is no added functionality

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…es and react native binaries. It also comments out excluding the hermes debug libraries

WordPress/build.gradle

wpmobilebot · 2022-09-21T13:22:39Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17066-24eb8f5.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`24eb8f5`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2022-09-21T13:22:51Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17066-24eb8f5.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`24eb8f5`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

# Conflicts: # build.gradle

…es and react native binaries. It also comments out excluding the hermes debug libraries

geriux · 2022-10-20T17:20:55Z

@fluiddot Android CI issues are now solved after 5dad8d5

# Conflicts: # build.gradle

fluiddot

@derekblank I reviewed the PR and noticed an issue in the latest code changes that might be the culprit of the CI checks nos passing, although it's hard to tell based on the error output. Before proceeding, let's try to solve them and check if the CI checks pass.

build.gradle

…press-mobile/WordPress-Android into gutenberg/react-native-0.69

wpmobilebot · 2022-12-07T03:26:43Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:editor
+|    +--- com.facebook.soloader:soloader:{strictly 0.10.4} -> 0.10.4
+|    |    +--- com.facebook.soloader:annotation:0.10.4
+|    |    \--- com.facebook.soloader:nativeloader:0.10.4
+|    +--- com.facebook.fresco:fresco:2.5.0
+|    |    +--- com.facebook.fresco:soloader:2.5.0
+|    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+|    |    |    \--- com.facebook.soloader:soloader:0.10.1 -> 0.10.4 (*)
+|    |    +--- com.facebook.soloader:nativeloader:0.10.1 -> 0.10.4
+|    |    +--- com.facebook.fresco:ui-common:2.5.0
+|    |    |    \--- com.facebook.fresco:fbcore:2.5.0
+|    |    +--- com.facebook.fresco:fbcore:2.5.0
+|    |    +--- com.facebook.fresco:drawee:2.5.0
+|    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+|    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0
+|    |    |    |    +--- com.facebook.soloader:nativeloader:0.10.1 -> 0.10.4
+|    |    |    |    +--- com.facebook.soloader:annotation:0.10.1 -> 0.10.4
+|    |    |    |    +--- com.parse.bolts:bolts-tasks:1.4.0
+|    |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+|    |    |    |    \--- com.facebook.fresco:imagepipeline-base:2.5.0
+|    |    |    |         +--- com.facebook.infer.annotation:infer-annotation:0.18.0
+|    |    |    |         |    +--- com.google.code.findbugs:jsr305:3.0.1 -> 3.0.2
+|    |    |    |         |    \--- org.jetbrains.kotlin:kotlin-annotations-jvm:1.3.72
+|    |    |    |         +--- com.facebook.soloader:annotation:0.10.1 -> 0.10.4
+|    |    |    |         +--- com.parse.bolts:bolts-tasks:1.4.0
+|    |    |    |         \--- com.facebook.fresco:fbcore:2.5.0
+|    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0
+|    |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+|    |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+|    |    |    |    \--- com.facebook.soloader:soloader:0.10.1 -> 0.10.4 (*)
+|    |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0
+|    |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+|    |    |    |    \--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+|    |    |    +--- com.facebook.fresco:memory-type-native:2.5.0
+|    |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+|    |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+|    |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+|    |    |    |    \--- com.facebook.soloader:nativeloader:0.10.1 -> 0.10.4
+|    |    |    +--- com.facebook.fresco:memory-type-java:2.5.0
+|    |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+|    |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+|    |    |    |    \--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+|    |    |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
+|    |    |    \--- com.facebook.fresco:middleware:2.5.0
+|    |    |         +--- com.facebook.fresco:fbcore:2.5.0
+|    |    |         \--- com.facebook.fresco:ui-common:2.5.0 (*)
+|    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+|    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+|    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
+|    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
+|    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
+|    |    +--- com.facebook.fresco:nativeimagefilters:2.5.0
+|    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+|    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+|    |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
+|    |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
+|    |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
+|    |    |    +--- com.facebook.soloader:nativeloader:0.10.1 -> 0.10.4
+|    |    |    +--- com.parse.bolts:bolts-tasks:1.4.0
+|    |    |    \--- com.facebook.fresco:fbcore:2.5.0
+|    |    \--- com.facebook.fresco:nativeimagetranscoder:2.5.0
+|    |         +--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
+|    |         +--- com.facebook.soloader:nativeloader:0.10.1 -> 0.10.4
+|    |         +--- com.parse.bolts:bolts-tasks:1.4.0
+|    |         \--- com.facebook.fresco:fbcore:2.5.0
+|    +--- com.facebook.fresco:imagepipeline-okhttp3:2.5.0
+|    |    +--- com.facebook.fresco:fbcore:2.5.0
+|    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+|    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+|    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
+|    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
+|    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
+|    |    \--- com.squareup.okhttp3:okhttp:3.12.1 -> 4.9.2 (*)
+|    +--- com.facebook.fbjni:fbjni:0.2.2
+|    |    \--- com.facebook.soloader:nativeloader:0.10.1 -> 0.10.4
+|    +--- com.facebook.react:hermes-engine:0.69.4
+|    +--- com.facebook.react:react-native:0.69.4
-|    \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.85.1
-|         +--- com.facebook.fresco:animated-gif:2.0.0
-|         |    +--- com.parse.bolts:bolts-tasks:1.4.0
-|         |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.1
-|         |    |    +--- com.facebook.soloader:annotation:0.10.1
-|         |    |    \--- com.facebook.soloader:nativeloader:0.10.1
-|         |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-|         |    \--- com.facebook.fresco:animated-base:2.0.0
-|         |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-|         |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0
-|         |         |    +--- com.facebook.infer.annotation:infer-annotation:0.18.0
-|         |         |    |    +--- com.google.code.findbugs:jsr305:3.0.1 -> 3.0.2
-|         |         |    |    \--- org.jetbrains.kotlin:kotlin-annotations-jvm:1.3.72
-|         |         |    +--- com.facebook.soloader:annotation:0.10.1
-|         |         |    +--- com.parse.bolts:bolts-tasks:1.4.0
-|         |         |    \--- com.facebook.fresco:fbcore:2.5.0
-|         |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0
-|         |         |    +--- com.facebook.soloader:nativeloader:0.10.1
-|         |         |    +--- com.facebook.soloader:annotation:0.10.1
-|         |         |    +--- com.parse.bolts:bolts-tasks:1.4.0
-|         |         |    +--- com.facebook.fresco:fbcore:2.5.0
-|         |         |    \--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
-|         |         +--- com.facebook.fresco:animated-drawable:2.0.0
-|         |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-|         |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0
-|         |         |    |    +--- com.facebook.fresco:fbcore:2.5.0
-|         |         |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-|         |         |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0
-|         |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-|         |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-|         |         |    |    |    \--- com.facebook.soloader:soloader:0.10.1 (*)
-|         |         |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0
-|         |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-|         |         |    |    |    \--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-|         |         |    |    +--- com.facebook.fresco:memory-type-native:2.5.0
-|         |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-|         |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-|         |         |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-|         |         |    |    |    \--- com.facebook.soloader:nativeloader:0.10.1
-|         |         |    |    +--- com.facebook.fresco:memory-type-java:2.5.0
-|         |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-|         |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-|         |         |    |    |    \--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-|         |         |    |    +--- com.facebook.fresco:ui-common:2.5.0
-|         |         |    |    |    \--- com.facebook.fresco:fbcore:2.5.0
-|         |         |    |    \--- com.facebook.fresco:middleware:2.5.0
-|         |         |    |         +--- com.facebook.fresco:fbcore:2.5.0
-|         |         |    |         \--- com.facebook.fresco:ui-common:2.5.0 (*)
-|         |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-|         |         \--- com.parse.bolts:bolts-tasks:1.4.0
-|         +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
-|         +--- com.facebook.react:react-native:0.66.2
-|         |    +--- com.facebook.infer.annotation:infer-annotation:0.18.0 (*)
-|         |    +--- com.facebook.yoga:proguard-annotations:1.19.0
-|         |    +--- javax.inject:javax.inject:1
-|         |    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
-|         |    +--- androidx.autofill:autofill:1.1.0
-|         |    |    \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-|         |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-|         |    +--- com.facebook.fresco:fresco:2.5.0
-|         |    |    +--- com.facebook.fresco:soloader:2.5.0
-|         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-|         |    |    |    \--- com.facebook.soloader:soloader:0.10.1 (*)
-|         |    |    +--- com.facebook.soloader:nativeloader:0.10.1
-|         |    |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:fbcore:2.5.0
-|         |    |    +--- com.facebook.fresco:drawee:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:nativeimagefilters:2.5.0
-|         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-|         |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-|         |    |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
-|         |    |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
-|         |    |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
-|         |    |    |    +--- com.facebook.soloader:nativeloader:0.10.1
-|         |    |    |    +--- com.parse.bolts:bolts-tasks:1.4.0
-|         |    |    |    \--- com.facebook.fresco:fbcore:2.5.0
-|         |    |    \--- com.facebook.fresco:nativeimagetranscoder:2.5.0
-|         |    |         +--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
-|         |    |         +--- com.facebook.soloader:nativeloader:0.10.1
-|         |    |         +--- com.parse.bolts:bolts-tasks:1.4.0
-|         |    |         \--- com.facebook.fresco:fbcore:2.5.0
-|         |    +--- com.facebook.fresco:imagepipeline-okhttp3:2.5.0
-|         |    |    +--- com.facebook.fresco:fbcore:2.5.0
-|         |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
-|         |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
-|         |    |    \--- com.squareup.okhttp3:okhttp:3.12.1 -> 4.9.2 (*)
-|         |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
-|         |    +--- com.facebook.soloader:soloader:0.10.1 (*)
-|         |    +--- com.google.code.findbugs:jsr305:3.0.2
-|         |    +--- com.squareup.okhttp3:okhttp:4.9.1 -> 4.9.2 (*)
-|         |    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.1 -> 4.9.2
-|         |    |    +--- com.squareup.okhttp3:okhttp:4.9.2 (*)
-|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.10 (*)
-|         |    +--- com.squareup.okio:okio:2.9.0 -> 2.10.0 (*)
-|         |    \--- com.facebook.fbjni:fbjni-java-only:0.2.2
-|         |         \--- com.facebook.soloader:nativeloader:0.10.1
-|         +--- org.wordpress-mobile:react-native-svg:9.13.6
-|         |    \--- com.facebook.react:react-native:0.66.2 (*)
-|         +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-4
-|         |    +--- com.facebook.react:react-native:0.66.2 (*)
-|         |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-|         |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    |    |    \--- com.google.guava:guava:27.1-android
-|         |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-|         |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-|         |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-|         |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-|         |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-|         |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-|         |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-|         |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |         +--- androidx.recyclerview:recyclerview:1.1.0 (*)
-|         |    |         \--- androidx.media:media:1.2.1 (*)
-|         |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-|         |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-|         |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-|         |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
-|         |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
-|         +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
-|         |    \--- com.facebook.react:react-native:0.66.2 (*)
-|         +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
-|         |    \--- com.facebook.react:react-native:0.66.2 (*)
-|         +--- org.wordpress-mobile:react-native-get-random-values:1.4.0
-|         |    \--- com.facebook.react:react-native:0.66.2 (*)
-|         +--- org.wordpress-mobile:react-native-masked-view:0.2.6
-|         |    \--- com.facebook.react:react-native:0.66.2 (*)
-|         +--- org.wordpress-mobile:react-native-screens:2.9.0
-|         |    +--- com.facebook.react:react-native:0.66.2 (*)
-|         |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1 (*)
-|         |    +--- androidx.fragment:fragment:1.2.1 -> 1.4.1 (*)
-|         |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-|         |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-|         |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
-|         +--- org.wordpress-mobile:react-native-safe-area-context:3.2.0
-|         |    \--- com.facebook.react:react-native:0.66.2 (*)
-|         +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-4
-|         +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
-|         |    +--- com.facebook.react:react-native:0.66.2 (*)
-|         |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.3.1 (*)
-|         +--- org.wordpress-mobile:react-native-webview:11.6.2
-|         |    +--- com.facebook.react:react-native:0.66.2 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.10 (*)
-|         +--- org.wordpress-mobile:react-native-clipboard:1.9.0
-|         |    \--- com.facebook.react:react-native:0.66.2 (*)
-|         +--- org.wordpress-mobile:react-native-fast-image:8.5.11
-|         |    +--- com.facebook.react:react-native:0.66.2 (*)
-|         |    +--- com.github.bumptech.glide:glide:4.12.0
-|         |    |    +--- com.github.bumptech.glide:gifdecoder:4.12.0
-|         |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-|         |    |    +--- com.github.bumptech.glide:disklrucache:4.12.0
-|         |    |    +--- com.github.bumptech.glide:annotations:4.12.0
-|         |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
-|         |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
-|         |    |    \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
-|         |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-|         |         +--- com.github.bumptech.glide:glide:4.12.0 (*)
-|         |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
-|         |         \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-|         +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
-|         |    +--- com.facebook.react:react-native:0.66.2 (*)
-|         |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.4.1-wp-4
-|         |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
-|         |    +--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.10 (*)
-|         +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.85.1
-|         |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-|         |    +--- androidx.gridlayout:gridlayout:1.0.0
-|         |    |    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
-|         |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-|         |    +--- androidx.cardview:cardview:1.0.0 (*)
-|         |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
-|         |    +--- androidx.recyclerview:recyclerview:1.1.0 (*)
-|         |    +--- com.facebook.react:react-native:0.66.2 (*)
-|         |    +--- org.wordpress:aztec:v1.6.2 (*)
-|         |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.2 (*)
-|         |    +--- org.wordpress.aztec:wordpress-comments:v1.6.2 (*)
-|         |    +--- org.wordpress.aztec:glide-loader:v1.6.2
-|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
-|         |    |    +--- org.wordpress:aztec:v1.6.2 (*)
-|         |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
-|         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
-|         \--- org.wordpress-mobile:hermes-release-mirror:0.66.2
+|    +--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.86.0-alpha1
+|         +--- com.facebook.fresco:animated-gif:2.0.0
+|         |    +--- com.parse.bolts:bolts-tasks:1.4.0
+|         |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+|         |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+|         |    \--- com.facebook.fresco:animated-base:2.0.0
+|         |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+|         |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+|         |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+|         |         +--- com.facebook.fresco:animated-drawable:2.0.0
+|         |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+|         |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+|         |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+|         |         \--- com.parse.bolts:bolts-tasks:1.4.0
+|         +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
+|         +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
+|         |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+|         |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    |    |    \--- com.google.guava:guava:27.1-android
+|         |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+|         |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+|         |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+|         |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+|         |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+|         |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+|         |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+|         |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+|         |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+|         |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+|         |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+|         |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+|         |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |         +--- androidx.recyclerview:recyclerview:1.1.0 (*)
+|         |    |         \--- androidx.media:media:1.2.1 (*)
+|         |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|         |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+|         |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+|         |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
+|         |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
+|         +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
+|         +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
+|         +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-2
+|         +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
+|         |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.3.1 (*)
+|         +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
+|         |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-2
+|         |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
+|         |    +--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.10 (*)
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
+|         |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1 (*)
+|         |    +--- androidx.fragment:fragment:1.2.1 -> 1.4.1 (*)
+|         |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+|         |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+|         |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.10 (*)
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
+|         |    +--- com.github.bumptech.glide:glide:4.12.0
+|         |    |    +--- com.github.bumptech.glide:gifdecoder:4.12.0
+|         |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+|         |    |    +--- com.github.bumptech.glide:disklrucache:4.12.0
+|         |    |    +--- com.github.bumptech.glide:annotations:4.12.0
+|         |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
+|         |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
+|         |    |    \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
+|         |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+|         |         +--- com.github.bumptech.glide:glide:4.12.0 (*)
+|         |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
+|         |         \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+|         +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.86.0-alpha1
+|         |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+|         |    +--- androidx.gridlayout:gridlayout:1.0.0
+|         |    |    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|         |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+|         |    +--- androidx.cardview:cardview:1.0.0 (*)
+|         |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
+|         |    +--- androidx.recyclerview:recyclerview:1.1.0 (*)
+|         |    +--- org.wordpress:aztec:v1.6.2 (*)
+|         |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.2 (*)
+|         |    +--- org.wordpress.aztec:wordpress-comments:v1.6.2 (*)
+|         |    +--- org.wordpress.aztec:glide-loader:v1.6.2
+|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
+|         |    |    +--- org.wordpress:aztec:v1.6.2 (*)
+|         |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
+|    \--- org.jsoup:jsoup:1.10.3 -> 1.11.3
 +--- org.wordpress:fluxc:{strictly 2.6.0} -> 2.6.0
-|    \--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
+|    \--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
+|         +--- com.squareup.okhttp3:okhttp:4.9.2 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.10 (*)
 \--- com.automattic:about:1.0.0
      \--- androidx.compose.ui:ui:1.0.5 -> 1.1.1
-          \--- androidx.autofill:autofill:1.0.0 -> 1.1.0 (*)
+          \--- androidx.autofill:autofill:1.0.0
+               \--- androidx.core:core:1.1.0 -> 1.7.0 (*)

Please review and act accordingly

geriux · 2022-12-07T09:13:51Z

CI checks are now green and the installable build opens the editor correctly.

WordPress/build.gradle

fluiddot · 2022-12-07T09:41:35Z

libs/editor/build.gradle

+    implementation 'com.facebook.fresco:fresco:2.5.0'
+    implementation 'com.facebook.fresco:imagepipeline-okhttp3:2.5.0'
+    implementation 'com.facebook.fbjni:fbjni:0.2.2'
+    implementation 'com.facebook.react:hermes-engine:0.69.4:release@aar'
+    implementation 'com.facebook.react:react-native:0.69.4:release@aar'


It also adds several implementations in libs/editor/build.gradle since they're not included with the React Native and Hermes binaries.

Are these the libraries not included in the React Native and Hermes binaries? I'm wondering if we'd need to define them here or if they could be part of the libraries required by Gutenberg Mobile, could we have them as dependencies in the react-native-bridge build gradle file?

I noticed that we are also setting the React Native version, is this required? Would be a way to let the Gutenberg Mobile library to define this?

Since we encountered issues with using the debug artifacts for both Hermes and React Native instead of the release ones, when excluding them and including them again some libraries needed to be referenced again.

I'm working on a draft PR as a follow-up to improve these, although to be able to force the release artifacts for all builds like (Jalapeno Debug) which are the builds PRs generate, we will have to keep a few implementations. 😅

fluiddot · 2022-12-07T09:43:59Z

libs/editor/build.gradle

+    // Required Aztec dependencies (they should be included but Jitpack seems to be stripping these out)
+    implementation "org.jsoup:jsoup:$jsoupVersion"


I think we haven't updated the Aztec version, so I'm wondering why we need to add this dependency if we didn't have it before 🤔, what changed with the RN upgrade to producing this?

This comment is also related for this question.

👋 @geriux @fluiddot !

I also stumbled upon this just now, that is, while working on the org.jsoup:jsoup dependency update (see here). I just removed this dependency from the libs:editor module (it being unused and all) and the WPAndroid seems to be building/working just fine.

I'm working on a draft PR as a follow-up to improve these, although to be able to force the release artifacts for all builds like (Jalapeno Debug) which are the builds PRs generate, we will have to keep a few implementations. 😅

Should I refrain from removing dependency and ignore this for now, that is, at least until this work above is done? Or maybe it is already done but I can't connect the dots just yet, not sure? 🤔

Thanking you in advance for your advise here! 🙏

and the WPAndroid seems to be building/working just fine.

Does the editor open correctly after this change?

👋 @geriux and thanks for the reply!

Does the editor open correctly after this change?

Yes, I am able to open the editor correctly after this change (both the Classic and Block editor). Unless of course, I am missing something obvious here... 🤔

FYI: I just pushed this removal commit, feel free to test this PR yourself and let me know if everything works as you would have expected.

Looks like the dependency org.jsoup:jsoup is used by Aztec-Android (reference).

In fact, we set the version of that dependency here in Gutenberg. I'm not sure whether it can be removed or not, in any case, this could be tested by checking if the editor can be built and works as expected.

fluiddot

I tested the installable build and the editor worked as expected. LGTM 🎊 !

Regarding the comments I posted in my last review, I think we should address them. However, I agree that shouldn't block the merge, hence we could tackle them in a follow-up PR if needed. Thanks!

Remove hermes-mirror in favor of react-native-mirror having both herm…

3be6f11

…es and react native binaries. It also comments out excluding the hermes debug libraries

geriux added [Status] In Progress gutenberg-mobile labels Aug 22, 2022

geriux commented Aug 22, 2022

View reviewed changes

WordPress/build.gradle Outdated Show resolved Hide resolved

geriux mentioned this pull request Aug 22, 2022

[Mobile] - React Native 0.69.4 Upgrade - Android WordPress/gutenberg#43486

Merged

1 task

Gerardo and others added 5 commits August 23, 2022 13:30

Update Gutenberg ref

67db3c8

Update gutenberg-mobile ref

52acffc

Merge branch 'trunk' into gutenberg/react-native-0.69

650ad55

Update Gutenberg ref

cc396b9

Exclude com.facebook.fbjni from Gutenberg Mobile binary

8d352e6

geriux mentioned this pull request Sep 23, 2022

React Native 0.69.4 Upgrade - Android wordpress-mobile/gutenberg-mobile#5170

Merged

2 tasks

Gerardo added 5 commits September 23, 2022 19:08

Update Gutenberg ref and fix building issues

91efb5f

Update Gutenberg mobile ref

0aab584

Merge branch 'trunk' into gutenberg/react-native-0.69

e2c4645

# Conflicts: # build.gradle

Update Gutenberg ref

5d16496

Update Gutenberg ref

14fed3f

This was referenced Oct 5, 2022

React Native 0.69.4 Upgrade wordpress-mobile/gutenberg-mobile#5193

Merged

[Mobile] - React Native 0.69.4 Upgrade WordPress/gutenberg#43485

Closed

derekblank mentioned this pull request Oct 6, 2022

[Mobile] - React Native 0.69.4 Upgrade - iOS WordPress/gutenberg#44724

Merged

Gerardo added 2 commits October 11, 2022 15:44

Update Gutenberg ref

037f3de

Exclude fabricjni.so

5dfcaf9

This was referenced Oct 12, 2022

[Mobile] - React Native 0.69.4 Upgrade - iOS WordPress/gutenberg#44889

Merged

[Mobile] - React Native 0.69.4 Upgrade - iOS wordpress-mobile/gutenberg-mobile#5192

Merged

[Gutenberg] - React Native 0.69.4 Upgrade wordpress-mobile/WordPress-iOS#19326

Merged

derekblank and others added 4 commits October 19, 2022 15:23

Update gutenberg ref

432afbf

Remove hermes-mirror in favor of react-native-mirror having both herm…

863a75c

…es and react native binaries. It also comments out excluding the hermes debug libraries

Exclude com.facebook.fbjni from Gutenberg Mobile binary

45d4231

Update Gutenberg ref and fix building issues

64602e1

Gerardo and others added 11 commits October 21, 2022 14:41

Merge branch 'trunk' into gutenberg/react-native-0.69

00cb4ce

# Conflicts: # build.gradle

Merge branch 'trunk' into gutenberg/react-native-0.69

8c53322

Update Gutenberg ref

f884bfd

Merge branch 'trunk' into gutenberg/react-native-0.69

b411bda

# Conflicts: # build.gradle

React Native Upgrade - Avoid duplicated classes

14d60e6

Resolve merge conflicts

48b3019

Remove unneeded code

b31f20d

Merge branch 'trunk' into gutenberg/react-native-0.69

ec3cd62

Update Gutenberg ref

1483a61

Update gutenberg ref

9de67b2

Merge branch 'trunk' into gutenberg/react-native-0.69

d0b256f

derekblank marked this pull request as ready for review December 5, 2022 05:55

Update gutenberg-mobile tag to 1.86.0-alpha1

b8ecbfc

fluiddot suggested changes Dec 5, 2022

View reviewed changes

build.gradle Outdated Show resolved Hide resolved

derekblank added 4 commits December 6, 2022 15:23

Fix typo in Gutenberg tag reference

ee6e2ac

Merge branch 'trunk' into gutenberg/react-native-0.69

a3e0f2f

Update gutenberg tag

e3e505d

Merge branch 'gutenberg/react-native-0.69' of https://github.com/word…

24eb8f5

…press-mobile/WordPress-Android into gutenberg/react-native-0.69

geriux removed the [Status] In Progress label Dec 7, 2022

geriux added this to the 21.4 milestone Dec 7, 2022

geriux requested review from derekblank and fluiddot December 7, 2022 09:13

fluiddot reviewed Dec 7, 2022

View reviewed changes

fluiddot approved these changes Dec 7, 2022

View reviewed changes

geriux merged commit cc7318c into trunk Dec 7, 2022

geriux deleted the gutenberg/react-native-0.69 branch December 7, 2022 15:55

SiobhyB mentioned this pull request Jul 12, 2023

[Gutenberg] Force using release variants for editor libraries #18760

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gutenberg] - React Native 0.69.4 Upgrade #17066

[Gutenberg] - React Native 0.69.4 Upgrade #17066

geriux commented Aug 22, 2022 •

edited

Loading

wpmobilebot commented Sep 21, 2022 •

edited

Loading

wpmobilebot commented Sep 21, 2022 •

edited

Loading

geriux commented Oct 20, 2022

fluiddot left a comment

wpmobilebot commented Dec 7, 2022

geriux commented Dec 7, 2022

fluiddot Dec 7, 2022

geriux Dec 7, 2022

fluiddot Dec 7, 2022

geriux Dec 7, 2022

ParaskP7 Mar 14, 2023

geriux Mar 15, 2023

ParaskP7 Mar 15, 2023 •

edited

Loading

ParaskP7 Mar 15, 2023

fluiddot Mar 15, 2023

fluiddot left a comment

		// Required Aztec dependencies (they should be included but Jitpack seems to be stripping these out)
		implementation "org.jsoup:jsoup:$jsoupVersion"

[Gutenberg] - React Native 0.69.4 Upgrade #17066

[Gutenberg] - React Native 0.69.4 Upgrade #17066

Conversation

geriux commented Aug 22, 2022 • edited Loading

Related PRs

Feature branch

Android integration

iOS integration

To test:

Regression Notes

wpmobilebot commented Sep 21, 2022 • edited Loading

wpmobilebot commented Sep 21, 2022 • edited Loading

geriux commented Oct 20, 2022

fluiddot left a comment

Choose a reason for hiding this comment

wpmobilebot commented Dec 7, 2022

The PR caused the following dependency changes:

geriux commented Dec 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ParaskP7 Mar 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fluiddot left a comment

Choose a reason for hiding this comment

geriux commented Aug 22, 2022 •

edited

Loading

wpmobilebot commented Sep 21, 2022 •

edited

Loading

wpmobilebot commented Sep 21, 2022 •

edited

Loading

ParaskP7 Mar 15, 2023 •

edited

Loading